[PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1

Frank Li posted 10 patches 1 week ago
[PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1
Posted by Frank Li 1 week ago
Rename at45db321d@1 to flash@1 to fix below CHECK_DTBS warnings:
at45db321d@1 (atmel,at45db321d): $nodename:0: 'at45db321d@1' does not match '^(flash|.*sram|nand)(@.*)?$'
        from schema $id: http://devicetree.org/schemas/mtd/atmel,dataflash.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx51-babbage.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx51-babbage.dts b/arch/arm/boot/dts/nxp/imx/imx51-babbage.dts
index 1b6ec55f906839f3efde267aaaee035e348f494e..b17264e06e6916057c426179e4207c4a28acf1ab 100644
--- a/arch/arm/boot/dts/nxp/imx/imx51-babbage.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx51-babbage.dts
@@ -327,7 +327,7 @@ vgen3_reg: vgen3 {
 		};
 	};
 
-	flash: at45db321d@1 {
+	flash: flash@1 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "atmel,at45db321d", "atmel,at45", "atmel,dataflash";

-- 
2.34.1
Re: [PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1
Posted by Daniel Baluta 6 days, 10 hours ago
On Mon, Feb 2, 2026 at 9:45 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> Rename at45db321d@1 to flash@1 to fix below CHECK_DTBS warnings:
> at45db321d@1 (atmel,at45db321d): $nodename:0: 'at45db321d@1' does not match '^(flash|.*sram|nand)(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/mtd/atmel,dataflash.yaml
>

The commit message should say *why* the commit is needed and not
focus on fixing the warnings from a tool.

e.g:

ARM: dts: imx51-babbage: Use generic name for flash node

Prefer generic node name 'flash' over the existing specific one to reflect
the function of the device.

This fixes below CHECK_DTBS warning:
 at45db321d@1 (atmel,at45db321d): $nodename:0: 'at45db321d@1' does not
match '^(flash|.*sram|nand)(@.*)?$'
         from schema $id: http://devicetree.org/schemas/mtd/atmel,dataflash.yaml

<snip>

> -       flash: at45db321d@1 {
> +       flash: flash@1 {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 compatible = "atmel,at45db321d", "atmel,at45", "atmel,dataflash";
>

Thanks,
Daniel.