The probe function of the ftgmac100 is rather complex, due to the way
it has evolved over time, dealing with poor DT descriptions, and new
variants of the MAC.
Make use of DT match data to identify the MAC variant, rather than
looking at the compatible string all the time.
Make use of devm_ calls to simplify cleanup. This indirectly fixes
inconsistent goto label names.
Always probe the MDIO bus, when it exists. This simplifies the logic a
bit.
Move code into helpers to simply probe.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
Changes in v3:
- [06/15] Add check for devm_clk_get_optional_enabled().
- [09/15] Directly return status from ftgmac100_setup_mdio(). That is
[13/15] patch behavior, so delete [13/15].
- [09/15] Adjust err lable.
- Add a new patch to make use of devm_ methods for mdiobus to simplify
cleanup.
- Link to v2: https://lore.kernel.org/r/20260116-ftgmac-cleanup-v2-0-81f41f01f2a8@aspeedtech.com
Changes in v2:
- Add net-next prefix.
- [08/15] Updated commit message.
- [04/15] Deleted {}.
- Link to v1: https://lore.kernel.org/r/20260105-ftgmac-cleanup-v1-0-b68e4a3d8fbe@aspeedtech.com
---
Andrew Lunn (14):
net: ftgmac100: List all compatibles
net: ftgmac100: Add match data containing MAC ID
net: ftgmac100: Replace all of_device_is_compatible()
net: ftgmac100: Use devm_alloc_etherdev()
net: ftgmac100: Use devm_request_memory_region/devm_ioremap
net: ftgmac100: Use devm_clk_get_enabled
net: ftgmac100: Simplify error handling for ftgmac100_initial_mac
net: ftgmac100: Move NCSI probe code into a helper
net: ftgmac100: Always register the MDIO bus when it exists
net: ftgmac100: Simplify legacy MDIO setup
net: ftgmac100: Move DT probe into a helper
net: ftgmac100: Remove redundant PHY_POLL
net: ftgmac100: Simplify condition on HW arbitration
net: ftgmac100: Fix wrong netif_napi_del in release
Jacky Chou (1):
net: ftgmac100: Use devm_mdiobus_alloc/devm_of_mdiobus_register
drivers/net/ethernet/faraday/ftgmac100.c | 342 ++++++++++++++++---------------
1 file changed, 180 insertions(+), 162 deletions(-)
---
base-commit: a22f57757f7e88c890499265c383ecb32900b645
change-id: 20251208-ftgmac-cleanup-20b223bf4681
Best regards,
--
Jacky Chou <jacky_chou@aspeedtech.com>