[PATCH 1/3] dt-bindings: usb: axiado,ax3000-udc: Add Axiado UDC

Vladimir Moravcevic posted 3 patches 6 days, 14 hours ago
[PATCH 1/3] dt-bindings: usb: axiado,ax3000-udc: Add Axiado UDC
Posted by Vladimir Moravcevic 6 days, 14 hours ago
Add Axiado ax3000-udc (for USB v2.0 ports) and
ax3000-udc-gen3 (for USB v3.0 ports)
compatible string for AX3000 SoC.

Co-developed-by: Krutik Shah <krutikshah@axiado.com>
Signed-off-by: Krutik Shah <krutikshah@axiado.com>
Co-developed-by: Prasad Bolisetty <pbolisetty@axiado.com>
Signed-off-by: Prasad Bolisetty <pbolisetty@axiado.com>
Signed-off-by: Vladimir Moravcevic <vmoravcevic@axiado.com>
---
 .../devicetree/bindings/usb/axiado,ax3000-udc.yaml | 59 ++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
new file mode 100644
index 000000000000..15658b5c924f
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/axiado,ax3000-udc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Axiado AX3000 USB Device Controller (Corigine-based)
+
+maintainers:
+  - Krutik Shah <krutikshah@axiado.com>
+  - Prasad Bolisetty <pbolisetty@axiado.com>
+  - Vladimir Moravcevic <vmoravcevic@axiado.com>
+
+description: |
+  Axiado AX3000 USB Device Controller (UDC) is used on
+  AX3000 SoCs and evaluation boards. This controller is based on a
+  Corigine USB IP core and provides SuperSpeed (5 Gb/s), High-Speed
+  (480 Mb/s). It supports control, bulk, interrupt, and isochronous
+  transfer types across multiple configurable endpoints. The node
+  describes the memory-mapped register region, interrupt line, and
+  other required properties for the UDC hardware.
+
+properties:
+  compatible:
+    enum:
+      - axiado,ax3000-udc         # AX3000 UDC (USB 2.0/High-Speed)
+      - axiado,ax3000-udc-gen3    # AX3000 UDC (USB 3.0/SuperSpeed)
+
+  reg:
+    maxItems: 1
+    description: Base address and size of the UDC register space.
+
+  interrupts:
+    maxItems: 1
+    description: Interrupt line for the UDC.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        usb@81200000 {
+            compatible = "axiado,ax3000-udc";
+            reg = <0x0 0x81200000 0x0 0x00100000>;
+            interrupt-parent = <&gic500>;
+            interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+        };
+    };

-- 
2.34.1
Re: [PATCH 1/3] dt-bindings: usb: axiado,ax3000-udc: Add Axiado UDC
Posted by Krzysztof Kozlowski 3 days, 20 hours ago
On 02/02/2026 14:16, Vladimir Moravcevic wrote:
> Add Axiado ax3000-udc (for USB v2.0 ports) and
> ax3000-udc-gen3 (for USB v3.0 ports)
> compatible string for AX3000 SoC.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Co-developed-by: Krutik Shah <krutikshah@axiado.com>
> Signed-off-by: Krutik Shah <krutikshah@axiado.com>
> Co-developed-by: Prasad Bolisetty <pbolisetty@axiado.com>
> Signed-off-by: Prasad Bolisetty <pbolisetty@axiado.com>

Please use only real authors here.

> Signed-off-by: Vladimir Moravcevic <vmoravcevic@axiado.com>
> ---
>  .../devicetree/bindings/usb/axiado,ax3000-udc.yaml | 59 ++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
> new file mode 100644
> index 000000000000..15658b5c924f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/axiado,ax3000-udc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Axiado AX3000 USB Device Controller (Corigine-based)
> +
> +maintainers:
> +  - Krutik Shah <krutikshah@axiado.com>
> +  - Prasad Bolisetty <pbolisetty@axiado.com>
> +  - Vladimir Moravcevic <vmoravcevic@axiado.com>
> +
> +description: |
> +  Axiado AX3000 USB Device Controller (UDC) is used on
> +  AX3000 SoCs and evaluation boards. This controller is based on a
> +  Corigine USB IP core and provides SuperSpeed (5 Gb/s), High-Speed
> +  (480 Mb/s). It supports control, bulk, interrupt, and isochronous
> +  transfer types across multiple configurable endpoints. The node
> +  describes the memory-mapped register region, interrupt line, and
> +  other required properties for the UDC hardware.

Drop last sentence, completely redundant. There is no point to explain
what the binding or DT are.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - axiado,ax3000-udc         # AX3000 UDC (USB 2.0/High-Speed)

-gen2

in such case, but I don't like these names. They are awfully
non-hardware looking.

> +      - axiado,ax3000-udc-gen3    # AX3000 UDC (USB 3.0/SuperSpeed)
> +
> +  reg:
> +    maxItems: 1
> +    description: Base address and size of the UDC register space.

Drop description, redundant

> +
> +  interrupts:
> +    maxItems: 1
> +    description: Interrupt line for the UDC.

Drop description

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
Best regards,
Krzysztof