[v5] Add Tenstorrent Atlantis Clock/Reset Controller

[PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Anirudh Srinivasan 1 week ago

Document bindings for Tenstorrent Atlantis PRCM that manages clocks
and resets. This block is instantiated multiple times in the SoC.
This commit documents the clocks from the RCPU PRCM block.

Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
---
 .../bindings/clock/tenstorrent,atlantis-prcm.yaml  |  54 +++++++++++
 MAINTAINERS                                        |   2 +
 .../dt-bindings/clock/tenstorrent,atlantis-prcm.h  | 103 +++++++++++++++++++++
 3 files changed, 159 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
new file mode 100644
index 000000000000..0f3e18f5ea1a
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/tenstorrent,atlantis-prcm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tenstorrent Atlantis PRCM (Power, Reset, Clock Management) Module
+
+maintainers:
+  - Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
+
+description:
+  Multifunctional register block found in Tenstorrent Atlantis SoC whose main
+  function is to control clocks and resets. This block is instantiated multiple
+  times in the SoC, each block controls clock and resets for a different
+  subsystem. RCPU prcm serves low speed IO interfaces.
+
+properties:
+  compatible:
+    enum:
+      - tenstorrent,atlantis-prcm-rcpu
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  "#clock-cells":
+    const: 1
+    description:
+      See <dt-bindings/clock/tenstorrent,atlantis-prcm.h> for valid indices.
+
+  "#reset-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - "#clock-cells"
+  - "#reset-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    clock-controller@a8000000 {
+      compatible = "tenstorrent,atlantis-prcm-rcpu";
+      reg = <0xa8000000 0x10000>;
+      clocks = <&osc_24m>;
+      #clock-cells = <1>;
+      #reset-cells = <1>;
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index dc731d37c8fe..0fc7bc6d0458 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22534,8 +22534,10 @@ M:	Joel Stanley <jms@oss.tenstorrent.com>
 L:	linux-riscv@lists.infradead.org
 S:	Maintained
 T:	git https://github.com/tenstorrent/linux.git
+F:	Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
 F:	Documentation/devicetree/bindings/riscv/tenstorrent.yaml
 F:	arch/riscv/boot/dts/tenstorrent/
+F:	include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
 
 RISC-V THEAD SoC SUPPORT
 M:	Drew Fustini <fustini@kernel.org>
diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
new file mode 100644
index 000000000000..3820781127c3
--- /dev/null
+++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
@@ -0,0 +1,103 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Tenstorrent Atlantis PRCM Clock and Reset Indices
+ *
+ * Copyright (c) 2026 Tenstorrent
+ */
+
+#ifndef _DT_BINDINGS_ATLANTIS_PRCM_H
+#define _DT_BINDINGS_ATLANTIS_PRCM_H
+
+/*
+ * RCPU Domain Clock IDs
+ */
+#define CLK_RCPU_PLL		0
+#define CLK_RCPU_ROOT		1
+#define CLK_RCPU_DIV2		2
+#define CLK_RCPU_DIV4		3
+#define CLK_RCPU_RTC		4
+#define CLK_SMNDMA0_ACLK	5
+#define CLK_SMNDMA1_ACLK	6
+#define CLK_WDT0_PCLK		7
+#define CLK_WDT1_PCLK		8
+#define CLK_TIMER_PCLK		9
+#define CLK_PVTC_PCLK		10
+#define CLK_PMU_PCLK		11
+#define CLK_MAILBOX_HCLK	12
+#define CLK_SEC_SPACC_HCLK	13
+#define CLK_SEC_OTP_HCLK	14
+#define CLK_TRNG_PCLK		15
+#define CLK_SEC_CRC_HCLK	16
+#define CLK_SMN_HCLK		17
+#define CLK_AHB0_HCLK		18
+#define CLK_SMN_PCLK		19
+#define CLK_SMN_CLK		20
+#define CLK_SCRATCHPAD_CLK	21
+#define CLK_RCPU_CORE_CLK	22
+#define CLK_RCPU_ROM_CLK	23
+#define CLK_OTP_LOAD_CLK	24
+#define CLK_NOC_PLL		25
+#define CLK_NOCC_CLK		26
+#define CLK_NOCC_DIV2		27
+#define CLK_NOCC_DIV4		28
+#define CLK_NOCC_RTC		29
+#define CLK_NOCC_CAN		30
+#define CLK_QSPI_SCLK		31
+#define CLK_QSPI_HCLK		32
+#define CLK_I2C0_PCLK		33
+#define CLK_I2C1_PCLK		34
+#define CLK_I2C2_PCLK		35
+#define CLK_I2C3_PCLK		36
+#define CLK_I2C4_PCLK		37
+#define CLK_UART0_PCLK		38
+#define CLK_UART1_PCLK		39
+#define CLK_UART2_PCLK		40
+#define CLK_UART3_PCLK		41
+#define CLK_UART4_PCLK		42
+#define CLK_SPI0_PCLK		43
+#define CLK_SPI1_PCLK		44
+#define CLK_SPI2_PCLK		45
+#define CLK_SPI3_PCLK		46
+#define CLK_GPIO_PCLK		47
+#define CLK_CAN0_HCLK		48
+#define CLK_CAN0_CLK		49
+#define CLK_CAN1_HCLK		50
+#define CLK_CAN1_CLK		51
+#define CLK_CAN0_TIMER_CLK	52
+#define CLK_CAN1_TIMER_CLK	53
+
+/* RCPU domain reset */
+#define RST_SMNDMA0		0
+#define RST_SMNDMA1		1
+#define RST_WDT0		2
+#define RST_WDT1		3
+#define RST_TMR			4
+#define RST_PVTC		5
+#define RST_PMU			6
+#define RST_MAILBOX		7
+#define RST_SPACC		8
+#define RST_OTP			9
+#define RST_TRNG		10
+#define RST_CRC			11
+#define RST_QSPI		12
+#define RST_I2C0		13
+#define RST_I2C1		14
+#define RST_I2C2		15
+#define RST_I2C3		16
+#define RST_I2C4		17
+#define RST_UART0		18
+#define RST_UART1		19
+#define RST_UART2		20
+#define RST_UART3		21
+#define RST_UART4		22
+#define RST_SPI0		23
+#define RST_SPI1		24
+#define RST_SPI2		25
+#define RST_SPI3		26
+#define RST_GPIO		27
+#define RST_CAN0		28
+#define RST_CAN1		29
+#define RST_I2S0		30
+#define RST_I2S1		31
+
+#endif /* _DT_BINDINGS_ATLANTIS_PRCM_H */

-- 
2.43.0

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Krzysztof Kozlowski 4 days, 14 hours ago

On Mon, Feb 02, 2026 at 01:46:49PM -0600, Anirudh Srinivasan wrote:
> Document bindings for Tenstorrent Atlantis PRCM that manages clocks
> and resets. This block is instantiated multiple times in the SoC.
> This commit documents the clocks from the RCPU PRCM block.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> ---
>  .../bindings/clock/tenstorrent,atlantis-prcm.yaml  |  54 +++++++++++
>  MAINTAINERS                                        |   2 +
>  .../dt-bindings/clock/tenstorrent,atlantis-prcm.h  | 103 +++++++++++++++++++++
>  3 files changed, 159 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> new file mode 100644
> index 000000000000..0f3e18f5ea1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml

Still wrong name. Look how is your compatible called.

> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/tenstorrent,atlantis-prcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tenstorrent Atlantis PRCM (Power, Reset, Clock Management) Module
> +
> +maintainers:
> +  - Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> +
> +description:
> +  Multifunctional register block found in Tenstorrent Atlantis SoC whose main
> +  function is to control clocks and resets. This block is instantiated multiple
> +  times in the SoC, each block controls clock and resets for a different
> +  subsystem. RCPU prcm serves low speed IO interfaces.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - tenstorrent,atlantis-prcm-rcpu

Nothing in the changelog explained why 2 other compatibles were dropped.

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  "#clock-cells":
> +    const: 1
> +    description:
> +      See <dt-bindings/clock/tenstorrent,atlantis-prcm.h> for valid indices.
> +
> +  "#reset-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - "#clock-cells"
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock-controller@a8000000 {
> +      compatible = "tenstorrent,atlantis-prcm-rcpu";
> +      reg = <0xa8000000 0x10000>;
> +      clocks = <&osc_24m>;
> +      #clock-cells = <1>;
> +      #reset-cells = <1>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dc731d37c8fe..0fc7bc6d0458 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22534,8 +22534,10 @@ M:	Joel Stanley <jms@oss.tenstorrent.com>
>  L:	linux-riscv@lists.infradead.org
>  S:	Maintained
>  T:	git https://github.com/tenstorrent/linux.git
> +F:	Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
>  F:	Documentation/devicetree/bindings/riscv/tenstorrent.yaml
>  F:	arch/riscv/boot/dts/tenstorrent/
> +F:	include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>  
>  RISC-V THEAD SoC SUPPORT
>  M:	Drew Fustini <fustini@kernel.org>
> diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> new file mode 100644
> index 000000000000..3820781127c3
> --- /dev/null
> +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h

Still wrong name... Look at your compatible.

Please read writing bindings doc in DT dir.

Best regards,
Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Anirudh Srinivasan 4 days, 9 hours ago

Hi Krzysztof,

On Thu, Feb 5, 2026 at 3:23 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Feb 02, 2026 at 01:46:49PM -0600, Anirudh Srinivasan wrote:
> > Document bindings for Tenstorrent Atlantis PRCM that manages clocks
> > and resets. This block is instantiated multiple times in the SoC.
> > This commit documents the clocks from the RCPU PRCM block.
> >
> > Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> > ---
> >  .../bindings/clock/tenstorrent,atlantis-prcm.yaml  |  54 +++++++++++
> >  MAINTAINERS                                        |   2 +
> >  .../dt-bindings/clock/tenstorrent,atlantis-prcm.h  | 103 +++++++++++++++++++++
> >  3 files changed, 159 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> > new file mode 100644
> > index 000000000000..0f3e18f5ea1a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
>
> Still wrong name. Look how is your compatible called.

>
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/tenstorrent,atlantis-prcm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Tenstorrent Atlantis PRCM (Power, Reset, Clock Management) Module
> > +
> > +maintainers:
> > +  - Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> > +
> > +description:
> > +  Multifunctional register block found in Tenstorrent Atlantis SoC whose main
> > +  function is to control clocks and resets. This block is instantiated multiple
> > +  times in the SoC, each block controls clock and resets for a different
> > +  subsystem. RCPU prcm serves low speed IO interfaces.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - tenstorrent,atlantis-prcm-rcpu
>
> Nothing in the changelog explained why 2 other compatibles were dropped.

I have mentioned in the changelog in the cover letter that these will
be added back when the driver for them is added (based on my
discussion with Conor).

>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  "#clock-cells":
> > +    const: 1
> > +    description:
> > +      See <dt-bindings/clock/tenstorrent,atlantis-prcm.h> for valid indices.
> > +
> > +  "#reset-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - "#clock-cells"
> > +  - "#reset-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    clock-controller@a8000000 {
> > +      compatible = "tenstorrent,atlantis-prcm-rcpu";
> > +      reg = <0xa8000000 0x10000>;
> > +      clocks = <&osc_24m>;
> > +      #clock-cells = <1>;
> > +      #reset-cells = <1>;
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index dc731d37c8fe..0fc7bc6d0458 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@oss.tenstorrent.com>
> >  L:   linux-riscv@lists.infradead.org
> >  S:   Maintained
> >  T:   git https://github.com/tenstorrent/linux.git
> > +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> >  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
> >  F:   arch/riscv/boot/dts/tenstorrent/
> > +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >
> >  RISC-V THEAD SoC SUPPORT
> >  M:   Drew Fustini <fustini@kernel.org>
> > diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> > new file mode 100644
> > index 000000000000..3820781127c3
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>
> Still wrong name... Look at your compatible.
>
> Please read writing bindings doc in DT dir.

We will have multiple compatibles in the future (I dropped these in
this version and I have mentioned this in the changelog in the cover
letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
suggests picking a more generic name in this case, so isn't
"tenstorrent,atlantis-prcm" okay for that?

>
> Best regards,
> Krzysztof
>

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Krzysztof Kozlowski 4 days, 5 hours ago

On 05/02/2026 15:31, Anirudh Srinivasan wrote:
>>> +examples:
>>> +  - |
>>> +    clock-controller@a8000000 {
>>> +      compatible = "tenstorrent,atlantis-prcm-rcpu";
>>> +      reg = <0xa8000000 0x10000>;
>>> +      clocks = <&osc_24m>;
>>> +      #clock-cells = <1>;
>>> +      #reset-cells = <1>;
>>> +    };
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index dc731d37c8fe..0fc7bc6d0458 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@oss.tenstorrent.com>
>>>  L:   linux-riscv@lists.infradead.org
>>>  S:   Maintained
>>>  T:   git https://github.com/tenstorrent/linux.git
>>> +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
>>>  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
>>>  F:   arch/riscv/boot/dts/tenstorrent/
>>> +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>>
>>>  RISC-V THEAD SoC SUPPORT
>>>  M:   Drew Fustini <fustini@kernel.org>
>>> diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>> new file mode 100644
>>> index 000000000000..3820781127c3
>>> --- /dev/null
>>> +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>>
>> Still wrong name... Look at your compatible.
>>
>> Please read writing bindings doc in DT dir.
> 
> We will have multiple compatibles in the future (I dropped these in

Maybe you will, maybe not. But you do not have now.

> this version and I have mentioned this in the changelog in the cover
> letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document

Where did you mention it? I went TWICE through it.

> suggests picking a more generic name in this case, so isn't
> "tenstorrent,atlantis-prcm" okay for that?

No, because I don't want to keep guessing this. The docs clearly ask you
to post complete bindings, which now became less-complete, but fine.
Then the next rule asks you to use compatible as filename. You cannot
keep skipping the rules.

Best regards,
Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Anirudh Srinivasan 2 days, 19 hours ago

On Thu, Feb 5, 2026 at 12:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 05/02/2026 15:31, Anirudh Srinivasan wrote:
> >>> +examples:
> >>> +  - |
> >>> +    clock-controller@a8000000 {
> >>> +      compatible = "tenstorrent,atlantis-prcm-rcpu";
> >>> +      reg = <0xa8000000 0x10000>;
> >>> +      clocks = <&osc_24m>;
> >>> +      #clock-cells = <1>;
> >>> +      #reset-cells = <1>;
> >>> +    };
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index dc731d37c8fe..0fc7bc6d0458 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@oss.tenstorrent.com>
> >>>  L:   linux-riscv@lists.infradead.org
> >>>  S:   Maintained
> >>>  T:   git https://github.com/tenstorrent/linux.git
> >>> +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> >>>  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
> >>>  F:   arch/riscv/boot/dts/tenstorrent/
> >>> +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>>
> >>>  RISC-V THEAD SoC SUPPORT
> >>>  M:   Drew Fustini <fustini@kernel.org>
> >>> diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>> new file mode 100644
> >>> index 000000000000..3820781127c3
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>
> >> Still wrong name... Look at your compatible.
> >>
> >> Please read writing bindings doc in DT dir.
> >
> > We will have multiple compatibles in the future (I dropped these in
>
> Maybe you will, maybe not. But you do not have now.

Let me add them now.

>
> > this version and I have mentioned this in the changelog in the cover
> > letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
>
> Where did you mention it? I went TWICE through it.

Conor and I were discussing these in a previous series and were
referring to them as rcpu prcm and !rcpu prcms. I use these terms to
refer to it in "Changes in v4".

>
> > suggests picking a more generic name in this case, so isn't
> > "tenstorrent,atlantis-prcm" okay for that?
>
> No, because I don't want to keep guessing this. The docs clearly ask you
> to post complete bindings, which now became less-complete, but fine.
> Then the next rule asks you to use compatible as filename. You cannot
> keep skipping the rules.

I will add all the compatibles back, so there will be 4 of them named
"tenstorrent,atlantis-prcm-xyz". In that case is it appropriate for
the filename to be "tenstorrent,atlantis-prcm.yaml"?

>
> Best regards,
> Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Krzysztof Kozlowski 2 days, 14 hours ago

On 07/02/2026 05:18, Anirudh Srinivasan wrote:
>>
>>> this version and I have mentioned this in the changelog in the cover
>>> letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
>>
>> Where did you mention it? I went TWICE through it.
> 
> Conor and I were discussing these in a previous series and were
> referring to them as rcpu prcm and !rcpu prcms. I use these terms to
> refer to it in "Changes in v4".

There is no way I could have guessed it. If you remove a compatible you
say "removed compatible" not "removed !rcpu".

> 
>>
>>> suggests picking a more generic name in this case, so isn't
>>> "tenstorrent,atlantis-prcm" okay for that?
>>
>> No, because I don't want to keep guessing this. The docs clearly ask you
>> to post complete bindings, which now became less-complete, but fine.
>> Then the next rule asks you to use compatible as filename. You cannot
>> keep skipping the rules.
> 
> I will add all the compatibles back, so there will be 4 of them named
> "tenstorrent,atlantis-prcm-xyz". In that case is it appropriate for
> the filename to be "tenstorrent,atlantis-prcm.yaml"?

Yes

Best regards,
Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Conor Dooley 2 days, 9 hours ago

On Sat, Feb 07, 2026 at 10:37:02AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2026 05:18, Anirudh Srinivasan wrote:
> >>
> >>> this version and I have mentioned this in the changelog in the cover
> >>> letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
> >>
> >> Where did you mention it? I went TWICE through it.
> > 
> > Conor and I were discussing these in a previous series and were
> > referring to them as rcpu prcm and !rcpu prcms. I use these terms to
> > refer to it in "Changes in v4".
> 
> There is no way I could have guessed it. If you remove a compatible you
> say "removed compatible" not "removed !rcpu".
> 
> > 
> >>
> >>> suggests picking a more generic name in this case, so isn't
> >>> "tenstorrent,atlantis-prcm" okay for that?
> >>
> >> No, because I don't want to keep guessing this. The docs clearly ask you
> >> to post complete bindings, which now became less-complete, but fine.

I don't think it actually is "less complete" without the other
compatibles. The non-rcpu prcms function differently to the rcpu prcm
(they seem to be consumers of clocks that the rcpu produces) and are not
supported by the drivers in this series. They're different devices and I
think should only be documented when support for them comes along. v4
had problems that were caused by trying to document them without
actually having driver support figured out.

> >> Then the next rule asks you to use compatible as filename. You cannot
> >> keep skipping the rules.
> > 
> > I will add all the compatibles back, so there will be 4 of them named
> > "tenstorrent,atlantis-prcm-xyz". In that case is it appropriate for
> > the filename to be "tenstorrent,atlantis-prcm.yaml"?
> 
> Yes

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Krzysztof Kozlowski 2 days, 5 hours ago

On 07/02/2026 15:54, Conor Dooley wrote:
>>>>> suggests picking a more generic name in this case, so isn't
>>>>> "tenstorrent,atlantis-prcm" okay for that?
>>>>
>>>> No, because I don't want to keep guessing this. The docs clearly ask you
>>>> to post complete bindings, which now became less-complete, but fine.
> 
> I don't think it actually is "less complete" without the other
> compatibles. The non-rcpu prcms function differently to the rcpu prcm
> (they seem to be consumers of clocks that the rcpu produces) and are not
> supported by the drivers in this series. They're different devices and I
> think should only be documented when support for them comes along. v4
> had problems that were caused by trying to document them without
> actually having driver support figured out.

It's fine without them, but then let's just name the file after that
only sole compatible.

Best regards,
Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Anirudh Srinivasan 1 day, 2 hours ago

On Sat, Feb 7, 2026 at 12:39 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 07/02/2026 15:54, Conor Dooley wrote:
> >>>>> suggests picking a more generic name in this case, so isn't
> >>>>> "tenstorrent,atlantis-prcm" okay for that?
> >>>>
> >>>> No, because I don't want to keep guessing this. The docs clearly ask you
> >>>> to post complete bindings, which now became less-complete, but fine.
> >
> > I don't think it actually is "less complete" without the other
> > compatibles. The non-rcpu prcms function differently to the rcpu prcm
> > (they seem to be consumers of clocks that the rcpu produces) and are not
> > supported by the drivers in this series. They're different devices and I
> > think should only be documented when support for them comes along. v4
> > had problems that were caused by trying to document them without
> > actually having driver support figured out.
>
> It's fine without them, but then let's just name the file after that
> only sole compatible.

Okay, thank you for clarifying this. I will just add one compatible
and name the bindings file based on that one.

In the future when I add the remaining compatibles (and driver for
them), should I add them to this same bindings file? Can I rename the
file to have a more generic name then? Is renaming bindings files
okay? Or is this something to worry about for later?

>
> Best regards,
> Krzysztof

Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Posted by Conor Dooley 5 hours ago

On Sun, Feb 08, 2026 at 03:39:39PM -0600, Anirudh Srinivasan wrote:
> On Sat, Feb 7, 2026 at 12:39 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On 07/02/2026 15:54, Conor Dooley wrote:
> > >>>>> suggests picking a more generic name in this case, so isn't
> > >>>>> "tenstorrent,atlantis-prcm" okay for that?
> > >>>>
> > >>>> No, because I don't want to keep guessing this. The docs clearly ask you
> > >>>> to post complete bindings, which now became less-complete, but fine.
> > >
> > > I don't think it actually is "less complete" without the other
> > > compatibles. The non-rcpu prcms function differently to the rcpu prcm
> > > (they seem to be consumers of clocks that the rcpu produces) and are not
> > > supported by the drivers in this series. They're different devices and I
> > > think should only be documented when support for them comes along. v4
> > > had problems that were caused by trying to document them without
> > > actually having driver support figured out.
> >
> > It's fine without them, but then let's just name the file after that
> > only sole compatible.
> 
> Okay, thank you for clarifying this. I will just add one compatible
> and name the bindings file based on that one.
> 
> In the future when I add the remaining compatibles (and driver for
> them), should I add them to this same bindings file? Can I rename the
> file to have a more generic name then? Is renaming bindings files
> okay? Or is this something to worry about for later?

Nah, in the future it just keeps the name of one compatible.