1. Patchew
  2. linux
  3. View series

[PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes

Kurt Borja posted 1 patch 4 days, 22 hours ago 
drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Kurt Borja 4 days, 22 hours ago 
Add audio/mic mute key codes found in some Alienware devices.

Cc: stable@vger.kernel.org
Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
index 28076929d6af..62cf28d1fe19 100644
--- a/drivers/platform/x86/dell/dell-wmi-base.c
+++ b/drivers/platform/x86/dell/dell-wmi-base.c
@@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
 	/* Meta key unlock */
 	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
 
+	{ KE_KEY,    0x0109, { KEY_MUTE } },
+	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
+
 	/* Key code is followed by brightness level */
 	{ KE_KEY,    0xe005, { KEY_BRIGHTNESSDOWN } },
 	{ KE_KEY,    0xe006, { KEY_BRIGHTNESSUP } },

---
base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
change-id: 20260126-mute-keys-7f8a27cd317f

-- 
 ~ Kurt
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Mario Limonciello 4 days, 13 hours ago 
On 2/1/26 10:37 PM, Kurt Borja wrote:
> Add audio/mic mute key codes found in some Alienware devices.
> 
> Cc: stable@vger.kernel.org
> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>   drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>   1 file changed, 3 insertions(+)

Make sure that you include Dell.Client.Kernel@dell.com in case they have 
any comments.

I added them to CC.

> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 28076929d6af..62cf28d1fe19 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>   	/* Meta key unlock */
>   	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>   
> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
> +
>   	/* Key code is followed by brightness level */
>   	{ KE_KEY,    0xe005, { KEY_BRIGHTNESSDOWN } },
>   	{ KE_KEY,    0xe006, { KEY_BRIGHTNESSUP } },
> 
> ---
> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> change-id: 20260126-mute-keys-7f8a27cd317f
>
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Kurt Borja 4 days, 9 hours ago 
On Mon Feb 2, 2026 at 9:17 AM -05, Mario Limonciello wrote:
> On 2/1/26 10:37 PM, Kurt Borja wrote:
>> Add audio/mic mute key codes found in some Alienware devices.
>> 
>> Cc: stable@vger.kernel.org
>> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>>   drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>>   1 file changed, 3 insertions(+)
>
> Make sure that you include Dell.Client.Kernel@dell.com in case they have 
> any comments.
>
> I added them to CC.

Hi Mario,

Thanks, I'll add it.

-- 
Thanks,
 ~ Kurt
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Pali Rohár 4 days, 19 hours ago 
On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
> Add audio/mic mute key codes found in some Alienware devices.
> 
> Cc: stable@vger.kernel.org
> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 28076929d6af..62cf28d1fe19 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>  	/* Meta key unlock */
>  	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>  
> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },

Hello, please keep codes in the array sorted.

> +
>  	/* Key code is followed by brightness level */
>  	{ KE_KEY,    0xe005, { KEY_BRIGHTNESSDOWN } },
>  	{ KE_KEY,    0xe006, { KEY_BRIGHTNESSUP } },
> 
> ---
> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> change-id: 20260126-mute-keys-7f8a27cd317f
> 
> -- 
>  ~ Kurt
>
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Kurt Borja 4 days, 9 hours ago 
On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
> On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> Add audio/mic mute key codes found in some Alienware devices.
>> 
>> Cc: stable@vger.kernel.org
>> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> index 28076929d6af..62cf28d1fe19 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>>  	/* Meta key unlock */
>>  	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>>  
>> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
>> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
>
> Hello, please keep codes in the array sorted.

Hi Pali,

I thought I sorted it... I'll fix it, thanks!

>
>> +
>>  	/* Key code is followed by brightness level */
>>  	{ KE_KEY,    0xe005, { KEY_BRIGHTNESSDOWN } },
>>  	{ KE_KEY,    0xe006, { KEY_BRIGHTNESSUP } },
>> 
>> ---
>> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
>> change-id: 20260126-mute-keys-7f8a27cd317f
>> 
>> -- 
>>  ~ Kurt
>> 

-- 
Thanks,
 ~ Kurt
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Pali Rohár 4 days, 9 hours ago 
On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
> >> Add audio/mic mute key codes found in some Alienware devices.
> >> 
> >> Cc: stable@vger.kernel.org
> >> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> >> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> >> ---
> >>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >> 
> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> >> index 28076929d6af..62cf28d1fe19 100644
> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
> >>  	/* Meta key unlock */
> >>  	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
> >>  
> >> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
> >> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
> >
> > Hello, please keep codes in the array sorted.
> 
> Hi Pali,
> 
> I thought I sorted it... I'll fix it, thanks!

Before is value 0xe001 and your new values are 0x01xx. Most of values
are 0xeXXX, so it is quite unusual that Dell allocated values with
different pattern.

Also, could you please include into commit message for which Alienware
devices is change needed? It would help to detect devices which will be
fixed by your change.

And please add some comment into source file above those two new codes
for which are needed, in similar way how we have commented/documented
other key codes.

> >
> >> +
> >>  	/* Key code is followed by brightness level */
> >>  	{ KE_KEY,    0xe005, { KEY_BRIGHTNESSDOWN } },
> >>  	{ KE_KEY,    0xe006, { KEY_BRIGHTNESSUP } },
> >> 
> >> ---
> >> base-commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91
> >> change-id: 20260126-mute-keys-7f8a27cd317f
> >> 
> >> -- 
> >>  ~ Kurt
> >> 
> 
> -- 
> Thanks,
>  ~ Kurt
Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Posted by Kurt Borja 4 days ago 
On Mon Feb 2, 2026 at 12:43 PM -05, Pali Rohár wrote:
> On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
>> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
>> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> >> Add audio/mic mute key codes found in some Alienware devices.
>> >> 
>> >> Cc: stable@vger.kernel.org
>> >> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> >> ---
>> >>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> >>  1 file changed, 3 insertions(+)
>> >> 
>> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> index 28076929d6af..62cf28d1fe19 100644
>> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>> >>  	/* Meta key unlock */
>> >>  	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>> >>  
>> >> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
>> >> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
>> >
>> > Hello, please keep codes in the array sorted.
>> 
>> Hi Pali,
>> 
>> I thought I sorted it... I'll fix it, thanks!
>
> Before is value 0xe001 and your new values are 0x01xx. Most of values
> are 0xeXXX, so it is quite unusual that Dell allocated values with
> different pattern.

It is a bit unusual but it corresponds with the user report

	dell_wmi: Unknown key with type 0x0000 and code 0x0109 pressed
	dell_wmi: Unknown key with type 0x0000 and code 0x0150 pressed

and I also checked the acpidump.

>
> Also, could you please include into commit message for which Alienware
> devices is change needed? It would help to detect devices which will be
> fixed by your change.

Sure, the model is Alienware m18 r1 AMD.

I said "some" in the commit message because it's very likely other
Alienware models also use these codes.

>
> And please add some comment into source file above those two new codes
> for which are needed, in similar way how we have commented/documented
> other key codes.

Ack.

-- 
Thanks,
 ~ Kurt

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.