First of all, on SM8250 Iris (ex-Venus) core needs to scale clocks which
are powered by the MMCX domain. Add MMCX domain to the list of the power
domain to be used on this platform.
While we are at it, drop minItems from both power-domains and
power-domains-names, it doesn't make sense from the hardware point of
view. There are always 2 GDSCs and two power rails wired to the video
clock controller and Venus. Disallow passing just two.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
index da54493220c9..04cbacc251d7 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
@@ -21,15 +21,14 @@ properties:
const: qcom,sm8250-venus
power-domains:
- minItems: 2
- maxItems: 3
+ maxItems: 4
power-domain-names:
- minItems: 2
items:
- const: venus
- const: vcodec0
- const: mx
+ - const: mmcx
clocks:
maxItems: 3
@@ -114,8 +113,9 @@ examples:
interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&videocc MVS0C_GDSC>,
<&videocc MVS0_GDSC>,
- <&rpmhpd RPMHPD_MX>;
- power-domain-names = "venus", "vcodec0", "mx";
+ <&rpmhpd RPMHPD_MX>,
+ <&rpmhpd RPMHPD_MMCX>;
+ power-domain-names = "venus", "vcodec0", "mx", "mmcx";
clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
<&videocc VIDEO_CC_MVS0C_CLK>,
--
2.47.3On 01/02/2026 10:49, Dmitry Baryshkov wrote: > First of all, on SM8250 Iris (ex-Venus) core needs to scale clocks which > are powered by the MMCX domain. Add MMCX domain to the list of the power > domain to be used on this platform. > > While we are at it, drop minItems from both power-domains and > power-domains-names, it doesn't make sense from the hardware point of > view. There are always 2 GDSCs and two power rails wired to the video > clock controller and Venus. Disallow passing just two. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > index da54493220c9..04cbacc251d7 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > @@ -21,15 +21,14 @@ properties: > const: qcom,sm8250-venus > > power-domains: > - minItems: 2 > - maxItems: 3 > + maxItems: 4 > > power-domain-names: > - minItems: 2 > items: > - const: venus > - const: vcodec0 > - const: mx > + - const: mmcx > > clocks: > maxItems: 3 > @@ -114,8 +113,9 @@ examples: > interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > power-domains = <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > - <&rpmhpd RPMHPD_MX>; > - power-domain-names = "venus", "vcodec0", "mx"; > + <&rpmhpd RPMHPD_MX>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names = "venus", "vcodec0", "mx", "mmcx"; > > clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > <&videocc VIDEO_CC_MVS0C_CLK>, > > -- > 2.47.3 > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 2/1/2026 4:19 PM, Dmitry Baryshkov wrote: > First of all, on SM8250 Iris (ex-Venus) core needs to scale clocks which > are powered by the MMCX domain. Add MMCX domain to the list of the power > domain to be used on this platform. > > While we are at it, drop minItems from both power-domains and > power-domains-names, it doesn't make sense from the hardware point of > view. There are always 2 GDSCs and two power rails wired to the video > clock controller and Venus. Disallow passing just two. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > index da54493220c9..04cbacc251d7 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > @@ -21,15 +21,14 @@ properties: > const: qcom,sm8250-venus > > power-domains: > - minItems: 2 > - maxItems: 3 > + maxItems: 4 > > power-domain-names: > - minItems: 2 > items: > - const: venus > - const: vcodec0 > - const: mx > + - const: mmcx > > clocks: > maxItems: 3 > @@ -114,8 +113,9 @@ examples: > interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > power-domains = <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > - <&rpmhpd RPMHPD_MX>; > - power-domain-names = "venus", "vcodec0", "mx"; > + <&rpmhpd RPMHPD_MX>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names = "venus", "vcodec0", "mx", "mmcx"; > > clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > <&videocc VIDEO_CC_MVS0C_CLK>, > Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com> Thanks, Dikshita
On 2/1/26 11:49 AM, Dmitry Baryshkov wrote: > First of all, on SM8250 Iris (ex-Venus) core needs to scale clocks which > are powered by the MMCX domain. Add MMCX domain to the list of the power > domain to be used on this platform. > > While we are at it, drop minItems from both power-domains and > power-domains-names, it doesn't make sense from the hardware point of > view. There are always 2 GDSCs and two power rails wired to the video > clock controller and Venus. Disallow passing just two. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
© 2016 - 2026 Red Hat, Inc.