iio: gyro: mpu3050-i2c: use pm_runtime_resume_and_get()

[PATCH] iio: gyro: mpu3050-i2c: use pm_runtime_resume_and_get()

Posted by Antoniu Miclaus 1 week ago

Use pm_runtime_resume_and_get() in bypass_select() and return its
result directly. Unlike pm_runtime_get_sync(), it doesn't increment
the refcount on failure.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/gyro/mpu3050-i2c.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
index 092878f2c886..6549b22e643d 100644
--- a/drivers/iio/gyro/mpu3050-i2c.c
+++ b/drivers/iio/gyro/mpu3050-i2c.c
@@ -19,8 +19,7 @@ static int mpu3050_i2c_bypass_select(struct i2c_mux_core *mux, u32 chan_id)
 	struct mpu3050 *mpu3050 = i2c_mux_priv(mux);
 
 	/* Just power up the device, that is all that is needed */
-	pm_runtime_get_sync(mpu3050->dev);
-	return 0;
+	return pm_runtime_resume_and_get(mpu3050->dev);
 }
 
 static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
-- 
2.43.0

Re: [PATCH] iio: gyro: mpu3050-i2c: use pm_runtime_resume_and_get()

Posted by Andy Shevchenko 4 days, 1 hour ago

On Fri, Jan 30, 2026 at 05:32:26PM +0200, Antoniu Miclaus wrote:
> Use pm_runtime_resume_and_get() in bypass_select() and return its
> result directly. Unlike pm_runtime_get_sync(), it doesn't increment
> the refcount on failure.

...

>  	/* Just power up the device, that is all that is needed */
> -	pm_runtime_get_sync(mpu3050->dev);
> -	return 0;
> +	return pm_runtime_resume_and_get(mpu3050->dev);

Will it also return positive values?

...

Same Q to the next change.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: gyro: mpu3050-i2c: use pm_runtime_resume_and_get()

Posted by Jonathan Cameron 6 days, 19 hours ago

On Fri, 30 Jan 2026 17:32:26 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Use pm_runtime_resume_and_get() in bypass_select() and return its
> result directly. Unlike pm_runtime_get_sync(), it doesn't increment
> the refcount on failure.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>

Please always put a cover letter on anything with more than one patch.
Provides both a nice name for the series in patchwork etc and a 
single place to reply.

Are these fixes?  What is side effect of the wrong ref count?

> ---
>  drivers/iio/gyro/mpu3050-i2c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
> index 092878f2c886..6549b22e643d 100644
> --- a/drivers/iio/gyro/mpu3050-i2c.c
> +++ b/drivers/iio/gyro/mpu3050-i2c.c
> @@ -19,8 +19,7 @@ static int mpu3050_i2c_bypass_select(struct i2c_mux_core *mux, u32 chan_id)
>  	struct mpu3050 *mpu3050 = i2c_mux_priv(mux);
>  
>  	/* Just power up the device, that is all that is needed */
> -	pm_runtime_get_sync(mpu3050->dev);
> -	return 0;
> +	return pm_runtime_resume_and_get(mpu3050->dev);
>  }
>  
>  static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)

Re: [PATCH] iio: gyro: mpu3050-i2c: use pm_runtime_resume_and_get()

Posted by Nuno Sá 4 days, 3 hours ago

On Sat, 2026-01-31 at 16:41 +0000, Jonathan Cameron wrote:
> On Fri, 30 Jan 2026 17:32:26 +0200
> Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> 
> > Use pm_runtime_resume_and_get() in bypass_select() and return its
> > result directly. Unlike pm_runtime_get_sync(), it doesn't increment
> > the refcount on failure.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> 
> Please always put a cover letter on anything with more than one patch.
> Provides both a nice name for the series in patchwork etc and a 
> single place to reply.
> 
> Are these fixes?  What is side effect of the wrong ref count?

Yeps, at first glance I would count this as a fix...

- Nuno Sá
>

[PATCH] iio: gyro: mpu3050-core: use pm_runtime_resume_and_get()

Posted by Antoniu Miclaus 1 week ago

Use pm_runtime_resume_and_get() in mpu3050_read_raw() and
mpu3050_buffer_preenable(), adding proper error handling. In
preenable, call pm_runtime_put_autosuspend() if set_8khz_samplerate()
fails since postdisable won't be called on preenable failure.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index ee2fcd20545d..1cc421eb4782 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -322,7 +322,9 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
 		}
 	case IIO_CHAN_INFO_RAW:
 		/* Resume device */
-		pm_runtime_get_sync(mpu3050->dev);
+		ret = pm_runtime_resume_and_get(mpu3050->dev);
+		if (ret)
+			return ret;
 		mutex_lock(&mpu3050->lock);
 
 		ret = mpu3050_set_8khz_samplerate(mpu3050);
@@ -647,12 +649,19 @@ static irqreturn_t mpu3050_trigger_handler(int irq, void *p)
 static int mpu3050_buffer_preenable(struct iio_dev *indio_dev)
 {
 	struct mpu3050 *mpu3050 = iio_priv(indio_dev);
+	int ret;
 
-	pm_runtime_get_sync(mpu3050->dev);
+	ret = pm_runtime_resume_and_get(mpu3050->dev);
+	if (ret)
+		return ret;
 
 	/* Unless we have OUR trigger active, run at full speed */
-	if (!mpu3050->hw_irq_trigger)
-		return mpu3050_set_8khz_samplerate(mpu3050);
+	if (!mpu3050->hw_irq_trigger) {
+		ret = mpu3050_set_8khz_samplerate(mpu3050);
+		if (ret)
+			pm_runtime_put_autosuspend(mpu3050->dev);
+		return ret;
+	}
 
 	return 0;
 }
-- 
2.43.0

Re: [PATCH] iio: gyro: mpu3050-core: use pm_runtime_resume_and_get()

Posted by Linus Walleij 4 days, 12 hours ago

On Fri, Jan 30, 2026 at 4:34 PM Antoniu Miclaus
<antoniu.miclaus@analog.com> wrote:

> Use pm_runtime_resume_and_get() in mpu3050_read_raw() and
> mpu3050_buffer_preenable(), adding proper error handling. In
> preenable, call pm_runtime_put_autosuspend() if set_8khz_samplerate()
> fails since postdisable won't be called on preenable failure.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij