[PATCH v4 13/19] dt-bindings: dma: ti: Add K3 PKTDMA V2

Sai Sree Kartheek Adivi posted 19 patches 1 week, 3 days ago
[PATCH v4 13/19] dt-bindings: dma: ti: Add K3 PKTDMA V2
Posted by Sai Sree Kartheek Adivi 1 week, 3 days ago
New binding document for
Texas Instruments K3 Packet DMA (PKTDMA) V2.

PKTDMA V2 is introduced as part of AM62L.

Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
---
 .../bindings/dma/ti/ti,k3-pktdma-v2.yaml      | 90 +++++++++++++++++++
 1 file changed, 90 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml

diff --git a/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml b/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
new file mode 100644
index 0000000000000..e8afa6f6738b7
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2024-2025 Texas Instruments Incorporated
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/ti/ti,k3-pktdma-v2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments K3 DMSS PKTDMA V2
+
+maintainers:
+  - Sai Sree Kartheek Adivi <s-adivi@ti.com>
+
+description: |
+  The PKTDMA V2 is intended to perform similar functions as the packet mode
+  channels of K3 UDMA-P. PKTDMA V2 only includes Split channels to service
+  PSI-L based peripherals.
+
+  The peripherals can be PSI-L native or legacy, non PSI-L native peripherals
+  with PDMAs. PDMA is tasked to act as a bridge between the PSI-L fabric and the
+  legacy peripheral.
+
+allOf:
+  - $ref: /schemas/dma/dma-controller.yaml#
+
+properties:
+  compatible:
+    const: ti,am62l-dmss-pktdma
+
+  reg:
+    items:
+      - description: Packet DMA Control /Status
+      - description: Channel Realtime
+      - description: Ring Realtime
+
+  reg-names:
+    items:
+      - const: gcfg
+      - const: chanrt
+      - const: ringrt
+
+  "#dma-cells":
+    const: 2
+    description: |
+      cell 1: Channel identification for the peripheral
+        PSI-L thread ID of the remote (to BCDMA) end.
+        Valid ranges for thread ID depends on the data movement direction:
+        for source thread IDs (rx): 0 - 0x7fff
+        for destination thread IDs (tx): 0x8000 - 0xffff
+
+        Please refer to the device documentation for the PSI-L thread map and
+        also the PSI-L peripheral chapter for the correct thread ID.
+
+      cell 2: ASEL value for the channel
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - "#dma-cells"
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    main {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        main_pktdma: dma-controller@485c0000 {
+            compatible = "ti,am62l-dmss-pktdma";
+            reg = <0x00 0x485c0000 0x00 0x4000>,
+                  <0x00 0x48900000 0x00 0x80000>,
+                  <0x00 0x47200000 0x00 0x100000>;
+            reg-names = "gcfg", "chanrt", "ringrt";
+            #dma-cells = <2>;
+        };
+
+        serial@2800000 {
+            compatible = "ti,am64-uart", "ti,am654-uart";
+            reg = <0x00 0x02800000 0x00 0x100>;
+            power-domains = <&scmi_pds 89>;
+            clocks = <&scmi_clk 358>;
+            clock-names = "fclk";
+            dmas = <&main_pktdma 0xc400 0>,
+                   /* tx: PSI-L thread ID, ASEL value */
+                   <&main_pktdma 0x4400 0>;
+                   /* rx: PSI-L thread ID, ASEL value */
+            dma-names = "tx", "rx";
+        };
+    };
-- 
2.34.1
Re: [PATCH v4 13/19] dt-bindings: dma: ti: Add K3 PKTDMA V2
Posted by Krzysztof Kozlowski 4 days, 4 hours ago
On 30/01/2026 12:01, Sai Sree Kartheek Adivi wrote:
> New binding document for
> Texas Instruments K3 Packet DMA (PKTDMA) V2.
> 
> PKTDMA V2 is introduced as part of AM62L.
> 
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
>  .../bindings/dma/ti/ti,k3-pktdma-v2.yaml      | 90 +++++++++++++++++++

You ignored previous comments and repeated same mistake(s) here.
Additionally you added more things which we did not ask you to add...

Best regards,
Krzysztof
Re: [PATCH v4 13/19] dt-bindings: dma: ti: Add K3 PKTDMA V2
Posted by Frank Li 1 week, 2 days ago
On Fri, Jan 30, 2026 at 04:31:53PM +0530, Sai Sree Kartheek Adivi wrote:
> New binding document for
> Texas Instruments K3 Packet DMA (PKTDMA) V2.
>
> PKTDMA V2 is introduced as part of AM62L.
>
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
>  .../bindings/dma/ti/ti,k3-pktdma-v2.yaml      | 90 +++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml b/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
> new file mode 100644
> index 0000000000000..e8afa6f6738b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2024-2025 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/ti/ti,k3-pktdma-v2.yaml#

filename need use one of compatible string.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments K3 DMSS PKTDMA V2
> +
> +maintainers:
> +  - Sai Sree Kartheek Adivi <s-adivi@ti.com>
> +
> +description: |

Needn't |

> +  The PKTDMA V2 is intended to perform similar functions as the packet mode
> +  channels of K3 UDMA-P. PKTDMA V2 only includes Split channels to service
> +  PSI-L based peripherals.
> +
> +  The peripherals can be PSI-L native or legacy, non PSI-L native peripherals
> +  with PDMAs. PDMA is tasked to act as a bridge between the PSI-L fabric and the
> +  legacy peripheral.
> +
> +allOf:
> +  - $ref: /schemas/dma/dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: ti,am62l-dmss-pktdma
> +
> +  reg:
> +    items:
> +      - description: Packet DMA Control /Status
> +      - description: Channel Realtime
> +      - description: Ring Realtime
> +
> +  reg-names:
> +    items:
> +      - const: gcfg
> +      - const: chanrt
> +      - const: ringrt
> +
> +  "#dma-cells":
> +    const: 2
> +    description: |
> +      cell 1: Channel identification for the peripheral
> +        PSI-L thread ID of the remote (to BCDMA) end.
> +        Valid ranges for thread ID depends on the data movement direction:
> +        for source thread IDs (rx): 0 - 0x7fff
> +        for destination thread IDs (tx): 0x8000 - 0xffff
> +
> +        Please refer to the device documentation for the PSI-L thread map and
> +        also the PSI-L peripheral chapter for the correct thread ID.
> +
> +      cell 2: ASEL value for the channel
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - "#dma-cells"

No irq and clock?

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    main {
> +        #address-cells = <2>;
> +        #size-cells = <2>;

If use 32bit address, needn't main

> +
> +        main_pktdma: dma-controller@485c0000 {

Need need label

> +            compatible = "ti,am62l-dmss-pktdma";
> +            reg = <0x00 0x485c0000 0x00 0x4000>,
> +                  <0x00 0x48900000 0x00 0x80000>,
> +                  <0x00 0x47200000 0x00 0x100000>;
> +            reg-names = "gcfg", "chanrt", "ringrt";
> +            #dma-cells = <2>;
> +        };
> +
> +        serial@2800000 {

Needn't this in example.

Frank
> +            compatible = "ti,am64-uart", "ti,am654-uart";
> +            reg = <0x00 0x02800000 0x00 0x100>;
> +            power-domains = <&scmi_pds 89>;
> +            clocks = <&scmi_clk 358>;
> +            clock-names = "fclk";
> +            dmas = <&main_pktdma 0xc400 0>,
> +                   /* tx: PSI-L thread ID, ASEL value */
> +                   <&main_pktdma 0x4400 0>;
> +                   /* rx: PSI-L thread ID, ASEL value */
> +            dma-names = "tx", "rx";
> +        };
> +    };
> --
> 2.34.1
>
Re: [PATCH v4 13/19] dt-bindings: dma: ti: Add K3 PKTDMA V2
Posted by Rob Herring (Arm) 1 week, 3 days ago
On Fri, 30 Jan 2026 16:31:53 +0530, Sai Sree Kartheek Adivi wrote:
> New binding document for
> Texas Instruments K3 Packet DMA (PKTDMA) V2.
> 
> PKTDMA V2 is introduced as part of AM62L.
> 
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
>  .../bindings/dma/ti/ti,k3-pktdma-v2.yaml      | 90 +++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ti/ti,k3-pktdma-v2.example.dtb: serial@2800000 (ti,am64-uart): 'oneOf' conditional failed, one must be fixed:
	'interrupts' is a required property
	'interrupts-extended' is a required property
	from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260130110159.359501-14-s-adivi@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.