From: Cheng Ming Lin <chengminglin@mxic.com.tw>
This patch adds support for the randomizer feature.
It introduces a 'set_randomizer' callback in 'struct spinand_info' and
'struct spinand_device'.
If a driver implements this callback, the core will call it during
device initialization (spinand_init) to enable the randomizer.
Signed-off-by: Cheng Ming Lin <chengminglin@mxic.com.tw>
---
drivers/mtd/nand/spi/core.c | 21 +++++++++++++++++++++
include/linux/mtd/spinand.h | 9 +++++++++
2 files changed, 30 insertions(+)
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
index d207286572d8..3bf99776cbf5 100644
--- a/drivers/mtd/nand/spi/core.c
+++ b/drivers/mtd/nand/spi/core.c
@@ -206,6 +206,12 @@ static int spinand_cont_read_enable(struct spinand_device *spinand,
return spinand->set_cont_read(spinand, enable);
}
+static int spinand_randomizer_enable(struct spinand_device *spinand,
+ bool enable)
+{
+ return spinand->set_randomizer(spinand, enable);
+}
+
static int spinand_check_ecc_status(struct spinand_device *spinand, u8 status)
{
struct nand_device *nand = spinand_to_nand(spinand);
@@ -1218,6 +1224,19 @@ static int spinand_create_dirmaps(struct spinand_device *spinand)
return 0;
}
+static void spinand_randomizer_init(struct spinand_device *spinand)
+{
+ int ret;
+
+ if (spinand->set_randomizer) {
+ ret = spinand_randomizer_enable(spinand, true);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static const struct nand_ops spinand_ops = {
.erase = spinand_erase,
.markbad = spinand_markbad,
@@ -1412,6 +1431,7 @@ int spinand_match_and_init(struct spinand_device *spinand,
spinand->user_otp = &table[i].user_otp;
spinand->read_retries = table[i].read_retries;
spinand->set_read_retry = table[i].set_read_retry;
+ spinand->set_randomizer = table[i].set_randomizer;
op = spinand_select_op_variant(spinand,
info->op_variants.read_cache);
@@ -1588,6 +1608,7 @@ static int spinand_init(struct spinand_device *spinand)
* ECC initialization must have happened previously.
*/
spinand_cont_read_init(spinand);
+ spinand_randomizer_init(spinand);
mtd->_read_oob = spinand_mtd_read;
mtd->_write_oob = spinand_mtd_write;
diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index ce76f5c632e1..e01315a71222 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -501,6 +501,7 @@ struct spinand_user_otp {
* @user_otp: SPI NAND user OTP info.
* @read_retries: the number of read retry modes supported
* @set_read_retry: enable/disable read retry for data recovery
+ * @set_randomizer: enable/disable randomizer support
*
* Each SPI NAND manufacturer driver should have a spinand_info table
* describing all the chips supported by the driver.
@@ -527,6 +528,8 @@ struct spinand_info {
unsigned int read_retries;
int (*set_read_retry)(struct spinand_device *spinand,
unsigned int read_retry);
+ int (*set_randomizer)(struct spinand_device *spinand,
+ bool enable);
};
#define SPINAND_ID(__method, ...) \
@@ -580,6 +583,9 @@ struct spinand_info {
.read_retries = __read_retries, \
.set_read_retry = __set_read_retry
+#define SPINAND_RANDOMIZER(__set_randomizer) \
+ .set_randomizer = __set_randomizer
+
#define SPINAND_INFO(__model, __id, __memorg, __eccreq, __op_variants, \
__flags, ...) \
{ \
@@ -635,6 +641,7 @@ struct spinand_dirmap {
* @user_otp: SPI NAND user OTP info.
* @read_retries: the number of read retry modes supported
* @set_read_retry: Enable/disable the read retry feature
+ * @set_randomizer: Enable/disable the randomizer feature
*/
struct spinand_device {
struct nand_device base;
@@ -668,6 +675,8 @@ struct spinand_device {
bool cont_read_possible;
int (*set_cont_read)(struct spinand_device *spinand,
bool enable);
+ int (*set_randomizer)(struct spinand_device *spinand,
+ bool enable);
const struct spinand_fact_otp *fact_otp;
const struct spinand_user_otp *user_otp;
--
2.25.1Hi Cheng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.19-rc7]
[also build test WARNING on linus/master next-20260129]
[cannot apply to mtd/nand/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cheng-Ming-Lin/mtd-spi-nand-Add-support-for-randomizer/20260130-173004
base: v6.19-rc7
patch link: https://lore.kernel.org/r/20260130092349.621034-2-linchengming884%40gmail.com
patch subject: [PATCH v3 1/2] mtd: spi-nand: Add support for randomizer
config: sh-randconfig-001-20260130 (https://download.01.org/0day-ci/archive/20260131/202601310149.HWa5PpbD-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260131/202601310149.HWa5PpbD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601310149.HWa5PpbD-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/mtd/nand/spi/core.c: In function 'spinand_randomizer_init':
>> drivers/mtd/nand/spi/core.c:1234:11: warning: 'return' with a value, in function returning void [-Wreturn-type]
1234 | return ret;
| ^~~
drivers/mtd/nand/spi/core.c:1227:13: note: declared here
1227 | static void spinand_randomizer_init(struct spinand_device *spinand)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/spi/core.c:1237:9: warning: 'return' with a value, in function returning void [-Wreturn-type]
1237 | return 0;
| ^
drivers/mtd/nand/spi/core.c:1227:13: note: declared here
1227 | static void spinand_randomizer_init(struct spinand_device *spinand)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +1234 drivers/mtd/nand/spi/core.c
1226
1227 static void spinand_randomizer_init(struct spinand_device *spinand)
1228 {
1229 int ret;
1230
1231 if (spinand->set_randomizer) {
1232 ret = spinand_randomizer_enable(spinand, true);
1233 if (ret)
> 1234 return ret;
1235 }
1236
1237 return 0;
1238 }
1239
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Cheng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.19-rc7]
[also build test WARNING on linus/master next-20260129]
[cannot apply to mtd/nand/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cheng-Ming-Lin/mtd-spi-nand-Add-support-for-randomizer/20260130-173004
base: v6.19-rc7
patch link: https://lore.kernel.org/r/20260130092349.621034-2-linchengming884%40gmail.com
patch subject: [PATCH v3 1/2] mtd: spi-nand: Add support for randomizer
config: s390-randconfig-002-20260130 (https://download.01.org/0day-ci/archive/20260130/202601302312.JXeQH3ao-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601302312.JXeQH3ao-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601302312.JXeQH3ao-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mtd/nand/spi/core.c:1234:4: warning: void function 'spinand_randomizer_init' should not return a value [-Wreturn-mismatch]
1234 | return ret;
| ^ ~~~
drivers/mtd/nand/spi/core.c:1237:2: warning: void function 'spinand_randomizer_init' should not return a value [-Wreturn-mismatch]
1237 | return 0;
| ^ ~
2 warnings generated.
vim +/spinand_randomizer_init +1234 drivers/mtd/nand/spi/core.c
1226
1227 static void spinand_randomizer_init(struct spinand_device *spinand)
1228 {
1229 int ret;
1230
1231 if (spinand->set_randomizer) {
1232 ret = spinand_randomizer_enable(spinand, true);
1233 if (ret)
> 1234 return ret;
1235 }
1236
1237 return 0;
1238 }
1239
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Cheng,
kernel test robot noticed the following build errors:
[auto build test ERROR on v6.19-rc7]
[also build test ERROR on linus/master next-20260129]
[cannot apply to mtd/nand/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cheng-Ming-Lin/mtd-spi-nand-Add-support-for-randomizer/20260130-173004
base: v6.19-rc7
patch link: https://lore.kernel.org/r/20260130092349.621034-2-linchengming884%40gmail.com
patch subject: [PATCH v3 1/2] mtd: spi-nand: Add support for randomizer
config: i386-buildonly-randconfig-004-20260130 (https://download.01.org/0day-ci/archive/20260130/202601302310.y3KX2o43-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601302310.y3KX2o43-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601302310.y3KX2o43-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/mtd/nand/spi/core.c: In function 'spinand_randomizer_init':
>> drivers/mtd/nand/spi/core.c:1234:32: error: 'return' with a value, in function returning void [-Wreturn-mismatch]
1234 | return ret;
| ^~~
drivers/mtd/nand/spi/core.c:1227:13: note: declared here
1227 | static void spinand_randomizer_init(struct spinand_device *spinand)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/spi/core.c:1237:16: error: 'return' with a value, in function returning void [-Wreturn-mismatch]
1237 | return 0;
| ^
drivers/mtd/nand/spi/core.c:1227:13: note: declared here
1227 | static void spinand_randomizer_init(struct spinand_device *spinand)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +1234 drivers/mtd/nand/spi/core.c
1226
1227 static void spinand_randomizer_init(struct spinand_device *spinand)
1228 {
1229 int ret;
1230
1231 if (spinand->set_randomizer) {
1232 ret = spinand_randomizer_enable(spinand, true);
1233 if (ret)
> 1234 return ret;
1235 }
1236
1237 return 0;
1238 }
1239
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2026 Red Hat, Inc.