iio: light: apds9306: remove redundant explicit pointer cast

[PATCH] iio: light: apds9306: remove redundant explicit pointer cast

Posted by SAJJA EASWAR SAI 1 week, 1 day ago

C allows implicit conversion from void * to struct apds9306_data *, so the
explicit cast on 'ptr' is unnecessary. Removing it improves readability.

Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@gmail.com>
---
 drivers/iio/light/apds9306.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
index 7e68cca0e..5d18eabd9 100644
--- a/drivers/iio/light/apds9306.c
+++ b/drivers/iio/light/apds9306.c
@@ -1176,7 +1176,7 @@ static int apds9306_init_iio_gts(struct apds9306_data *data)
 
 static void apds9306_powerdown(void *ptr)
 {
-	struct apds9306_data *data = (struct apds9306_data *)ptr;
+	struct apds9306_data *data = ptr;
 	struct apds9306_regfields *rf = &data->rf;
 	int ret;
 
-- 
2.52.0

Re: [PATCH] iio: light: apds9306: remove redundant explicit pointer cast

Posted by Subhajit Ghosh 1 week, 1 day ago

On 30/1/26 07:34, SAJJA EASWAR SAI wrote:
> C allows implicit conversion from void * to struct apds9306_data *, so the
> explicit cast on 'ptr' is unnecessary. Removing it improves readability.
> 
> Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@gmail.com>
> ---
>   drivers/iio/light/apds9306.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 7e68cca0e..5d18eabd9 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -1176,7 +1176,7 @@ static int apds9306_init_iio_gts(struct apds9306_data *data)
>   
>   static void apds9306_powerdown(void *ptr)
>   {
> -	struct apds9306_data *data = (struct apds9306_data *)ptr;
> +	struct apds9306_data *data = ptr;
>   	struct apds9306_regfields *rf = &data->rf;
>   	int ret;
>
Looks good. Thank you.

Acked-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>

Regards,
Subhajit Ghosh

Re: [PATCH] iio: light: apds9306: remove redundant explicit pointer cast

Posted by Jonathan Cameron 6 days, 17 hours ago

On Fri, 30 Jan 2026 09:14:41 +1030
Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote:

> On 30/1/26 07:34, SAJJA EASWAR SAI wrote:
> > C allows implicit conversion from void * to struct apds9306_data *, so the
> > explicit cast on 'ptr' is unnecessary. Removing it improves readability.
> > 
> > Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@gmail.com>
Applied to the testing branch of iio.git.

Thanks,

Jonathan

> > ---
> >   drivers/iio/light/apds9306.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> > index 7e68cca0e..5d18eabd9 100644
> > --- a/drivers/iio/light/apds9306.c
> > +++ b/drivers/iio/light/apds9306.c
> > @@ -1176,7 +1176,7 @@ static int apds9306_init_iio_gts(struct apds9306_data *data)
> >   
> >   static void apds9306_powerdown(void *ptr)
> >   {
> > -	struct apds9306_data *data = (struct apds9306_data *)ptr;
> > +	struct apds9306_data *data = ptr;
> >   	struct apds9306_regfields *rf = &data->rf;
> >   	int ret;
> >  
> Looks good. Thank you.
> 
> Acked-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
> 
> Regards,
> Subhajit Ghosh