[PATCH] iio: humidity: hdc2010: remove unused interrupt_config

Antoniu Miclaus posted 1 patch 1 week, 1 day ago
drivers/iio/humidity/hdc2010.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] iio: humidity: hdc2010: remove unused interrupt_config
Posted by Antoniu Miclaus 1 week, 1 day ago
Remove unused interrupt_config field from hdc2010_data
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/humidity/hdc2010.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/humidity/hdc2010.c b/drivers/iio/humidity/hdc2010.c
index 894a8b4ab193..1a0f18251381 100644
--- a/drivers/iio/humidity/hdc2010.c
+++ b/drivers/iio/humidity/hdc2010.c
@@ -44,7 +44,6 @@ struct hdc2010_data {
 	struct i2c_client *client;
 	struct mutex lock;
 	u8 measurement_config;
-	u8 interrupt_config;
 	u8 drdy_config;
 };
 
-- 
2.43.0
Re: [PATCH] iio: humidity: hdc2010: remove unused interrupt_config
Posted by Jonathan Cameron 6 days, 17 hours ago
On Thu, 29 Jan 2026 19:42:35 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Remove unused interrupt_config field from hdc2010_data
> struct. The field is declared but never accessed in the
> driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
This set are also incorrectly threaded.

Also, don't have more than one set of patches posted at the same
time addressing the same sort of thing.  Just post one set with them
all in, or wait until first lot are merged.  Having multiple such
sets in flight just causes confusion for reviewers.

These are fine, but I'd like them inside that other series I'm requesting
so they are all in one place.

Thanks,

Jonathan

> ---
>  drivers/iio/humidity/hdc2010.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/hdc2010.c b/drivers/iio/humidity/hdc2010.c
> index 894a8b4ab193..1a0f18251381 100644
> --- a/drivers/iio/humidity/hdc2010.c
> +++ b/drivers/iio/humidity/hdc2010.c
> @@ -44,7 +44,6 @@ struct hdc2010_data {
>  	struct i2c_client *client;
>  	struct mutex lock;
>  	u8 measurement_config;
> -	u8 interrupt_config;
>  	u8 drdy_config;
>  };
>
[PATCH] iio: light: apds9306: remove unused nlux_per_count
Posted by Antoniu Miclaus 1 week, 1 day ago
Remove unused nlux_per_count field from apds9306_data
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/light/apds9306.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
index 7e68cca0edfa..ef6429bde193 100644
--- a/drivers/iio/light/apds9306.c
+++ b/drivers/iio/light/apds9306.c
@@ -168,7 +168,6 @@ struct apds9306_regfields {
  *         respectively.
  * @regmap: Regmap structure pointer
  * @rf: Regmap register fields structure
- * @nlux_per_count: Nano lux per ADC count for a particular model
  * @read_data_available: Flag set by IRQ handler for ADC data available
  */
 struct apds9306_data {
@@ -180,7 +179,6 @@ struct apds9306_data {
 	struct regmap *regmap;
 	struct apds9306_regfields rf;
 
-	int nlux_per_count;
 	int read_data_available;
 };
 
-- 
2.43.0
Re: [PATCH] iio: light: apds9306: remove unused nlux_per_count
Posted by Subhajit Ghosh 1 week, 1 day ago
On 30/1/26 04:12, Antoniu Miclaus wrote:
> Remove unused nlux_per_count field from apds9306_data
> struct. The field is declared but never accessed in the
> driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>   drivers/iio/light/apds9306.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 7e68cca0edfa..ef6429bde193 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -168,7 +168,6 @@ struct apds9306_regfields {
>    *         respectively.
>    * @regmap: Regmap structure pointer
>    * @rf: Regmap register fields structure
> - * @nlux_per_count: Nano lux per ADC count for a particular model
>    * @read_data_available: Flag set by IRQ handler for ADC data available
>    */
>   struct apds9306_data {
> @@ -180,7 +179,6 @@ struct apds9306_data {
>   	struct regmap *regmap;
>   	struct apds9306_regfields rf;
>   
> -	int nlux_per_count;
>   	int read_data_available;
>   };
>   
Good find.

Acked-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>

Regards,
Subhajit Ghosh
[PATCH] iio: imu: bmi323: remove unused drdy_trigger_enabled
Posted by Antoniu Miclaus 1 week, 1 day ago
Remove unused drdy_trigger_enabled field from bmi323_data
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/imu/bmi323/bmi323_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
index 6bcb9a436581..f3d499423399 100644
--- a/drivers/iio/imu/bmi323/bmi323_core.c
+++ b/drivers/iio/imu/bmi323/bmi323_core.c
@@ -156,7 +156,6 @@ struct bmi323_data {
 	struct iio_mount_matrix orientation;
 	enum bmi323_irq_pin irq_pin;
 	struct iio_trigger *trig;
-	bool drdy_trigger_enabled;
 	enum bmi323_state state;
 	s64 fifo_tstamp, old_fifo_tstamp;
 	u32 odrns[BMI323_SENSORS_CNT];
-- 
2.43.0
[PATCH] iio: light: gp2ap020a00f: remove unused debug_reg_addr
Posted by Antoniu Miclaus 1 week, 1 day ago
Remove unused debug_reg_addr field from gp2ap020a00f_data
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/light/gp2ap020a00f.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
index c7df4b258e2c..7cdd61db7096 100644
--- a/drivers/iio/light/gp2ap020a00f.c
+++ b/drivers/iio/light/gp2ap020a00f.c
@@ -246,7 +246,6 @@ struct gp2ap020a00f_data {
 	struct iio_trigger *trig;
 	struct regmap *regmap;
 	unsigned int thresh_val[4];
-	u8 debug_reg_addr;
 	struct irq_work work;
 	wait_queue_head_t data_ready_queue;
 };
-- 
2.43.0