drivers/iio/adc/ad4080.c | 1 - 1 file changed, 1 deletion(-)
Remove unused dec_rate field from ad4080_state struct.
The driver reads/writes decimation rate directly from
hardware registers via ad4080_get_dec_rate() and
ad4080_set_dec_rate() functions.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ad4080.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index 7cf3b6ed7940..8bc092969c18 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -185,7 +185,6 @@ struct ad4080_state {
*/
struct mutex lock;
unsigned int num_lanes;
- unsigned int dec_rate;
unsigned long clk_rate;
enum ad4080_filter_type filter_type;
bool lvds_cnv_en;
--
2.43.0On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote: > Remove unused dec_rate field from ad4080_state struct. > The driver reads/writes decimation rate directly from > hardware registers via ad4080_get_dec_rate() and > ad4080_set_dec_rate() functions. Jonathan, the changes look good to me, but the process wise it made badly. Up to you, if you want to apply this, but it might be confusing as this is definitely *not* a series. Also some patches should probably have a v2, I haven't checked that. -- With Best Regards, Andy Shevchenko
On Fri, 30 Jan 2026 07:23:32 +0200 Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote: > > Remove unused dec_rate field from ad4080_state struct. > > The driver reads/writes decimation rate directly from > > hardware registers via ad4080_get_dec_rate() and > > ad4080_set_dec_rate() functions. > > Jonathan, the changes look good to me, but the process wise it made badly. > Up to you, if you want to apply this, but it might be confusing as this is > definitely *not* a series. I'm not planning to queue anything else non urgent for the coming merge window, so we have plenty of time to do a v2 nicely. I'd not be against having this lot of cleanup as a series if it had a clear cover letter stating tooling used to find them etc. Whilst not one driver, and can merge independently that sort of grouping is fine if it provides some value (such as background info). Jonathan > > Also some patches should probably have a v2, I haven't checked that. >
On Fri, 30 Jan 2026 17:38:49 +0000 Jonathan Cameron <jonathan.cameron@huawei.com> wrote: > On Fri, 30 Jan 2026 07:23:32 +0200 > Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > > > On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote: > > > Remove unused dec_rate field from ad4080_state struct. > > > The driver reads/writes decimation rate directly from > > > hardware registers via ad4080_get_dec_rate() and > > > ad4080_set_dec_rate() functions. > > > > Jonathan, the changes look good to me, but the process wise it made badly. > > Up to you, if you want to apply this, but it might be confusing as this is > > definitely *not* a series. > > I'm not planning to queue anything else non urgent for the coming > merge window, so we have plenty of time to do a v2 nicely. > > I'd not be against having this lot of cleanup as a series if it > had a clear cover letter stating tooling used to find them etc. > Whilst not one driver, and can merge independently that sort of grouping > is fine if it provides some value (such as background info). > I looked through the patches and they all seem fine, but lets take the fact I'm not going to be merging anything for a while as an opportunity to clean up presentation of this series. So I'll wait for v2, as a proper series with a cover letter, patch numbering etc. Thanks Jonathan > > Jonathan > > > > > > Also some patches should probably have a v2, I haven't checked that. > > > >
On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote: > Remove unused dec_rate field from ad4080_state struct. > The driver reads/writes decimation rate directly from > hardware registers via ad4080_get_dec_rate() and > ad4080_set_dec_rate() functions. It seems you missed my reply to one of your previous series. Do *not* thread emails which are independent! Really, you should have something internally at the AD to explain the process and the simple things like this. -- With Best Regards, Andy Shevchenko
Remove unused mclk_div field from ad7768_state struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ad7768-1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 980c079ab41a..c461f65f0198 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -290,7 +290,6 @@ struct ad7768_state {
unsigned int vcm_output_sel;
struct clk *mclk;
unsigned int mclk_freq;
- unsigned int mclk_div;
unsigned int oversampling_ratio;
enum ad7768_filter_type filter_type;
unsigned int samp_freq;
--
2.43.0Remove unused int_vref_mv field from ad7793_state struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ad7793.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index ccf18ce48e34..06317f5cb047 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -152,7 +152,6 @@ struct ad7793_chip_info {
struct ad7793_state {
const struct ad7793_chip_info *chip_info;
- u16 int_vref_mv;
u16 mode;
u16 conf;
u32 scale_avail[8][2];
--
2.43.0Remove unused output_mode field from ad9467_state struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ad9467.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
index 9cfe66425d4e..df0c05e7c60f 100644
--- a/drivers/iio/adc/ad9467.c
+++ b/drivers/iio/adc/ad9467.c
@@ -176,7 +176,6 @@ struct ad9467_state {
struct clk *clk;
/* used for debugfs */
struct ad9467_chan_test_mode *chan_test;
- unsigned int output_mode;
unsigned int (*scales)[2];
/*
* Times 2 because we may also invert the signal polarity and run the
--
2.43.0Remove unused requestedmask field from max1363_state struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/max1363.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index 9dd547e62b6c..5e0666343fcb 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -149,7 +149,6 @@ struct max1363_chip_info {
* @configbyte: cache of current device config byte
* @chip_info: chip model specific constants, available modes, etc.
* @current_mode: the scan mode of this chip
- * @requestedmask: a valid requested set of channels
* @lock: lock to ensure state is consistent
* @monitor_on: whether monitor mode is enabled
* @monitor_speed: parameter corresponding to device monitor speed setting
@@ -169,7 +168,6 @@ struct max1363_state {
u8 configbyte;
const struct max1363_chip_info *chip_info;
const struct max1363_mode *current_mode;
- u32 requestedmask;
struct mutex lock;
/* Using monitor modes and buffer at the same time is
--
2.43.0Remove unused min_conversions field from nau7802_state
struct. The field is declared but never accessed in the
driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/nau7802.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/nau7802.c b/drivers/iio/adc/nau7802.c
index 458544cb8ee4..97e92c0427e9 100644
--- a/drivers/iio/adc/nau7802.c
+++ b/drivers/iio/adc/nau7802.c
@@ -55,7 +55,6 @@ struct nau7802_state {
struct mutex data_lock;
u32 vref_mv;
u32 conversion_count;
- u32 min_conversions;
u8 sample_rate;
u32 scale_avail[8];
struct completion value_ok;
--
2.43.0Remove unused enabled field from ads1015_channel_data
struct. The field is declared but never accessed in the
driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/adc/ti-ads1015.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index f2a93c63ca14..c7ffe47449e2 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -231,7 +231,6 @@ static const struct iio_event_spec ads1015_events[] = {
}
struct ads1015_channel_data {
- bool enabled;
unsigned int pga;
unsigned int data_rate;
};
--
2.43.0Remove unused int_tone field from axi_dac_state struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/dac/adi-axi-dac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
index 9cc895bbe51a..1ca725c5dedc 100644
--- a/drivers/iio/dac/adi-axi-dac.c
+++ b/drivers/iio/dac/adi-axi-dac.c
@@ -114,7 +114,6 @@ struct axi_dac_state {
const struct axi_dac_info *info;
u64 dac_clk;
u32 reg_config;
- bool int_tone;
int dac_clk_rate;
};
--
2.43.0Remove unused id field from dac5571_data struct.
The field is declared but never accessed in the driver.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/dac/ti-dac5571.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index bdc3f94aef98..455d61fc3f13 100644
--- a/drivers/iio/dac/ti-dac5571.c
+++ b/drivers/iio/dac/ti-dac5571.c
@@ -45,7 +45,6 @@ static const struct dac5571_spec dac5571_spec[] = {
struct dac5571_data {
struct i2c_client *client;
- int id;
struct mutex lock;
struct regulator *vref;
u16 val[4];
--
2.43.0© 2016 - 2026 Red Hat, Inc.