[PATCH] gpiolib: acpi: Fix gpio count with string references

Alban Bedel posted 1 patch 1 week, 2 days ago
drivers/gpio/gpiolib-acpi-core.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] gpiolib: acpi: Fix gpio count with string references
Posted by Alban Bedel 1 week, 2 days ago
Since commit 9880702d123f2 ("ACPI: property: Support using strings in
reference properties") it is possible to use strings instead of local
references. This work fine with single GPIO but not with arrays as
acpi_gpio_package_count() didn't handle this case. Update it to handle
strings like local references to cover this case as well.

Signed-off-by: Alban Bedel <alban.bedel@lht.dlh.de>
---
 drivers/gpio/gpiolib-acpi-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c
index 83dd227dbbecc..effc5ab6864b8 100644
--- a/drivers/gpio/gpiolib-acpi-core.c
+++ b/drivers/gpio/gpiolib-acpi-core.c
@@ -1346,6 +1346,7 @@ static int acpi_gpio_package_count(const union acpi_object *obj)
 	while (element < end) {
 		switch (element->type) {
 		case ACPI_TYPE_LOCAL_REFERENCE:
+		case ACPI_TYPE_STRING:
 			element += 3;
 			fallthrough;
 		case ACPI_TYPE_INTEGER:
-- 
2.39.5
Re: [PATCH] gpiolib: acpi: Fix gpio count with string references
Posted by Bartosz Golaszewski 4 days, 4 hours ago
On Thu, 29 Jan 2026 15:59:44 +0100, Alban Bedel wrote:
> Since commit 9880702d123f2 ("ACPI: property: Support using strings in
> reference properties") it is possible to use strings instead of local
> references. This work fine with single GPIO but not with arrays as
> acpi_gpio_package_count() didn't handle this case. Update it to handle
> strings like local references to cover this case as well.
> 
> 
> [...]

Applied, thanks!

[1/1] gpiolib: acpi: Fix gpio count with string references
      https://git.kernel.org/brgl/c/c62e0658d458d8f100445445c3ddb106f3824a45

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH] gpiolib: acpi: Fix gpio count with string references
Posted by Mika Westerberg 1 week, 2 days ago
On Thu, Jan 29, 2026 at 03:59:44PM +0100, Alban Bedel wrote:
> Since commit 9880702d123f2 ("ACPI: property: Support using strings in
> reference properties") it is possible to use strings instead of local
> references. This work fine with single GPIO but not with arrays as
> acpi_gpio_package_count() didn't handle this case. Update it to handle
> strings like local references to cover this case as well.
> 
> Signed-off-by: Alban Bedel <alban.bedel@lht.dlh.de>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>