mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

[PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

Posted by Andre Korol 1 week, 2 days ago

dma_alloc_coherent() returns zeroed memory, so the memset() immediately
after allocation is redundant.

Signed-off-by: Andre Korol <andre.korol.dev@gmail.com>
---
 drivers/mmc/host/loongson2-mmc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
index da3daab5f3d6..026cbd80f114 100644
--- a/drivers/mmc/host/loongson2-mmc.c
+++ b/drivers/mmc/host/loongson2-mmc.c
@@ -846,7 +846,6 @@ static int ls2k2000_mmc_set_internal_dma(struct loongson2_mmc_host *host,
 	if (!host->sg_cpu)
 		return -ENOMEM;
 
-	memset(host->sg_cpu, 0, PAGE_SIZE);
 	return 0;
 }
 
-- 
2.51.0

Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

Posted by Ulf Hansson 1 week, 1 day ago

On Thu, 29 Jan 2026 at 04:59, Andre Korol <andre.korol.dev@gmail.com> wrote:
>
> dma_alloc_coherent() returns zeroed memory, so the memset() immediately
> after allocation is redundant.
>
> Signed-off-by: Andre Korol <andre.korol.dev@gmail.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/loongson2-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index da3daab5f3d6..026cbd80f114 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -846,7 +846,6 @@ static int ls2k2000_mmc_set_internal_dma(struct loongson2_mmc_host *host,
>         if (!host->sg_cpu)
>                 return -ENOMEM;
>
> -       memset(host->sg_cpu, 0, PAGE_SIZE);
>         return 0;
>  }
>
> --
> 2.51.0
>

Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

Posted by Andre Korol 1 week, 1 day ago

Thanks! Appreciate the quick review.

Andre

Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

Posted by Binbin Zhou 1 week, 2 days ago

On 2026/1/29 11:59, Andre Korol wrote:
> dma_alloc_coherent() returns zeroed memory, so the memset() immediately
> after allocation is redundant.
>
> Signed-off-by: Andre Korol <andre.korol.dev@gmail.com>
LGTM.
Reviewed-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>   drivers/mmc/host/loongson2-mmc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index da3daab5f3d6..026cbd80f114 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -846,7 +846,6 @@ static int ls2k2000_mmc_set_internal_dma(struct loongson2_mmc_host *host,
>   	if (!host->sg_cpu)
>   		return -ENOMEM;
>   
> -	memset(host->sg_cpu, 0, PAGE_SIZE);
>   	return 0;
>   }
>