From: Hui Zhu <zhuhui@kylinos.cn>

Add missing newline character at the end of pr_warn error message
in bpf_memcontrol_init() function. Kernel log messages should end
with a newline character for proper formatting in kernel logs.

This issue was pointed out in
https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210

Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
---
 mm/bpf_memcontrol.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/bpf_memcontrol.c b/mm/bpf_memcontrol.c
index 716df49d7647..20999a29820b 100644
--- a/mm/bpf_memcontrol.c
+++ b/mm/bpf_memcontrol.c
@@ -186,7 +186,8 @@ static int __init bpf_memcontrol_init(void)
 	err = register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC,
 					&bpf_memcontrol_kfunc_set);
 	if (err)
-		pr_warn("error while registering bpf memcontrol kfuncs: %d", err);
+		pr_warn("error while registering bpf memcontrol kfuncs: %d\n",
+			err);
 
 	return err;
 }
-- 
2.43.0

Hui Zhu <hui.zhu@linux.dev> writes:

> From: Hui Zhu <zhuhui@kylinos.cn>
>
> Add missing newline character at the end of pr_warn error message
> in bpf_memcontrol_init() function. Kernel log messages should end
> with a newline character for proper formatting in kernel logs.
>
> This issue was pointed out in
> https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210
>
> Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>

On Wed, Jan 28, 2026 at 7:53 PM Hui Zhu <hui.zhu@linux.dev> wrote:
>
> From: Hui Zhu <zhuhui@kylinos.cn>
>
> Add missing newline character at the end of pr_warn error message
> in bpf_memcontrol_init() function. Kernel log messages should end
> with a newline character for proper formatting in kernel logs.
>
> This issue was pointed out in
> https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210

Just spell it out that it was found by copilot.

pw-bot: cr