On Thu, 29 Jan 2026 21:43:15 +0000
Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@kernel.org> wrote:
> From: Abdurrahman Hussain <abdurrahman@nexthop.ai>
>
> The devm_request_threaded_irq() already prints an error message. Remove
> the duplicate.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
> ---
> drivers/i2c/busses/i2c-xiic.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index a480cbb86d93..ca5685660e45 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1493,11 +1493,8 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> xiic_process, IRQF_ONESHOT,
> pdev->name, i2c);
> -
> - if (ret < 0) {
> - dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n");
> + if (ret)
> return ret;
Ah ok. I'd be tempted to drop that before the previous patch then we don't
have the dance that I guess was there to reduce churn.
> - }
>
> i2c->singlemaster =
> of_property_read_bool(pdev->dev.of_node, "single-master");
>