This series fixes memory leaks in the initialization paths of the
NIC devices.
Patch 1 moves the initialization of oct->props[i].netdev before queue
setup calls. This ensures that if queue setup fails, the cleanup function
can find and free the allocated netdev. It also initializes lio->oct_dev
early to prevent a crash in the cleanup path.
Patch 2 fixes an off-by-one error in the PF cleanup loop. It ensures
the current device index is cleaned up and correctly handles the
post-loop devlink_alloc failure case.
Patch 3 fixes the same off-by-one error in the VF cleanup loop.
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Changes in v4:
- Move the netdev initialization fix to patch 1, as it is a
prerequisite for the cleanup fixes.
- Change the cleanup loop to 'do { ... } while (i >= 0)' in PF and VF
setup_nic_devices(), as the caller guarantees octeon_dev->ifcount > 0,
ensuring i is never decremented below 0.
Changes in v3:
- Split the off-by-one fix into separate patches for PF and VF.
- Patch 2: Decrement i in the devlink_alloc error path before jumping
to cleanup to avoid accessing an invalid index.
- Patch 1: Initialize lio->oct_dev alongside props->netdev to prevent
NULL pointer dereference in cleanup_rx_oom_poll_fn().
Changes in v2:
- Add patch 2 to fix an off-by-one error in the error handling loop logic.
Zilin Guan (3):
net: liquidio: Initialize netdev pointer before queue setup
net: liquidio: Fix off-by-one error in PF setup_nic_devices() cleanup
net: liquidio: Fix off-by-one error in VF setup_nic_devices() cleanup
.../net/ethernet/cavium/liquidio/lio_main.c | 39 ++++++++++---------
.../ethernet/cavium/liquidio/lio_vf_main.c | 4 +-
2 files changed, 22 insertions(+), 21 deletions(-)
--
2.34.1