[PATCH v3 0/4] staging: rtl8723bs: remove memory allocation wrappers

Minu Jin posted 4 patches 1 week, 2 days ago
drivers/staging/rtl8723bs/core/rtw_ap.c       | 12 +--
drivers/staging/rtl8723bs/core/rtw_cmd.c      | 80 +++++++++----------
drivers/staging/rtl8723bs/core/rtw_mlme.c     | 12 +--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 40 +++++-----
drivers/staging/rtl8723bs/core/rtw_recv.c     |  4 +-
drivers/staging/rtl8723bs/core/rtw_security.c |  2 +-
.../staging/rtl8723bs/core/rtw_wlan_util.c    |  2 +-
drivers/staging/rtl8723bs/core/rtw_xmit.c     |  6 +-
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c |  4 +-
.../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  8 +-
drivers/staging/rtl8723bs/hal/sdio_ops.c      | 18 ++---
.../staging/rtl8723bs/include/osdep_service.h | 11 ---
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 18 ++---
drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  2 +-
.../staging/rtl8723bs/os_dep/osdep_service.c  | 29 +------
drivers/staging/rtl8723bs/os_dep/xmit_linux.c |  4 +-
16 files changed, 108 insertions(+), 144 deletions(-)
[PATCH v3 0/4] staging: rtl8723bs: remove memory allocation wrappers
Posted by Minu Jin 1 week, 2 days ago
This series replaces wrapper functions in the rtl8723bs driver
with standard kernel APIs (kmalloc, kzalloc, and skb functions).

The original wrappers relied on in_interrupt() check to decide between
GFP_ATOMIC and GFP_KERNEL.
So, I have analyzed each call site to apply the appropriate GFP flags
based on the execution context.

Specifically, I used:
- GFP_ATOMIC: For data paths, tasklets, timer handlers, spinlock, and
  functions called within atomic contexts.

- GFP_KERNEL: For driver initialization (init/probe), configuration
  setups, and process contexts where sleeping is allowed

I would appreciate a review to ensure that these flags were correctly
identified for each context.

Changes in v3:
- I have analyzed each call site to apply the appropriate GFP flags
  based on the execution context.

- Improved the logical separation of patches to maintain git bisect

- Removed redundant definitions and unused macros (e.g., rtw_skb_alloc_f)
  in the final cleanup patch.

Minu Jin (4):
  staging: rtl8723bs: Replace _rtw_malloc with kmalloc
  staging: rtl8723bs: replace rtw_zmalloc with kzalloc
  staging: rtl8723bs: replace skb allocation wrappers and fix build
  staging: rtl8723bs: remove unused allocation wrapper functions

 drivers/staging/rtl8723bs/core/rtw_ap.c       | 12 +--
 drivers/staging/rtl8723bs/core/rtw_cmd.c      | 80 +++++++++----------
 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 12 +--
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 40 +++++-----
 drivers/staging/rtl8723bs/core/rtw_recv.c     |  4 +-
 drivers/staging/rtl8723bs/core/rtw_security.c |  2 +-
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |  2 +-
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |  6 +-
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |  4 +-
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  8 +-
 drivers/staging/rtl8723bs/hal/sdio_ops.c      | 18 ++---
 .../staging/rtl8723bs/include/osdep_service.h | 11 ---
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 18 ++---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  2 +-
 .../staging/rtl8723bs/os_dep/osdep_service.c  | 29 +------
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c |  4 +-
 16 files changed, 108 insertions(+), 144 deletions(-)

-- 
2.43.0