1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add DSI Port B input support for LT9611 HDMI bridge
  4. View patch

[PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input

Hongyang Zhao posted 3 patches 1 week, 2 days ago
[PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Hongyang Zhao 1 week, 2 days ago 
The LT9611 has two DSI input ports (Port A and Port B). Update the
binding to clearly document the port mapping and allow using Port B
alone when DSI is physically connected to Port B only.

Changes:
- Clarify port@0 corresponds to DSI Port A input
- Clarify port@1 corresponds to DSI Port B input
- Change port requirement from mandatory port@0 to anyOf port@0/port@1,
  allowing either port to be used independently

Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
Reviewed-by: Roger Shimizu <rosh@debian.org>
---
 .../bindings/display/bridge/lontium,lt9611.yaml           | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
index 655db8cfdc25..429a06057ae8 100644
--- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
@@ -44,21 +44,28 @@ properties:
       port@0:
         $ref: /schemas/graph.yaml#/properties/port
         description:
-          Primary MIPI port-1 for MIPI input
+          DSI Port A input. directly drives the display, or works in
+          combination with Port B for higher resolution displays.
 
       port@1:
         $ref: /schemas/graph.yaml#/properties/port
         description:
-          Additional MIPI port-2 for MIPI input, used in combination
-          with primary MIPI port-1 to drive higher resolution displays
+          DSI Port B input. Can be used alone if DSI is physically
+          connected to Port B, or in combination with Port A for higher
+          resolution displays.
 
       port@2:
         $ref: /schemas/graph.yaml#/properties/port
         description:
           HDMI port for HDMI output
 
+    anyOf:
+      - required:
+          - port@0
+      - required:
+          - port@1
+
     required:
-      - port@0
       - port@2
 
 required:

-- 
2.43.0
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Krzysztof Kozlowski 1 day, 16 hours ago 
On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
> The LT9611 has two DSI input ports (Port A and Port B). Update the
> binding to clearly document the port mapping and allow using Port B
> alone when DSI is physically connected to Port B only.
> 
> Changes:
> - Clarify port@0 corresponds to DSI Port A input
> - Clarify port@1 corresponds to DSI Port B input
> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
>   allowing either port to be used independently
> 
> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> Reviewed-by: Roger Shimizu <rosh@debian.org>

Where did this review happen? V1 had this tag, but the patch was
completely different, which means you were supposed to drop the tag.
Please perform review in public.


Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Roger Shimizu 1 day, 9 hours ago 
On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
> > The LT9611 has two DSI input ports (Port A and Port B). Update the
> > binding to clearly document the port mapping and allow using Port B
> > alone when DSI is physically connected to Port B only.
> >
> > Changes:
> > - Clarify port@0 corresponds to DSI Port A input
> > - Clarify port@1 corresponds to DSI Port B input
> > - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
> >   allowing either port to be used independently
> >
> > Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> > Reviewed-by: Roger Shimizu <rosh@debian.org>
>
> Where did this review happen? V1 had this tag, but the patch was
> completely different, which means you were supposed to drop the tag.
> Please perform review in public.

FYI. v2 was updated per review feedback, which is public:
https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/

Maybe it's better to add this info to v2 cover letter / trailer for
easier reading.

-Roger
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Krzysztof Kozlowski 22 hours ago 
On 05/02/2026 21:31, Roger Shimizu wrote:
> On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
>>> The LT9611 has two DSI input ports (Port A and Port B). Update the
>>> binding to clearly document the port mapping and allow using Port B
>>> alone when DSI is physically connected to Port B only.
>>>
>>> Changes:
>>> - Clarify port@0 corresponds to DSI Port A input
>>> - Clarify port@1 corresponds to DSI Port B input
>>> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
>>>   allowing either port to be used independently
>>>
>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
>>
>> Where did this review happen? V1 had this tag, but the patch was
>> completely different, which means you were supposed to drop the tag.
>> Please perform review in public.
> 
> FYI. v2 was updated per review feedback, which is public:
> https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/

Link above is not from Roger, so again - where did the review leading to
above tag happen?

Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Roger Shimizu 19 hours ago 
On Thu, Feb 5, 2026 at 11:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 05/02/2026 21:31, Roger Shimizu wrote:
> > On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
> >>> The LT9611 has two DSI input ports (Port A and Port B). Update the
> >>> binding to clearly document the port mapping and allow using Port B
> >>> alone when DSI is physically connected to Port B only.
> >>>
> >>> Changes:
> >>> - Clarify port@0 corresponds to DSI Port A input
> >>> - Clarify port@1 corresponds to DSI Port B input
> >>> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
> >>>   allowing either port to be used independently
> >>>
> >>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> >>> Reviewed-by: Roger Shimizu <rosh@debian.org>
> >>
> >> Where did this review happen? V1 had this tag, but the patch was
> >> completely different, which means you were supposed to drop the tag.
> >> Please perform review in public.
> >
> > FYI. v2 was updated per review feedback, which is public:
> > https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/
>
> Link above is not from Roger, so again - where did the review leading to
> above tag happen?

Per feedback of v1, v2 was quite different than v1.
For v2, it's close to initial review, because it looks like a new patch.
Of course, if you don't like this way, we can drop this next time.

-Roger
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Krzysztof Kozlowski 18 hours ago 
On 06/02/2026 10:49, Roger Shimizu wrote:
> On Thu, Feb 5, 2026 at 11:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 05/02/2026 21:31, Roger Shimizu wrote:
>>> On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
>>>>> The LT9611 has two DSI input ports (Port A and Port B). Update the
>>>>> binding to clearly document the port mapping and allow using Port B
>>>>> alone when DSI is physically connected to Port B only.
>>>>>
>>>>> Changes:
>>>>> - Clarify port@0 corresponds to DSI Port A input
>>>>> - Clarify port@1 corresponds to DSI Port B input
>>>>> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
>>>>>   allowing either port to be used independently
>>>>>
>>>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
>>>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
>>>>
>>>> Where did this review happen? V1 had this tag, but the patch was
>>>> completely different, which means you were supposed to drop the tag.
>>>> Please perform review in public.
>>>
>>> FYI. v2 was updated per review feedback, which is public:
>>> https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/
>>
>> Link above is not from Roger, so again - where did the review leading to
>> above tag happen?
> 
> Per feedback of v1, v2 was quite different than v1.
> For v2, it's close to initial review, because it looks like a new patch.

Where was the review of v2 given?

The patch is entirely different. I already said it. I also said what is
expected in such case. It is also documented:

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577



Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Roger Shimizu 26 minutes ago 
On Fri, Feb 6, 2026 at 2:56 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 06/02/2026 10:49, Roger Shimizu wrote:
> > On Thu, Feb 5, 2026 at 11:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 05/02/2026 21:31, Roger Shimizu wrote:
> >>> On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>>
> >>>> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
> >>>>> The LT9611 has two DSI input ports (Port A and Port B). Update the
> >>>>> binding to clearly document the port mapping and allow using Port B
> >>>>> alone when DSI is physically connected to Port B only.
> >>>>>
> >>>>> Changes:
> >>>>> - Clarify port@0 corresponds to DSI Port A input
> >>>>> - Clarify port@1 corresponds to DSI Port B input
> >>>>> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
> >>>>>   allowing either port to be used independently
> >>>>>
> >>>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> >>>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
> >>>>
> >>>> Where did this review happen? V1 had this tag, but the patch was
> >>>> completely different, which means you were supposed to drop the tag.
> >>>> Please perform review in public.
> >>>
> >>> FYI. v2 was updated per review feedback, which is public:
> >>> https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/
> >>
> >> Link above is not from Roger, so again - where did the review leading to
> >> above tag happen?
> >
> > Per feedback of v1, v2 was quite different than v1.
> > For v2, it's close to initial review, because it looks like a new patch.
>
> Where was the review of v2 given?
>
> The patch is entirely different. I already said it. I also said what is
> expected in such case. It is also documented:
>
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

Thanks for the guide!
Yes, v2 was reviewed in private. I'll inform Hongyang to remove the
tag when he sends the next series.

-Roger
Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input
Posted by Neil Armstrong 1 week, 1 day ago 
On 1/28/26 12:15, Hongyang Zhao wrote:
> The LT9611 has two DSI input ports (Port A and Port B). Update the
> binding to clearly document the port mapping and allow using Port B
> alone when DSI is physically connected to Port B only.
> 
> Changes:
> - Clarify port@0 corresponds to DSI Port A input
> - Clarify port@1 corresponds to DSI Port B input
> - Change port requirement from mandatory port@0 to anyOf port@0/port@1,
>    allowing either port to be used independently
> 
> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> Reviewed-by: Roger Shimizu <rosh@debian.org>
> ---
>   .../bindings/display/bridge/lontium,lt9611.yaml           | 15 +++++++++++----
>   1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> index 655db8cfdc25..429a06057ae8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
> @@ -44,21 +44,28 @@ properties:
>         port@0:
>           $ref: /schemas/graph.yaml#/properties/port
>           description:
> -          Primary MIPI port-1 for MIPI input
> +          DSI Port A input. directly drives the display, or works in
> +          combination with Port B for higher resolution displays.
>   
>         port@1:
>           $ref: /schemas/graph.yaml#/properties/port
>           description:
> -          Additional MIPI port-2 for MIPI input, used in combination
> -          with primary MIPI port-1 to drive higher resolution displays
> +          DSI Port B input. Can be used alone if DSI is physically
> +          connected to Port B, or in combination with Port A for higher
> +          resolution displays.
>   
>         port@2:
>           $ref: /schemas/graph.yaml#/properties/port
>           description:
>             HDMI port for HDMI output
>   
> +    anyOf:
> +      - required:
> +          - port@0
> +      - required:
> +          - port@1
> +
>       required:
> -      - port@0
>         - port@2
>   
>   required:
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.