[PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference

Josua Mayer posted 8 patches 1 week, 4 days ago
[PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference
Posted by Josua Mayer 1 week, 4 days ago
imx8mp.dtsi includes a default port@1 node with an empty placeholder
endpoint intended for linking to a dsi bridge or panel.

HummingBoard Pulse mini-hdmi dtsi added and linked hdmi bridge to yet
another endpoint.

This duplicate endpoint can cause dsi_attach to fail.

Remove the duplicate node and link to the one defined in soc dtsi.
Further remove the unnecessary attach-bridge property.

Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 .../dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi    | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
index 46916ddc0533..0e5f4607c7c1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
@@ -41,7 +41,7 @@ port@0 {
 				reg = <0>;
 
 				adv7535_from_dsim: endpoint {
-					remote-endpoint = <&dsim_to_adv7535>;
+					remote-endpoint = <&mipi_dsi_out>;
 				};
 			};
 
@@ -71,11 +71,8 @@ &lcdif1 {
 &mipi_dsi {
 	samsung,esc-clock-frequency = <10000000>;
 	status = "okay";
+};
 
-	port@1 {
-		dsim_to_adv7535: endpoint {
-			remote-endpoint = <&adv7535_from_dsim>;
-			attach-bridge;
-		};
-	};
+&mipi_dsi_out {
+	remote-endpoint = <&adv7535_from_dsim>;
 };

-- 
2.43.0
Re: [PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference
Posted by Frank Li 1 week, 4 days ago
On Wed, Jan 28, 2026 at 06:21:27PM +0200, Josua Mayer wrote:
> imx8mp.dtsi includes a default port@1 node with an empty placeholder
> endpoint intended for linking to a dsi bridge or panel.
>
> HummingBoard Pulse mini-hdmi dtsi added and linked hdmi bridge to yet
> another endpoint.
>
> This duplicate endpoint can cause dsi_attach to fail.

Can you add descript about why duplicate endpoint cause fail?

Frank
>
> Remove the duplicate node and link to the one defined in soc dtsi.
> Further remove the unnecessary attach-bridge property.
>
> Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  .../dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi    | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
> index 46916ddc0533..0e5f4607c7c1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
> @@ -41,7 +41,7 @@ port@0 {
>  				reg = <0>;
>
>  				adv7535_from_dsim: endpoint {
> -					remote-endpoint = <&dsim_to_adv7535>;
> +					remote-endpoint = <&mipi_dsi_out>;
>  				};
>  			};
>
> @@ -71,11 +71,8 @@ &lcdif1 {
>  &mipi_dsi {
>  	samsung,esc-clock-frequency = <10000000>;
>  	status = "okay";
> +};
>
> -	port@1 {
> -		dsim_to_adv7535: endpoint {
> -			remote-endpoint = <&adv7535_from_dsim>;
> -			attach-bridge;
> -		};
> -	};
> +&mipi_dsi_out {
> +	remote-endpoint = <&adv7535_from_dsim>;
>  };
>
> --
> 2.43.0
>
>
Re: [PATCH v8 3/8] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference
Posted by Josua Mayer 1 week, 3 days ago
On 28/01/2026 19:13, Frank Li wrote:
> On Wed, Jan 28, 2026 at 06:21:27PM +0200, Josua Mayer wrote:
>> imx8mp.dtsi includes a default port@1 node with an empty placeholder
>> endpoint intended for linking to a dsi bridge or panel.
>>
>> HummingBoard Pulse mini-hdmi dtsi added and linked hdmi bridge to yet
>> another endpoint.
>>
>> This duplicate endpoint can cause dsi_attach to fail.
> Can you add descript about why duplicate endpoint cause fail?

I didn't debug this in detail. Basic observation was as follows:

I was under the impression that two endpoint nodes ended up in the final 
dtb,
with different phandles which made the remote-endpoint references 
inconsistent.

I'd prefer not to explain in detail what happened, and focus on removing
inconsistency from the dts.

>
> Frank
>> Remove the duplicate node and link to the one defined in soc dtsi.
>> Further remove the unnecessary attach-bridge property.
>>
>> Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>   .../dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi    | 11 ++++-------
>>   1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> index 46916ddc0533..0e5f4607c7c1 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-mini-hdmi.dtsi
>> @@ -41,7 +41,7 @@ port@0 {
>>   				reg = <0>;
>>
>>   				adv7535_from_dsim: endpoint {
>> -					remote-endpoint = <&dsim_to_adv7535>;
>> +					remote-endpoint = <&mipi_dsi_out>;
>>   				};
>>   			};
>>
>> @@ -71,11 +71,8 @@ &lcdif1 {
>>   &mipi_dsi {
>>   	samsung,esc-clock-frequency = <10000000>;
>>   	status = "okay";
>> +};
>>
>> -	port@1 {
>> -		dsim_to_adv7535: endpoint {
>> -			remote-endpoint = <&adv7535_from_dsim>;
>> -			attach-bridge;
>> -		};
>> -	};
>> +&mipi_dsi_out {
>> +	remote-endpoint = <&adv7535_from_dsim>;
>>   };
>>
>> --
>> 2.43.0
>>
>>