[PATCH v8 2/8] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity

Josua Mayer posted 8 patches 1 week, 5 days ago
[PATCH v8 2/8] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity
Posted by Josua Mayer 1 week, 5 days ago
Fix the polarity in vmmc regulator node for the gpio from active-high to
active-low. This is a cosmetic change as regulator default to active-low
unless property enable-active-high was also specified - ignoring the
flag on gpio handle.

Fixes: a009c0c66ecb ("arm64: dts: add description for solidrun imx8mp som and cubox-m")
Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts                    | 2 +-
 arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts b/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
index 8290f187b79f..7bc213499f09 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
@@ -68,7 +68,7 @@ vmmc: regulator-mmc {
 		regulator-name = "vmmc";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_LOW>;
 		startup-delay-us = <250>;
 	};
 };
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
index 825ad6a2ba14..5b8c8489713c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
@@ -73,7 +73,7 @@ vmmc: regulator-mmc {
 		regulator-name = "vmmc";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_LOW>;
 		startup-delay-us = <250>;
 	};
 

-- 
2.43.0
Re: [PATCH v8 2/8] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity
Posted by Frank Li 1 week, 5 days ago
On Wed, Jan 28, 2026 at 06:21:26PM +0200, Josua Mayer wrote:
> Fix the polarity in vmmc regulator node for the gpio from active-high to
> active-low. This is a cosmetic change as regulator default to active-low
> unless property enable-active-high was also specified - ignoring the
> flag on gpio handle.
>
> Fixes: a009c0c66ecb ("arm64: dts: add description for solidrun imx8mp som and cubox-m")
> Fixes: 2a222aa2bee9 ("arm64: dts: add description for solidrun imx8mp hummingboard variants")
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>  arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts                    | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts b/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
> index 8290f187b79f..7bc213499f09 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-cubox-m.dts
> @@ -68,7 +68,7 @@ vmmc: regulator-mmc {
>  		regulator-name = "vmmc";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> -		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio2 19 GPIO_ACTIVE_LOW>;
>  		startup-delay-us = <250>;
>  	};
>  };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
> index 825ad6a2ba14..5b8c8489713c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-hummingboard-pulse-common.dtsi
> @@ -73,7 +73,7 @@ vmmc: regulator-mmc {
>  		regulator-name = "vmmc";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> -		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio2 19 GPIO_ACTIVE_LOW>;
>  		startup-delay-us = <250>;
>  	};
>
>
> --
> 2.43.0
>
>