[v2] move CAN skb headroom content to skb extensions

[PATCH can-next v2 0/6] move CAN skb headroom content to skb extensions

Marc Kleine-Budde posted 6 patches 1 week, 2 days ago

Diff against v5 v6 v7 v8
Download series mbox

There is a newer version of this series

MAINTAINERS               |   1 +
drivers/net/can/dev/skb.c | 121 +++++++++++++++++++++++++++++-----------------
include/linux/can/core.h  |   1 +
include/linux/can/skb.h   |  32 ++----------
include/linux/skbuff.h    |   3 ++
include/net/can.h         |  28 +++++++++++
net/can/Kconfig           |   1 +
net/can/af_can.c          |  23 ++++++---
net/can/bcm.c             |  26 +++++++---
net/can/gw.c              |  38 ++++++++-------
net/can/isotp.c           |  45 +++++++++++------
net/can/j1939/socket.c    |  15 ++++--
net/can/j1939/transport.c |  28 +++++++----
net/can/raw.c             |  21 +++++---
net/core/skbuff.c         |   4 ++
15 files changed, 247 insertions(+), 140 deletions(-)

Expand all Fold all

[PATCH can-next v2 0/6] move CAN skb headroom content to skb extensions

Posted by Marc Kleine-Budde 1 week, 2 days ago

CAN bus related skbuffs (ETH_P_CAN/ETH_P_CANFD/ETH_P_CANXL) simply contain
CAN frame structs for CAN CC/FD/XL of skb->len length at skb->data. Those
CAN skbs do not have network/mac/transport headers nor other such
references for encapsulated protocols like ethernet/IP protocols.

To store data for CAN specific use-cases all CAN bus related skbuffs are
created with a 16 byte private skb headroom (struct can_skb_priv). Using
the skb headroom and accessing skb->head for this private data led to
several problems in the past likely due to "The struct can_skb_priv
business is highly unconventional for the networking stack." [1]

This patch set aims to remove the unconventional skb headroom usage for CAN
bus related skbuffs and use the common skb extensions instead.

[1] https://lore.kernel.org/linux-can/20260104074222.29e660ac@kernel.org/

---
Changes in v2:
- Patch#1: use u32 instead of __u32 for "struct uniqframe::hash"
- Patch#3: use u{8,16} instead of __u{8,16} for "struct can_skb_ext"
- Patch#6: add missing patch
- Link to v1: https://patch.msgid.link/20260125201601.5018-1-socketcan@hartkopp.net

---
Oliver Hartkopp (6):
      can: use skb hash instead of private variable in headroom
      can: add CAN skb extension infrastructure
      can: move ifindex to CAN skb extensions
      can: move frame_len to CAN skb extensions
      can: remove private CAN skb headroom infrastructure
      can: gw: use can_gw_hops instead of sk_buff::csum_start

 MAINTAINERS               |   1 +
 drivers/net/can/dev/skb.c | 121 +++++++++++++++++++++++++++++-----------------
 include/linux/can/core.h  |   1 +
 include/linux/can/skb.h   |  32 ++----------
 include/linux/skbuff.h    |   3 ++
 include/net/can.h         |  28 +++++++++++
 net/can/Kconfig           |   1 +
 net/can/af_can.c          |  23 ++++++---
 net/can/bcm.c             |  26 +++++++---
 net/can/gw.c              |  38 ++++++++-------
 net/can/isotp.c           |  45 +++++++++++------
 net/can/j1939/socket.c    |  15 ++++--
 net/can/j1939/transport.c |  28 +++++++----
 net/can/raw.c             |  21 +++++---
 net/core/skbuff.c         |   4 ++
 15 files changed, 247 insertions(+), 140 deletions(-)
---
base-commit: 239f09e258b906deced5c2a7c1ac8aed301b558b
change-id: 20260128-can-skb-ext-17a4f132ce97

Best regards,
--  
Marc Kleine-Budde <mkl@pengutronix.de>