1. Patchew
  2. linux
  3. View series

[PATCH] rust_binder: return p from rust_binder_transaction_target_node()

Alice Ryhl posted 1 patch 1 week, 2 days ago 
drivers/android/binder/rust_binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Alice Ryhl 1 week, 2 days ago 
Somehow this got changed to NULL when I ported this to upstream it. No
idea how that happened.

Reported-by: Carlos Llamas <cmllamas@google.com>
Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Commit not yet upstream, so cc stable not required.
---
 drivers/android/binder/rust_binder.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
--- a/drivers/android/binder/rust_binder.h
+++ b/drivers/android/binder/rust_binder.h
@@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
 
 	if (p)
 		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
-	return NULL;
+	return p;
 }
 
 static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)

---
base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>
Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Greg Kroah-Hartman 3 days, 17 hours ago 
On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> Somehow this got changed to NULL when I ported this to upstream it. No
> idea how that happened.
> 
> Reported-by: Carlos Llamas <cmllamas@google.com>
> Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Commit not yet upstream, so cc stable not required.
> ---
>  drivers/android/binder/rust_binder.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> --- a/drivers/android/binder/rust_binder.h
> +++ b/drivers/android/binder/rust_binder.h
> @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
>  
>  	if (p)
>  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> -	return NULL;
> +	return p;
>  }
>  
>  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> 
> ---
> base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> change-id: 20260128-binder-fix-target-node-null-02fcb98f0200

Does not apply at all, what tree was this made against?

thanks,

greg k-h
Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Alice Ryhl 3 days, 17 hours ago 
On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> > 
> > Reported-by: Carlos Llamas <cmllamas@google.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> >  drivers/android/binder/rust_binder.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >  
> >  	if (p)
> >  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > -	return NULL;
> > +	return p;
> >  }
> >  
> >  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> > 
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> 
> Does not apply at all, what tree was this made against?

This applies on char-misc-next. It's a fix for commit c1ea31205edf,
which currently only exists in that branch.

Alice
Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Greg Kroah-Hartman 3 days, 17 hours ago 
On Tue, Feb 03, 2026 at 11:56:31AM +0000, Alice Ryhl wrote:
> On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > > Somehow this got changed to NULL when I ported this to upstream it. No
> > > idea how that happened.
> > > 
> > > Reported-by: Carlos Llamas <cmllamas@google.com>
> > > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > > ---
> > > Commit not yet upstream, so cc stable not required.
> > > ---
> > >  drivers/android/binder/rust_binder.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > > --- a/drivers/android/binder/rust_binder.h
> > > +++ b/drivers/android/binder/rust_binder.h
> > > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> > >  
> > >  	if (p)
> > >  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > > -	return NULL;
> > > +	return p;
> > >  }
> > >  
> > >  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> > > 
> > > ---
> > > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> > 
> > Does not apply at all, what tree was this made against?
> 
> This applies on char-misc-next. It's a fix for commit c1ea31205edf,
> which currently only exists in that branch.

Our emails crossed, my fault, I was looking at the wrong tree.  Now
applied, thanks!

greg k-h
Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Greg Kroah-Hartman 3 days, 17 hours ago 
On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> > 
> > Reported-by: Carlos Llamas <cmllamas@google.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> >  drivers/android/binder/rust_binder.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >  
> >  	if (p)
> >  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > -	return NULL;
> > +	return p;
> >  }
> >  
> >  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> > 
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> 
> Does not apply at all, what tree was this made against?

Ugh, I was looking at the wrong tree, nevermind, my fault...

greg k-h
Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Posted by Carlos Llamas 1 week, 2 days ago 
On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> Somehow this got changed to NULL when I ported this to upstream it. No
> idea how that happened.
> 
> Reported-by: Carlos Llamas <cmllamas@google.com>
> Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> Commit not yet upstream, so cc stable not required.
> ---
>  drivers/android/binder/rust_binder.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> --- a/drivers/android/binder/rust_binder.h
> +++ b/drivers/android/binder/rust_binder.h
> @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
>  
>  	if (p)
>  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> -	return NULL;
> +	return p;
>  }
>  
>  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> 
> ---
> base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> 
> Best regards,
> -- 
> Alice Ryhl <aliceryhl@google.com>
> 

Acked-by: Carlos Llamas <cmllamas@google.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.