[PATCH 1/2] arm64: dts: qcom: talos: Mark usb controllers are wakeup capable devices

Krishna Kurapati posted 2 patches 1 week, 5 days ago
There is a newer version of this series
[PATCH 1/2] arm64: dts: qcom: talos: Mark usb controllers are wakeup capable devices
Posted by Krishna Kurapati 1 week, 5 days ago
USB controllers on talos are wakeup capable. Hence add wakeup-source
property to both controller nodes.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
index 75716b4a58d6..315dbf3d9bed 100644
--- a/arch/arm64/boot/dts/qcom/talos.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos.dtsi
@@ -4527,6 +4527,8 @@ usb_1: usb@a6f8800 {
 			#size-cells = <2>;
 			ranges;
 
+			wakeup-source;
+
 			status = "disabled";
 
 			usb_1_dwc3: usb@a600000 {
@@ -4591,6 +4593,8 @@ usb_2: usb@a8f8800 {
 			#size-cells = <2>;
 			ranges;
 
+			wakeup-source;
+
 			status = "disabled";
 
 			usb_2_dwc3: usb@a800000 {
-- 
2.34.1
Re: [PATCH 1/2] arm64: dts: qcom: talos: Mark usb controllers are wakeup capable devices
Posted by Dmitry Baryshkov 1 week, 5 days ago
On Tue, Jan 27, 2026 at 09:25:36PM +0530, Krishna Kurapati wrote:
> USB controllers on talos are wakeup capable. Hence add wakeup-source
> property to both controller nodes.

The order of patches should be exactly opposite: first refactor, then
add new features.

> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 

-- 
With best wishes
Dmitry
Re: [PATCH 1/2] arm64: dts: qcom: talos: Mark usb controllers are wakeup capable devices
Posted by Krishna Kurapati PSSNV 1 week, 5 days ago
On Tue, Jan 27, 2026 at 10:21 PM Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com> wrote:
>
> On Tue, Jan 27, 2026 at 09:25:36PM +0530, Krishna Kurapati wrote:
> > USB controllers on talos are wakeup capable. Hence add wakeup-source
> > property to both controller nodes.
>
> The order of patches should be exactly opposite: first refactor, then
> add new features.
>

ACK.
Will send v2 reversing order of patches. Also will retain your RB on
second patch after fixing order.

Regards,
Krishna,