[PATCH v3 2/2] bcache: fix I/O accounting leak in detached_dev_do_request

zhangshida2026@163.com posted 2 patches 1 week, 6 days ago
[PATCH v3 2/2] bcache: fix I/O accounting leak in detached_dev_do_request
Posted by zhangshida2026@163.com 1 week, 6 days ago
From: Shida Zhang <zhangshida@kylinos.cn>

When a bcache device is detached, discard requests are completed
immediately. However, the I/O accounting started in
cached_dev_make_request() is not ended, leading to 100% disk
utilization reports in iostat. Add the missing bio_end_io_acct() call.

Fixes: cafe56359144 ("bcache: A block layer cache")
Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
Acked-by: Coly Li <colyli@fnnas.com>
---
 drivers/md/bcache/request.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index c2f38907a2a..3fa3b13a410 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1107,6 +1107,7 @@ static void detached_dev_do_request(struct bcache_device *d,
 
 	if (bio_op(orig_bio) == REQ_OP_DISCARD &&
 	    !bdev_max_discard_sectors(dc->bdev)) {
+		bio_end_io_acct(orig_bio, start_time);
 		bio_endio(orig_bio);
 		return;
 	}
-- 
2.34.1
Re: [PATCH v3 2/2] bcache: fix I/O accounting leak in detached_dev_do_request
Posted by Christoph Hellwig 1 week, 6 days ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>