[PATCH v2 4/8] iio: dac: ds4424: sort headers alphabetically

Oleksij Rempel posted 8 patches 2 weeks ago
There is a newer version of this series
[PATCH v2 4/8] iio: dac: ds4424: sort headers alphabetically
Posted by Oleksij Rempel 2 weeks ago
Sort the header inclusions alphabetically. This improves readability and
simplifies adding new includes in the future.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
changes v2:
- new patch
---
 drivers/iio/dac/ds4424.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
index 072b7e6672cf..a4f00045f17b 100644
--- a/drivers/iio/dac/ds4424.c
+++ b/drivers/iio/dac/ds4424.c
@@ -5,16 +5,16 @@
  * Copyright (C) 2017 Maxim Integrated
  */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/i2c.h>
-#include <linux/regulator/consumer.h>
-#include <linux/err.h>
 #include <linux/delay.h>
-#include <linux/iio/iio.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/iio/consumer.h>
 #include <linux/iio/driver.h>
+#include <linux/iio/iio.h>
 #include <linux/iio/machine.h>
-#include <linux/iio/consumer.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/regulator/consumer.h>
 
 #define DS4422_MAX_DAC_CHANNELS		2
 #define DS4424_MAX_DAC_CHANNELS		4
-- 
2.47.3
Re: [PATCH v2 4/8] iio: dac: ds4424: sort headers alphabetically
Posted by Andy Shevchenko 2 weeks ago
On Tue, Jan 27, 2026 at 07:09:35AM +0100, Oleksij Rempel wrote:
> Sort the header inclusions alphabetically. This improves readability and
> simplifies adding new includes in the future.

...

> -#include <linux/kernel.h>
> -#include <linux/module.h>
> -#include <linux/i2c.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/err.h>
>  #include <linux/delay.h>
> -#include <linux/iio/iio.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>

> +#include <linux/iio/consumer.h>
>  #include <linux/iio/driver.h>
> +#include <linux/iio/iio.h>
>  #include <linux/iio/machine.h>
> -#include <linux/iio/consumer.h>

This was at the end and I assume we want this to be kept at the end as a
separate group of linux/iio/* to emphasize on the fact that the driver is
related to that subsystem.

> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>

With that being said, I think the result should look as

#include <linux/delay.h>
#include <linux/err.h>
#include <linux/i2c.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/regulator/consumer.h>

#include <linux/iio/consumer.h>
#include <linux/iio/driver.h>
#include <linux/iio/iio.h>
#include <linux/iio/machine.h>

-- 
With Best Regards,
Andy Shevchenko