speakup: Clarify bleep_time unit is milliseconds

[PATCH] speakup: Clarify bleep_time unit is milliseconds

Posted by Henry Zhang 1 week, 4 days ago

The documentation had a TODO questioning whether the unit was in
jiffies. The implementation in drivers/accessibility/speakup/main.c
passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
in milliseconds.

Signed-off-by: Henry Zhang <zeri@umich.edu>
---
 Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
index bcb6831aa114..8b508b4a7a00 100644
--- a/Documentation/ABI/stable/sysfs-driver-speakup
+++ b/Documentation/ABI/stable/sysfs-driver-speakup
@@ -23,8 +23,7 @@ What:		/sys/accessibility/speakup/bleep_time
 KernelVersion:	2.6
 Contact:	speakup@linux-speakup.org
 Description:	This controls the duration of the PC speaker beeps speakup
-		produces.
-		TODO: What are the units? Jiffies?
+		produces, in milliseconds.
 
 What:		/sys/accessibility/speakup/cursor_time
 KernelVersion:	2.6
-- 
2.34.1

Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds

Posted by Greg KH 1 week, 4 days ago

On Mon, Jan 26, 2026 at 03:17:07PM -0500, Henry Zhang wrote:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
> 
> Signed-off-by: Henry Zhang <zeri@umich.edu>

Does not match your From: line :(

Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds

Posted by Greg KH 1 week, 4 days ago

On Tue, Jan 27, 2026 at 03:55:07PM +0100, Greg KH wrote:
> On Mon, Jan 26, 2026 at 03:17:07PM -0500, Henry Zhang wrote:
> > The documentation had a TODO questioning whether the unit was in
> > jiffies. The implementation in drivers/accessibility/speakup/main.c
> > passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> > in milliseconds.
> > 
> > Signed-off-by: Henry Zhang <zeri@umich.edu>
> 
> Does not match your From: line :(

Which my scripts did not seem to object to, so nevermind :)

Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds

Posted by Samuel Thibault 1 week, 4 days ago

Henry Zhang, le lun. 26 janv. 2026 15:17:07 -0500, a ecrit:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
> 
> Signed-off-by: Henry Zhang <zeri@umich.edu>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
> index bcb6831aa114..8b508b4a7a00 100644
> --- a/Documentation/ABI/stable/sysfs-driver-speakup
> +++ b/Documentation/ABI/stable/sysfs-driver-speakup
> @@ -23,8 +23,7 @@ What:		/sys/accessibility/speakup/bleep_time
>  KernelVersion:	2.6
>  Contact:	speakup@linux-speakup.org
>  Description:	This controls the duration of the PC speaker beeps speakup
> -		produces.
> -		TODO: What are the units? Jiffies?
> +		produces, in milliseconds.
>  
>  What:		/sys/accessibility/speakup/cursor_time
>  KernelVersion:	2.6
> -- 
> 2.34.1
>