[PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855

Mengshi Wu posted 2 patches 1 week, 6 days ago
There is a newer version of this series
[PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week, 6 days ago
Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
data structures to enable Hands-Free Profile (HFP) hardware
offload support on these Qualcomm Bluetooth chipsets.

Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
---
 drivers/bluetooth/hci_qca.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index b99fdda88..212a92bbf 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2155,7 +2155,8 @@ static const struct qca_device_data qca_soc_data_wcn6855 __maybe_unused = {
 		{ "vddrfa1p2", 257000 },
 	},
 	.num_vregs = 6,
-	.capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES,
+	.capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES |
+			QCA_CAP_HFP_HW_OFFLOAD,
 };
 
 static const struct qca_device_data qca_soc_data_wcn7850 __maybe_unused = {
-- 
2.34.1
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Dmitry Baryshkov 1 week, 6 days ago
On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
> data structures to enable Hands-Free Profile (HFP) hardware
> offload support on these Qualcomm Bluetooth chipsets.
> 
> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
> ---
>  drivers/bluetooth/hci_qca.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Any other chips which would benefit from this flag? If you are setting
it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
set for WCN6750?

-- 
With best wishes
Dmitry
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week, 6 days ago

On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
>> data structures to enable Hands-Free Profile (HFP) hardware
>> offload support on these Qualcomm Bluetooth chipsets.
>>
>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>> ---
>>  drivers/bluetooth/hci_qca.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
> 
> Any other chips which would benefit from this flag? If you are setting
> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
> set for WCN6750?
> 

Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
considered at this time.
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Dmitry Baryshkov 1 week, 6 days ago
On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
> 
> 
> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
> > On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
> >> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
> >> data structures to enable Hands-Free Profile (HFP) hardware
> >> offload support on these Qualcomm Bluetooth chipsets.
> >>
> >> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
> >> ---
> >>  drivers/bluetooth/hci_qca.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> > 
> > Any other chips which would benefit from this flag? If you are setting
> > it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
> > set for WCN6750?
> > 
> 
> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
> considered at this time.

What does it mean? It either supports HFP ofload, or not. Does it?

-- 
With best wishes
Dmitry
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week, 5 days ago
Hi, 

On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote:
> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
>>
>>
>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
>>>> data structures to enable Hands-Free Profile (HFP) hardware
>>>> offload support on these Qualcomm Bluetooth chipsets.
>>>>
>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>>>> ---
>>>>  drivers/bluetooth/hci_qca.c | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>
>>> Any other chips which would benefit from this flag? If you are setting
>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
>>> set for WCN6750?
>>>
>>
>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
>> considered at this time.
> 
> What does it mean? It either supports HFP ofload, or not. Does it?
> 

We have not yet enabled the WCN6750 hardware offload feature from the
software side. Other chips will support this feature subsequently. If
I add the flag too early, it may be kind of misleading since the feature
is not really ready yet.
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Dmitry Baryshkov 1 week, 3 days ago
On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote:
> Hi, 
> 
> On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote:
> > On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
> >>
> >>
> >> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
> >>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
> >>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
> >>>> data structures to enable Hands-Free Profile (HFP) hardware
> >>>> offload support on these Qualcomm Bluetooth chipsets.
> >>>>
> >>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
> >>>> ---
> >>>>  drivers/bluetooth/hci_qca.c | 3 ++-
> >>>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>>
> >>>
> >>> Any other chips which would benefit from this flag? If you are setting
> >>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
> >>> set for WCN6750?
> >>>
> >>
> >> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
> >> considered at this time.
> > 
> > What does it mean? It either supports HFP ofload, or not. Does it?
> > 
> 
> We have not yet enabled the WCN6750 hardware offload feature from the
> software side. Other chips will support this feature subsequently. If
> I add the flag too early, it may be kind of misleading since the feature
> is not really ready yet.

By the software side do you mean BT firmware or something else?

-- 
With best wishes
Dmitry
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week ago
Hi,

On 1/30/2026 10:31 AM, Dmitry Baryshkov wrote:
> On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote:
>> Hi, 
>>
>> On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote:
>>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
>>>>
>>>>
>>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
>>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
>>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
>>>>>> data structures to enable Hands-Free Profile (HFP) hardware
>>>>>> offload support on these Qualcomm Bluetooth chipsets.
>>>>>>
>>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>>>>>> ---
>>>>>>  drivers/bluetooth/hci_qca.c | 3 ++-
>>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>
>>>>> Any other chips which would benefit from this flag? If you are setting
>>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
>>>>> set for WCN6750?
>>>>>
>>>>
>>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
>>>> considered at this time.
>>>
>>> What does it mean? It either supports HFP ofload, or not. Does it?
>>>
>>
>> We have not yet enabled the WCN6750 hardware offload feature from the
>> software side. Other chips will support this feature subsequently. If
>> I add the flag too early, it may be kind of misleading since the feature
>> is not really ready yet.
> 
> By the software side do you mean BT firmware or something else?
> 
Yes, firmware. And we will update firmware later to support this feature.
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Dmitry Baryshkov 5 days, 12 hours ago
On Mon, Feb 02, 2026 at 10:33:53AM +0800, Mengshi Wu wrote:
> Hi,
> 
> On 1/30/2026 10:31 AM, Dmitry Baryshkov wrote:
> > On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote:
> >> Hi, 
> >>
> >> On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote:
> >>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
> >>>>
> >>>>
> >>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
> >>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
> >>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
> >>>>>> data structures to enable Hands-Free Profile (HFP) hardware
> >>>>>> offload support on these Qualcomm Bluetooth chipsets.
> >>>>>>
> >>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
> >>>>>> ---
> >>>>>>  drivers/bluetooth/hci_qca.c | 3 ++-
> >>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>>>>
> >>>>>
> >>>>> Any other chips which would benefit from this flag? If you are setting
> >>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
> >>>>> set for WCN6750?
> >>>>>
> >>>>
> >>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
> >>>> considered at this time.
> >>>
> >>> What does it mean? It either supports HFP ofload, or not. Does it?
> >>>
> >>
> >> We have not yet enabled the WCN6750 hardware offload feature from the
> >> software side. Other chips will support this feature subsequently. If
> >> I add the flag too early, it may be kind of misleading since the feature
> >> is not really ready yet.
> > 
> > By the software side do you mean BT firmware or something else?
> > 
> Yes, firmware. And we will update firmware later to support this feature.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Luiz Augusto von Dentz 1 week, 5 days ago
Hi,

On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov
<dmitry.baryshkov@oss.qualcomm.com> wrote:
>
> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
> >
> >
> > On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
> > > On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
> > >> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
> > >> data structures to enable Hands-Free Profile (HFP) hardware
> > >> offload support on these Qualcomm Bluetooth chipsets.
> > >>
> > >> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
> > >> ---
> > >>  drivers/bluetooth/hci_qca.c | 3 ++-
> > >>  1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >
> > > Any other chips which would benefit from this flag? If you are setting
> > > it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
> > > set for WCN6750?
> > >
> >
> > Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
> > considered at this time.
>
> What does it mean? It either supports HFP ofload, or not. Does it?

Or does that mean offload is considered the default over HCI, and in
that case does it actually work with the likes of Linux
distros/Pipewire or it is Android only? The fact that it is mentioning
HFP rather than SCO is already concerning to me, the kernel driver
shouldn't be involved with profile layers other than core.


>
> --
> With best wishes
> Dmitry



-- 
Luiz Augusto von Dentz
Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week, 5 days ago
Hi,

On 1/27/2026 11:47 PM, Luiz Augusto von Dentz wrote:
> Hi,
> 
> On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>>
>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
>>>
>>>
>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
>>>>> data structures to enable Hands-Free Profile (HFP) hardware
>>>>> offload support on these Qualcomm Bluetooth chipsets.
>>>>>
>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>>>>> ---
>>>>>  drivers/bluetooth/hci_qca.c | 3 ++-
>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>
>>>> Any other chips which would benefit from this flag? If you are setting
>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
>>>> set for WCN6750?
>>>>
>>>
>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
>>> considered at this time.
>>
>> What does it mean? It either supports HFP ofload, or not. Does it?
> 
> Or does that mean offload is considered the default over HCI, and in
> that case does it actually work with the likes of Linux
> distros/Pipewire or it is Android only? The fact that it is mentioning
> HFP rather than SCO is already concerning to me, the kernel driver
> shouldn't be involved with profile layers other than core.
> 
> 

Offload over HCI is the default way in most cases, but I don't mean it
here. Offload over non-HCI ways (such as I2S, Slimbus) need other supports
from software aspect, but these supports are not ready for other chips yet.

I use HFP because I noticed that it was used before, like qca_configure_hfp_offload().
Should I change to use SCO if HFP is not proper here?

>>
>> --
>> With best wishes
>> Dmitry
> 
> 
> 

Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855
Posted by Mengshi Wu 1 week, 5 days ago
Hi,

On 1/27/2026 11:47 PM, Luiz Augusto von Dentz wrote:
> Hi,
> 
> On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
>>
>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote:
>>>
>>>
>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote:
>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote:
>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device
>>>>> data structures to enable Hands-Free Profile (HFP) hardware
>>>>> offload support on these Qualcomm Bluetooth chipsets.
>>>>>
>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>>>>> ---
>>>>>  drivers/bluetooth/hci_qca.c | 3 ++-
>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>
>>>> Any other chips which would benefit from this flag? If you are setting
>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be
>>>> set for WCN6750?
>>>>
>>>
>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not
>>> considered at this time.
>>
>> What does it mean? It either supports HFP ofload, or not. Does it?
> 
> Or does that mean offload is considered the default over HCI, and in
> that case does it actually work with the likes of Linux
> distros/Pipewire or it is Android only? The fact that it is mentioning
> HFP rather than SCO is already concerning to me, the kernel driver
> shouldn't be involved with profile layers other than core.
> 

Offloading over HCI is the default way for most use cases, but I don't mean
it. Offloading over non-HCI ways (such as I2S, slimbus) need some other
supports from software aspect, these supports for other chips are not ready
yet.

I use HFP because I notice it was used before, like qca_configure_hfp_offload().
Should I correct it if it is not proper here?

> 
>>
>> --
>> With best wishes
>> Dmitry
> 
> 
>