[PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis

Khairul Anuar Romli posted 3 patches 1 week, 5 days ago
There is a newer version of this series
[PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Posted by Khairul Anuar Romli 1 week, 5 days ago
Correct alignment issue so that continuation lines properly match the
position of the opening parenthesis. This alignment issue were detected
with the help of the checkpatch.pl analysis tool with --strict --file
option.

The fix applies to code introduced in:
- 'commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")'
- 'commit e32634f466a9 ("dma: dw-axi-dmac: support per channel
   interrupt")'

Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 493c2a32b0fe..8bb97fb8fd4c 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -342,8 +342,8 @@ static void axi_desc_put(struct axi_dma_desc *desc)
 	kfree(desc);
 	atomic_sub(descs_put, &chan->descs_allocated);
 	dev_vdbg(chan2dev(chan), "%s: %d descs put, %d still allocated\n",
-		axi_chan_name(chan), descs_put,
-		atomic_read(&chan->descs_allocated));
+		 axi_chan_name(chan), descs_put,
+		 atomic_read(&chan->descs_allocated));
 }
 
 static void vchan_desc_put(struct virt_dma_desc *vdesc)
@@ -353,7 +353,7 @@ static void vchan_desc_put(struct virt_dma_desc *vdesc)
 
 static enum dma_status
 dma_chan_tx_status(struct dma_chan *dchan, dma_cookie_t cookie,
-		  struct dma_tx_state *txstate)
+		   struct dma_tx_state *txstate)
 {
 	struct axi_dma_chan *chan = dchan_to_axi_dma_chan(dchan);
 	struct virt_dma_desc *vdesc;
@@ -491,7 +491,7 @@ static void axi_chan_start_first_queued(struct axi_dma_chan *chan)
 
 	desc = vd_to_axi_desc(vd);
 	dev_vdbg(chan2dev(chan), "%s: started %u\n", axi_chan_name(chan),
-		vd->tx.cookie);
+		 vd->tx.cookie);
 	axi_chan_block_xfer_start(chan, desc);
 }
 
@@ -1162,7 +1162,7 @@ static irqreturn_t dw_axi_dma_interrupt(int irq, void *dev_id)
 		axi_chan_irq_clear(chan, status);
 
 		dev_vdbg(chip->dev, "%s %u IRQ status: 0x%08x\n",
-			axi_chan_name(chan), i, status);
+			 axi_chan_name(chan), i, status);
 
 		if (status & DWAXIDMAC_IRQ_ALL_ERR)
 			axi_chan_handle_err(chan, status);
@@ -1451,7 +1451,7 @@ static int axi_req_irqs(struct platform_device *pdev, struct axi_dma_chip *chip)
 		if (chip->irq[i] < 0)
 			return chip->irq[i];
 		ret = devm_request_irq(chip->dev, chip->irq[i], dw_axi_dma_interrupt,
-				IRQF_SHARED, KBUILD_MODNAME, chip);
+				       IRQF_SHARED, KBUILD_MODNAME, chip);
 		if (ret < 0)
 			return ret;
 	}
@@ -1645,7 +1645,7 @@ static void dw_remove(struct platform_device *pdev)
 	of_dma_controller_free(chip->dev->of_node);
 
 	list_for_each_entry_safe(chan, _chan, &dw->dma.channels,
-			vc.chan.device_node) {
+				 vc.chan.device_node) {
 		list_del(&chan->vc.chan.device_node);
 		tasklet_kill(&chan->vc.task);
 	}
-- 
2.43.0
Re: [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Posted by Markus Elfring 1 week, 5 days ago
> Correct alignment issue so that continuation lines properly match the
> position of the opening parenthesis.

Line break?


>                                      This alignment issue were detected

                                       This issue was?


> with the help of the checkpatch.pl analysis tool with --strict --file
> option.

Would it be nicer to put such information into another paragraph?


> - 'commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")'
> - 'commit e32634f466a9 ("dma: dw-axi-dmac: support per channel
>    interrupt")'

Is there a need to reformat such details a bit more?


How do you think about to refine the summary phrase another bit?

Regards,
Markus
Re: [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Posted by Khairul Anuar Romli 1 week ago
On 26/1/2026 7:12 pm, Markus Elfring wrote:
>> Correct alignment issue so that continuation lines properly match the
>> position of the opening parenthesis.
> 
> Line break?

Sure.
> 
> 
>>                                       This alignment issue were detected
> 
>                                         This issue was?
> 
Will put it in the next version

> 
>> with the help of the checkpatch.pl analysis tool with --strict --file
>> option.
> 
> Would it be nicer to put such information into another paragraph?
> 
Yeah, I will do this.

> 
>> - 'commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")'
>> - 'commit e32634f466a9 ("dma: dw-axi-dmac: support per channel
>>     interrupt")'
> 
> Is there a need to reformat such details a bit more?
> 
We are going back in the circle. I already put the details in the form 
of line and code but you mentioned I shall not list all the effected 
line before.

> 
> How do you think about to refine the summary phrase another bit?

I'll refine it.

> 
> Regards,
> Markus


Thanks.

Regards,
Khairul
Re: [v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Posted by Markus Elfring 6 days, 23 hours ago
>> Is there a need to reformat such details a bit more?
>>
> We are going back in the circle.

I hope not.

But we are stumbling on recurring challenges according to collateral evolution
and some communication difficulties.


> I already put the details in the form of line and code but you mentioned I shall not list all the effected line before.

It seems that you interpreted a bit of my patch review feedback
in undesirable directions.
Further contributors might become more helpful for corresponding clarifications.

Regards,
Markus