ALSA: hda/tas2781: Add tas2781_hda::catlog_id init

[PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init

Posted by Shenghao Ding 1 week, 6 days ago

The default of tas2781_hda::catlog_id is DELL, which cause calibration
data is not loaded in HP SPI-basded Laptop, because only HP laptop
supports SPI-based TAS2781.

Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
 sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
index 5454b7ac22c6..0c9b57b6ff55 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
@@ -727,6 +727,9 @@ static int tas2781_hda_bind(struct device *dev, struct device *master,
 	if (!ret)
 		comp->playback_hook = tas2781_hda_playback_hook;
 
+	/* Only HP Laptop support SPI-based TAS2781 */
+	tas_hda->catlog_id = HP;
+
 	return ret;
 }
 
-- 
2.43.0

Re: [PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init

Posted by Takashi Iwai 1 week, 5 days ago

On Mon, 26 Jan 2026 04:18:16 +0100,
Shenghao Ding wrote:
> 
> The default of tas2781_hda::catlog_id is DELL, which cause calibration
> data is not loaded in HP SPI-basded Laptop, because only HP laptop
> supports SPI-based TAS2781.
> 
> Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

Applied now.  Thanks.


Takashi