[PATCH] drm/display: bridge_connector: move audio_infoframe checks to OP_HDMI

Dmitry Baryshkov posted 1 patch 1 week, 6 days ago
drivers/gpu/drm/display/drm_bridge_connector.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
[PATCH] drm/display: bridge_connector: move audio_infoframe checks to OP_HDMI
Posted by Dmitry Baryshkov 1 week, 6 days ago
There are DRM_BRIDGE_OP_HDMI_AUDIO bridges (e.g. Lontium LT9611UXC)
which don't implement DRM_BRIDGE_OP_HDMI and don't implement
hdmi_clear_audio_infoframe / hdmi_write_audio_infoframe callbacks.

Move corresponding checks under the DRM_BRIDGE_OP_HDMI condition, making
sure that we require those callbacks only from the bridges which are
actually going to use them.

Fixes: b626b1a1c9cc ("drm/bridge: refactor HDMI InfoFrame callbacks")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/gpu/drm/display/drm_bridge_connector.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c
index ba8ff113cff1..258132c6b8b5 100644
--- a/drivers/gpu/drm/display/drm_bridge_connector.c
+++ b/drivers/gpu/drm/display/drm_bridge_connector.c
@@ -851,6 +851,11 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
 			    !bridge->funcs->hdmi_clear_hdmi_infoframe)
 				return ERR_PTR(-EINVAL);
 
+			if (bridge->ops & DRM_BRIDGE_OP_HDMI_AUDIO &&
+			    (!bridge->funcs->hdmi_write_audio_infoframe ||
+			     !bridge->funcs->hdmi_clear_audio_infoframe))
+				return ERR_PTR(-EINVAL);
+
 			if (bridge->ops & DRM_BRIDGE_OP_HDMI_HDR_DRM_INFOFRAME &&
 			    (!bridge->funcs->hdmi_write_hdr_drm_infoframe ||
 			     !bridge->funcs->hdmi_clear_hdr_drm_infoframe))
@@ -880,9 +885,7 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
 			    !bridge->hdmi_audio_spdif_playback)
 				return ERR_PTR(-EINVAL);
 
-			if (!bridge->funcs->hdmi_write_audio_infoframe ||
-			    !bridge->funcs->hdmi_clear_audio_infoframe ||
-			    !bridge->funcs->hdmi_audio_prepare ||
+			if (!bridge->funcs->hdmi_audio_prepare ||
 			    !bridge->funcs->hdmi_audio_shutdown)
 				return ERR_PTR(-EINVAL);
 

---
base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
change-id: 20260126-drm-fix-lt9611uxc-05ee19305a52

Best regards,
-- 
With best wishes
Dmitry
Re: [PATCH] drm/display: bridge_connector: move audio_infoframe checks to OP_HDMI
Posted by Dmitry Baryshkov 1 week, 5 days ago
On Mon, 26 Jan 2026 13:44:27 +0200, Dmitry Baryshkov wrote:
> There are DRM_BRIDGE_OP_HDMI_AUDIO bridges (e.g. Lontium LT9611UXC)
> which don't implement DRM_BRIDGE_OP_HDMI and don't implement
> hdmi_clear_audio_infoframe / hdmi_write_audio_infoframe callbacks.
> 
> Move corresponding checks under the DRM_BRIDGE_OP_HDMI condition, making
> sure that we require those callbacks only from the bridges which are
> actually going to use them.
> 
> [...]

Applied to drm-misc-next-fixes, thanks!

[1/1] drm/display: bridge_connector: move audio_infoframe checks to OP_HDMI
      commit: 474d54095090be8ea8701d4a16476f488aa06959

Best regards,
-- 
With best wishes
Dmitry
Re: [PATCH] drm/display: bridge_connector: move audio_infoframe checks to OP_HDMI
Posted by Maxime Ripard 1 week, 6 days ago
On Mon, 26 Jan 2026 13:44:27 +0200, Dmitry Baryshkov wrote:
> There are DRM_BRIDGE_OP_HDMI_AUDIO bridges (e.g. Lontium LT9611UXC)
> which don't implement DRM_BRIDGE_OP_HDMI and don't implement
> hdmi_clear_audio_infoframe / hdmi_write_audio_infoframe callbacks.
> 
> Move corresponding checks under the DRM_BRIDGE_OP_HDMI condition, making
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime