[v7 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector

Aaron Tomlin posted 2 patches 1 week, 6 days ago
Documentation/admin-guide/sysctl/kernel.rst |   3 +-
kernel/hung_task.c                          | 108 +++++++++++++++-----
2 files changed, 82 insertions(+), 29 deletions(-)
[v7 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector
Posted by Aaron Tomlin 1 week, 6 days ago
Hi Lance, Greg, Petr, Joel, Andrew,

This series introduces the ability to reset
/proc/sys/kernel/hung_task_detect_count.

Writing a "0" value to this file atomically resets the counter of detected
hung tasks. This functionality provides system administrators with the
means to clear the cumulative diagnostic history following incident
resolution, thereby simplifying subsequent monitoring without necessitating
a system restart.

The updated logic ensures that the long-running scan (which is inherently
preemptible and subject to rcu_lock_break()) does not become desynchronised
from the global state. By treating the initial read as a "version snapshot"
the kernel can guarantee that the cumulative count only updates if the
underlying state remained stable throughout the duration of the
scan.

Please let me know your thoughts.


Changes since v6 [1]:
 - Decoupled the detection logic from the reporting logic.
   check_hung_task() was renamed to hung_task_info() and the task_is_hung()
   check was hoisted into the primary check_hung_uninterruptible_tasks()
   loop (Petr Mladek)

 - Changed the global statistic update mechanism from incremental atomic
   increments (per task) to a single batched atomic_long_cmpxchg_relaxed()
   at the end of the scan (Petr Mladek)

 - Strengthened the memory ordering using atomic_long_read_acquire() and
   atomic_long_cmpxchg_release(). This ensures strict synchronisation
   between the scan and concurrent userspace resets (Petr Mladek)

 - Updated the inline reporting comment to remove the hardcoded "2 minutes"
   reference

Changes since v5 [2]:
 - Introduced a preparatory patch (Joel Granados)
 - Extended custom proc_handler to handle SYSCTL_USER_TO_KERN writes,
   strictly validating that only a value of "0" is permitted for resets
   (Joel Granados)
 - Transitioned from atomic_long_inc_return_relaxed() to a more robust
   read_acquire/cmpxchg_release pattern to ensure "All-or-Nothing" scan
   updates (Petr Mladek)
 - Re-introduce hung_task_diagnostics(). For better readability and
   consistent metadata publication

Changes since v4 [3]:
 - Added missing underflow check (Lance Yang) 

Changes since v3 [4]:
 - Use atomic operations to ensure cross-CPU visibility and prevent an integer underflow
 - Use acquire/release semantics for memory ordering (Petr Mladek)
 - Move quoted string to a single line (Petr Mladek)
 - Remove variables coredump_msg and disable_msg to simplify code (Petr Mladek)
 - Add trailing "\n" to all strings to ensure immediate console flushing (Petr Mladek)
 - Improve the hung task counter documentation (Joel Granados)
 - Reject non-zero writes with -EINVAL (Joel Granados)
 - Translate to the new sysctl API (Petr Mladek)

Changes since v2 [5]:
 - Avoided a needless double update to hung_task_detect_count (Lance Yang)
 - Restored previous use of pr_err() for each message (Greg KH)
 - Provided a complete descriptive comment for the helper

Changes since v1 [6]:
 - Removed write-only sysfs attribute (Lance Yang)
 - Modified procfs hung_task_detect_count instead (Lance Yang)
 - Introduced a custom proc_handler
 - Updated documentation (Lance Yang)
 - Added 'static inline' as a hint to eliminate any function call overhead
 - Removed clutter through encapsulation

[1]: https://lore.kernel.org/lkml/20260115023229.3028462-1-atomlin@atomlin.com/
[2]: https://lore.kernel.org/lkml/20251231004125.2380105-1-atomlin@atomlin.com/
[3]: https://lore.kernel.org/lkml/20251222014210.2032214-1-atomlin@atomlin.com/
[4]: https://lore.kernel.org/all/20251216030036.1822217-1-atomlin@atomlin.com/
[5]: https://lore.kernel.org/lkml/20251211033004.1628875-1-atomlin@atomlin.com/
[6]: https://lore.kernel.org/lkml/20251209041218.1583600-1-atomlin@atomlin.com/

Aaron Tomlin (2):
  hung_task: Refactor detection logic and atomicise detection count
  hung_task: Enable runtime reset of hung_task_detect_count

 Documentation/admin-guide/sysctl/kernel.rst |   3 +-
 kernel/hung_task.c                          | 108 +++++++++++++++-----
 2 files changed, 82 insertions(+), 29 deletions(-)

-- 
2.51.0
Re: [v7 PATCH 0/2] hung_task: Provide runtime reset interface for hung task detector
Posted by Aaron Tomlin 5 days, 22 hours ago
On Sun, Jan 25, 2026 at 08:58:46AM -0500, Aaron Tomlin wrote:
> This series introduces the ability to reset
> /proc/sys/kernel/hung_task_detect_count.

Hi Andrew, Lance, Greg, Petr, Joel and Masami,

I am keen to ascertain if this series now aligns with your expectations. I
would appreciate your confirmation that this implementation is suitable for
acceptance before I commit to any further patch work or minor refinements.


Kind regards,
-- 
Aaron Tomlin