[PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel

Svyatoslav Ryhel posted 2 patches 2 weeks ago
[PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel
Posted by Svyatoslav Ryhel 2 weeks ago
Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
panel vendor and model are unknown hence generic compatible is used based
on board name it is used with.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
new file mode 100644
index 000000000000..2326a83bc405
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atrix 4G and Droid X2 DSI Display Panel
+
+maintainers:
+  - Svyatoslav Ryhel <clamor95@gmail.com>
+
+description:
+  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
+  panel vendor and model are unknown hence generic compatible is used.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: motorola,mot-panel
+
+  reg:
+    maxItems: 1
+
+  vdd-supply:
+    description: Regulator for main power supply.
+
+  vddio-supply:
+    description: Regulator for 1.8V IO power supply.
+
+  backlight: true
+  reset-gpios: true
+  port: true
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "motorola,mot-panel";
+            reg = <0>;
+
+            reset-gpios = <&gpio 35 GPIO_ACTIVE_LOW>;
+
+            vdd-supply = <&vdd_5v0_panel>;
+            vddio-supply = <&vdd_1v8_vio>;
+
+            backlight = <&backlight>;
+
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&dsi_out>;
+                };
+            };
+        };
+    };
+...
-- 
2.51.0
Re: [PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel
Posted by Conor Dooley 1 week, 6 days ago
On Sun, Jan 25, 2026 at 03:19:03PM +0200, Svyatoslav Ryhel wrote:
> Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> panel vendor and model are unknown hence generic compatible is used based
> on board name it is used with.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> new file mode 100644
> index 000000000000..2326a83bc405
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atrix 4G and Droid X2 DSI Display Panel
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +description:
> +  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> +  panel vendor and model are unknown hence generic compatible is used.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: motorola,mot-panel

What's a "mot" panel? If that's short for motorola, wouldn't it be
better to conjure up something at least more specific to these
particular users? The commit message has some info, but I still dunno
where "mot" comes from.
Seems okay otherwise..

> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator for main power supply.
> +
> +  vddio-supply:
> +    description: Regulator for 1.8V IO power supply.
> +
> +  backlight: true
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "motorola,mot-panel";
> +            reg = <0>;
> +
> +            reset-gpios = <&gpio 35 GPIO_ACTIVE_LOW>;
> +
> +            vdd-supply = <&vdd_5v0_panel>;
> +            vddio-supply = <&vdd_1v8_vio>;
> +
> +            backlight = <&backlight>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
> +...
> -- 
> 2.51.0
> 
Re: [PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel
Posted by Svyatoslav Ryhel 1 week, 6 days ago
пн, 26 січ. 2026 р. о 22:45 Conor Dooley <conor@kernel.org> пише:
>
> On Sun, Jan 25, 2026 at 03:19:03PM +0200, Svyatoslav Ryhel wrote:
> > Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > panel vendor and model are unknown hence generic compatible is used based
> > on board name it is used with.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> >  .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
> >  1 file changed, 68 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > new file mode 100644
> > index 000000000000..2326a83bc405
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Atrix 4G and Droid X2 DSI Display Panel
> > +
> > +maintainers:
> > +  - Svyatoslav Ryhel <clamor95@gmail.com>
> > +
> > +description:
> > +  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > +  panel vendor and model are unknown hence generic compatible is used.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: motorola,mot-panel
>
> What's a "mot" panel? If that's short for motorola, wouldn't it be
> better to conjure up something at least more specific to these
> particular users? The commit message has some info, but I still dunno
> where "mot" comes from.
> Seems okay otherwise..
>

"Mot" is how motorola called tegra20 board files which were base for
Atrix 4G and Droid X2 in their downstream sources, specifically
board-mot-panel.c. Since both devices use the same panel I used board
name. Hopefully, at come point I will be able to name it properly.

I have device trees for both devices prepared and I will submit them shortly.

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply:
> > +    description: Regulator for main power supply.
> > +
> > +  vddio-supply:
> > +    description: Regulator for 1.8V IO power supply.
> > +
> > +  backlight: true
> > +  reset-gpios: true
> > +  port: true
> > +
> > +required:
> > +  - compatible
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@0 {
> > +            compatible = "motorola,mot-panel";
> > +            reg = <0>;
> > +
> > +            reset-gpios = <&gpio 35 GPIO_ACTIVE_LOW>;
> > +
> > +            vdd-supply = <&vdd_5v0_panel>;
> > +            vddio-supply = <&vdd_1v8_vio>;
> > +
> > +            backlight = <&backlight>;
> > +
> > +            port {
> > +                panel_in: endpoint {
> > +                    remote-endpoint = <&dsi_out>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +...
> > --
> > 2.51.0
> >
Re: [PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel
Posted by Conor Dooley 1 week, 5 days ago
On Tue, Jan 27, 2026 at 08:26:32AM +0200, Svyatoslav Ryhel wrote:
> пн, 26 січ. 2026 р. о 22:45 Conor Dooley <conor@kernel.org> пише:
> >
> > On Sun, Jan 25, 2026 at 03:19:03PM +0200, Svyatoslav Ryhel wrote:
> > > Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > > panel vendor and model are unknown hence generic compatible is used based
> > > on board name it is used with.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > >  .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
> > >  1 file changed, 68 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > > new file mode 100644
> > > index 000000000000..2326a83bc405
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > > @@ -0,0 +1,68 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Atrix 4G and Droid X2 DSI Display Panel
> > > +
> > > +maintainers:
> > > +  - Svyatoslav Ryhel <clamor95@gmail.com>
> > > +
> > > +description:
> > > +  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > > +  panel vendor and model are unknown hence generic compatible is used.
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - const: motorola,mot-panel
> >
> > What's a "mot" panel? If that's short for motorola, wouldn't it be
> > better to conjure up something at least more specific to these
> > particular users? The commit message has some info, but I still dunno
> > where "mot" comes from.
> > Seems okay otherwise..
> >
> 
> "Mot" is how motorola called tegra20 board files which were base for
> Atrix 4G and Droid X2 in their downstream sources, specifically
> board-mot-panel.c. Since both devices use the same panel I used board
> name. Hopefully, at come point I will be able to name it properly.

Can you put this explanation in the commit message please? Without being
familiar with the platform, it's nigh impossible to know how "mot"
relates to Atrix 4G or Droid X2.
Re: [PATCH v1 1/2] dt-bindings: display: panel: document Atrix 4G and Droid X2 DSI panel
Posted by Svyatoslav Ryhel 1 week, 5 days ago
вт, 27 січ. 2026 р. о 21:41 Conor Dooley <conor@kernel.org> пише:
>
> On Tue, Jan 27, 2026 at 08:26:32AM +0200, Svyatoslav Ryhel wrote:
> > пн, 26 січ. 2026 р. о 22:45 Conor Dooley <conor@kernel.org> пише:
> > >
> > > On Sun, Jan 25, 2026 at 03:19:03PM +0200, Svyatoslav Ryhel wrote:
> > > > Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > > > panel vendor and model are unknown hence generic compatible is used based
> > > > on board name it is used with.
> > > >
> > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > > ---
> > > >  .../display/panel/motorola,mot-panel.yaml     | 68 +++++++++++++++++++
> > > >  1 file changed, 68 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > > > new file mode 100644
> > > > index 000000000000..2326a83bc405
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/panel/motorola,mot-panel.yaml
> > > > @@ -0,0 +1,68 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/display/panel/motorola,mot-panel.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Atrix 4G and Droid X2 DSI Display Panel
> > > > +
> > > > +maintainers:
> > > > +  - Svyatoslav Ryhel <clamor95@gmail.com>
> > > > +
> > > > +description:
> > > > +  Atrix 4G and Droid X2 use the same 540x960 DSI video mode panel. Exact
> > > > +  panel vendor and model are unknown hence generic compatible is used.
> > > > +
> > > > +allOf:
> > > > +  - $ref: panel-common.yaml#
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    items:
> > > > +      - const: motorola,mot-panel
> > >
> > > What's a "mot" panel? If that's short for motorola, wouldn't it be
> > > better to conjure up something at least more specific to these
> > > particular users? The commit message has some info, but I still dunno
> > > where "mot" comes from.
> > > Seems okay otherwise..
> > >
> >
> > "Mot" is how motorola called tegra20 board files which were base for
> > Atrix 4G and Droid X2 in their downstream sources, specifically
> > board-mot-panel.c. Since both devices use the same panel I used board
> > name. Hopefully, at come point I will be able to name it properly.
>
> Can you put this explanation in the commit message please? Without being
> familiar with the platform, it's nigh impossible to know how "mot"
> relates to Atrix 4G or Droid X2.

Sure, if v2 is required, I will update commit message.