From: Konrad Dybcio <konradybcio@kernel.org>
Both of these SoCs implement an IRIS2 block, with SC8280XP being able
to clock it a bit higher and with SM8350 having 4 VPP pipes, while
SC8280XP having just 2.
Document Iris2 cores found on these SoCs.
Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
[ bod: dropped dts video-encoder/video-decoder ]
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
[db: dropped status, dropped extra LLCC interconnect]
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
.../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++
1 file changed, 113 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
new file mode 100644
index 000000000000..d78bdc08d830
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
@@ -0,0 +1,113 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SM8350 Venus video encode and decode accelerators
+
+maintainers:
+ - Konrad Dybcio <konradybcio@kernel.org>
+
+description: |
+ The Venus Iris2 IP is a video encode and decode accelerator present
+ on Qualcomm platforms
+
+allOf:
+ - $ref: qcom,venus-common.yaml#
+
+properties:
+ compatible:
+ enum:
+ - qcom,sc8280xp-venus
+ - qcom,sm8350-venus
+
+ clocks:
+ maxItems: 3
+
+ clock-names:
+ items:
+ - const: iface
+ - const: core
+ - const: vcodec0_core
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: core
+
+ power-domains:
+ maxItems: 3
+
+ power-domain-names:
+ items:
+ - const: venus
+ - const: vcodec0
+ - const: mx
+
+ interconnects:
+ maxItems: 2
+
+ interconnect-names:
+ items:
+ - const: cpu-cfg
+ - const: video-mem
+
+ operating-points-v2: true
+ opp-table:
+ type: object
+
+ iommus:
+ maxItems: 1
+
+required:
+ - compatible
+ - power-domain-names
+ - iommus
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,gcc-sm8350.h>
+ #include <dt-bindings/clock/qcom,sm8350-videocc.h>
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interconnect/qcom,sm8350.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ venus: video-codec@aa00000 {
+ compatible = "qcom,sm8350-venus";
+ reg = <0x0aa00000 0x100000>;
+ interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+ clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+ <&videocc VIDEO_CC_MVS0C_CLK>,
+ <&videocc VIDEO_CC_MVS0_CLK>;
+ clock-names = "iface",
+ "core",
+ "vcodec0_core";
+
+ resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
+ reset-names = "core";
+
+ power-domains = <&videocc MVS0C_GDSC>,
+ <&videocc MVS0_GDSC>,
+ <&rpmhpd SM8350_MX>;
+ power-domain-names = "venus",
+ "vcodec0",
+ "mx";
+
+ interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "cpu-cfg",
+ "video-mem";
+
+ operating-points-v2 = <&venus_opp_table>;
+ iommus = <&apps_smmu 0x2100 0x400>;
+ memory-region = <&pil_video_mem>;
+ };
--
2.47.3On 25/01/2026 15:32, Dmitry Baryshkov wrote: > + iommus = <&apps_smmu 0x2100 0x400>; Is this actually the correct set of iommus ? Can we check to make sure ? --- bod
On Mon, Feb 02, 2026 at 03:25:51PM +0000, Bryan O'Donoghue wrote: > On 25/01/2026 15:32, Dmitry Baryshkov wrote: > > + iommus = <&apps_smmu 0x2100 0x400>; > > Is this actually the correct set of iommus ? > > Can we check to make sure ? I will check. -- With best wishes Dmitry
On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote: > From: Konrad Dybcio <konradybcio@kernel.org> > > Both of these SoCs implement an IRIS2 block, with SC8280XP being able > to clock it a bit higher and with SM8350 having 4 VPP pipes, while > SC8280XP having just 2. SC8280XP is also 4 Pipe. Thanks, Dikshita
On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote:
> From: Konrad Dybcio <konradybcio@kernel.org>
>
> Both of these SoCs implement an IRIS2 block, with SC8280XP being able
> to clock it a bit higher and with SM8350 having 4 VPP pipes, while
> SC8280XP having just 2.
>
> Document Iris2 cores found on these SoCs.
>
> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> [ bod: dropped dts video-encoder/video-decoder ]
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> [db: dropped status, dropped extra LLCC interconnect]
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++
> 1 file changed, 113 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
> new file mode 100644
> index 000000000000..d78bdc08d830
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SM8350 Venus video encode and decode accelerators
s/Venus/iris
> +
> +maintainers:
> + - Konrad Dybcio <konradybcio@kernel.org>
> +
> +description: |
> + The Venus Iris2 IP is a video encode and decode accelerator present
> + on Qualcomm platforms
> +
> +allOf:
> + - $ref: qcom,venus-common.yaml#
Pls remove the reference to venus-common.yaml and follow schema of
sm8550-iris.yaml
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sc8280xp-venus
> + - qcom,sm8350-venus
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: iface
> + - const: core
> + - const: vcodec0_core
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: core
It should be named as bus not core
> +
> + power-domains:
> + maxItems: 3
> +
> + power-domain-names:
> + items:
> + - const: venus
> + - const: vcodec0
> + - const: mx
> +
> + interconnects:
> + maxItems: 2
> +
> + interconnect-names:
> + items:
> + - const: cpu-cfg
> + - const: video-mem
> +
> + operating-points-v2: true
> + opp-table:
> + type: object
> +
> + iommus:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - power-domain-names
> + - iommus
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/qcom,gcc-sm8350.h>
> + #include <dt-bindings/clock/qcom,sm8350-videocc.h>
> + #include <dt-bindings/interconnect/qcom,icc.h>
> + #include <dt-bindings/interconnect/qcom,sm8350.h>
> + #include <dt-bindings/power/qcom-rpmpd.h>
> +
> + venus: video-codec@aa00000 {
> + compatible = "qcom,sm8350-venus";
> + reg = <0x0aa00000 0x100000>;
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +
> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
> + <&videocc VIDEO_CC_MVS0C_CLK>,
> + <&videocc VIDEO_CC_MVS0_CLK>;
> + clock-names = "iface",
> + "core",
> + "vcodec0_core";
> +
> + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
> + reset-names = "core";
s/core/bus following the existing YAML
Thanks,
Dikshita
> +
> + power-domains = <&videocc MVS0C_GDSC>,
> + <&videocc MVS0_GDSC>,
> + <&rpmhpd SM8350_MX>;
> + power-domain-names = "venus",
> + "vcodec0",
> + "mx";
> +
> + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
> + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
> + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> + interconnect-names = "cpu-cfg",
> + "video-mem";
> +
> + operating-points-v2 = <&venus_opp_table>;
> + iommus = <&apps_smmu 0x2100 0x400>;
> + memory-region = <&pil_video_mem>;
> + };
>
On Fri, Jan 30, 2026 at 05:59:48PM +0530, Dikshita Agarwal wrote:
>
>
> On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote:
> > From: Konrad Dybcio <konradybcio@kernel.org>
> >
> > Both of these SoCs implement an IRIS2 block, with SC8280XP being able
> > to clock it a bit higher and with SM8350 having 4 VPP pipes, while
> > SC8280XP having just 2.
> >
> > Document Iris2 cores found on these SoCs.
> >
> > Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > [ bod: dropped dts video-encoder/video-decoder ]
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > [db: dropped status, dropped extra LLCC interconnect]
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> > .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++
> > 1 file changed, 113 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
> > new file mode 100644
> > index 000000000000..d78bdc08d830
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
> > @@ -0,0 +1,113 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm SM8350 Venus video encode and decode accelerators
>
> s/Venus/iris
>
> > +
> > +maintainers:
> > + - Konrad Dybcio <konradybcio@kernel.org>
> > +
> > +description: |
> > + The Venus Iris2 IP is a video encode and decode accelerator present
> > + on Qualcomm platforms
> > +
> > +allOf:
> > + - $ref: qcom,venus-common.yaml#
>
> Pls remove the reference to venus-common.yaml and follow schema of
> sm8550-iris.yaml
Why? For example, sm8750-iris uses venus-common.yaml.
>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - qcom,sc8280xp-venus
> > + - qcom,sm8350-venus
> > +
> > + clocks:
> > + maxItems: 3
> > +
> > + clock-names:
> > + items:
> > + - const: iface
> > + - const: core
> > + - const: vcodec0_core
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + reset-names:
> > + items:
> > + - const: core
>
> It should be named as bus not core
Ack
>
> > +
> > + power-domains:
> > + maxItems: 3
> > +
> > + power-domain-names:
> > + items:
> > + - const: venus
> > + - const: vcodec0
> > + - const: mx
> > +
> > + interconnects:
> > + maxItems: 2
> > +
> > + interconnect-names:
> > + items:
> > + - const: cpu-cfg
> > + - const: video-mem
> > +
> > + operating-points-v2: true
> > + opp-table:
> > + type: object
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - power-domain-names
> > + - iommus
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/qcom,gcc-sm8350.h>
> > + #include <dt-bindings/clock/qcom,sm8350-videocc.h>
> > + #include <dt-bindings/interconnect/qcom,icc.h>
> > + #include <dt-bindings/interconnect/qcom,sm8350.h>
> > + #include <dt-bindings/power/qcom-rpmpd.h>
> > +
> > + venus: video-codec@aa00000 {
> > + compatible = "qcom,sm8350-venus";
> > + reg = <0x0aa00000 0x100000>;
> > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
> > + <&videocc VIDEO_CC_MVS0C_CLK>,
> > + <&videocc VIDEO_CC_MVS0_CLK>;
> > + clock-names = "iface",
> > + "core",
> > + "vcodec0_core";
> > +
> > + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
> > + reset-names = "core";
>
> s/core/bus following the existing YAML
>
> Thanks,
> Dikshita
>
> > +
> > + power-domains = <&videocc MVS0C_GDSC>,
> > + <&videocc MVS0_GDSC>,
> > + <&rpmhpd SM8350_MX>;
> > + power-domain-names = "venus",
> > + "vcodec0",
> > + "mx";
> > +
> > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
> > + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
> > + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
> > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> > + interconnect-names = "cpu-cfg",
> > + "video-mem";
> > +
> > + operating-points-v2 = <&venus_opp_table>;
> > + iommus = <&apps_smmu 0x2100 0x400>;
> > + memory-region = <&pil_video_mem>;
> > + };
> >
--
With best wishes
Dmitry
On 1/31/2026 1:03 PM, Dmitry Baryshkov wrote:
> On Fri, Jan 30, 2026 at 05:59:48PM +0530, Dikshita Agarwal wrote:
>>
>>
>> On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote:
>>> From: Konrad Dybcio <konradybcio@kernel.org>
>>>
>>> Both of these SoCs implement an IRIS2 block, with SC8280XP being able
>>> to clock it a bit higher and with SM8350 having 4 VPP pipes, while
>>> SC8280XP having just 2.
>>>
>>> Document Iris2 cores found on these SoCs.
>>>
>>> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
>>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>>> [ bod: dropped dts video-encoder/video-decoder ]
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> [db: dropped status, dropped extra LLCC interconnect]
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++
>>> 1 file changed, 113 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
>>> new file mode 100644
>>> index 000000000000..d78bdc08d830
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
>>> @@ -0,0 +1,113 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm SM8350 Venus video encode and decode accelerators
>>
>> s/Venus/iris
>>
>>> +
>>> +maintainers:
>>> + - Konrad Dybcio <konradybcio@kernel.org>
>>> +
>>> +description: |
>>> + The Venus Iris2 IP is a video encode and decode accelerator present
>>> + on Qualcomm platforms
>>> +
>>> +allOf:
>>> + - $ref: qcom,venus-common.yaml#
>>
>> Pls remove the reference to venus-common.yaml and follow schema of
>> sm8550-iris.yaml
>
> Why? For example, sm8750-iris uses venus-common.yaml.
Ack — in that case sm8750‑iris should be aligned as well.
Since Krzysztof’s patch [1] removes all venus-common references from
sm8550‑iris, all *-iris platforms should follow the same convention IMO.
[1]:
https://lore.kernel.org/linux-media/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/
Thanks,
Dikshita
>
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,sc8280xp-venus
>>> + - qcom,sm8350-venus
>>> +
>>> + clocks:
>>> + maxItems: 3
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: iface
>>> + - const: core
>>> + - const: vcodec0_core
>>> +
>>> + resets:
>>> + maxItems: 1
>>> +
>>> + reset-names:
>>> + items:
>>> + - const: core
>>
>> It should be named as bus not core
>
> Ack
>
>>
>>> +
>>> + power-domains:
>>> + maxItems: 3
>>> +
>>> + power-domain-names:
>>> + items:
>>> + - const: venus
>>> + - const: vcodec0
>>> + - const: mx
>>> +
>>> + interconnects:
>>> + maxItems: 2
>>> +
>>> + interconnect-names:
>>> + items:
>>> + - const: cpu-cfg
>>> + - const: video-mem
>>> +
>>> + operating-points-v2: true
>>> + opp-table:
>>> + type: object
>>> +
>>> + iommus:
>>> + maxItems: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - power-domain-names
>>> + - iommus
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + #include <dt-bindings/clock/qcom,gcc-sm8350.h>
>>> + #include <dt-bindings/clock/qcom,sm8350-videocc.h>
>>> + #include <dt-bindings/interconnect/qcom,icc.h>
>>> + #include <dt-bindings/interconnect/qcom,sm8350.h>
>>> + #include <dt-bindings/power/qcom-rpmpd.h>
>>> +
>>> + venus: video-codec@aa00000 {
>>> + compatible = "qcom,sm8350-venus";
>>> + reg = <0x0aa00000 0x100000>;
>>> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
>>> + <&videocc VIDEO_CC_MVS0C_CLK>,
>>> + <&videocc VIDEO_CC_MVS0_CLK>;
>>> + clock-names = "iface",
>>> + "core",
>>> + "vcodec0_core";
>>> +
>>> + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
>>> + reset-names = "core";
>>
>> s/core/bus following the existing YAML
>>
>> Thanks,
>> Dikshita
>>
>>> +
>>> + power-domains = <&videocc MVS0C_GDSC>,
>>> + <&videocc MVS0_GDSC>,
>>> + <&rpmhpd SM8350_MX>;
>>> + power-domain-names = "venus",
>>> + "vcodec0",
>>> + "mx";
>>> +
>>> + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
>>> + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
>>> + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
>>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
>>> + interconnect-names = "cpu-cfg",
>>> + "video-mem";
>>> +
>>> + operating-points-v2 = <&venus_opp_table>;
>>> + iommus = <&apps_smmu 0x2100 0x400>;
>>> + memory-region = <&pil_video_mem>;
>>> + };
>>>
>
On Mon, Feb 02, 2026 at 01:37:50PM +0530, Dikshita Agarwal wrote: > > > On 1/31/2026 1:03 PM, Dmitry Baryshkov wrote: > > On Fri, Jan 30, 2026 at 05:59:48PM +0530, Dikshita Agarwal wrote: > >> > >> > >> On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote: > >>> From: Konrad Dybcio <konradybcio@kernel.org> > >>> > >>> Both of these SoCs implement an IRIS2 block, with SC8280XP being able > >>> to clock it a bit higher and with SM8350 having 4 VPP pipes, while > >>> SC8280XP having just 2. > >>> > >>> Document Iris2 cores found on these SoCs. > >>> > >>> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> > >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > >>> [ bod: dropped dts video-encoder/video-decoder ] > >>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > >>> [db: dropped status, dropped extra LLCC interconnect] > >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > >>> --- > >>> .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++ > >>> 1 file changed, 113 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml > >>> new file mode 100644 > >>> index 000000000000..d78bdc08d830 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml > >>> @@ -0,0 +1,113 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Qualcomm SM8350 Venus video encode and decode accelerators > >> > >> s/Venus/iris > >> > >>> + > >>> +maintainers: > >>> + - Konrad Dybcio <konradybcio@kernel.org> > >>> + > >>> +description: | > >>> + The Venus Iris2 IP is a video encode and decode accelerator present > >>> + on Qualcomm platforms > >>> + > >>> +allOf: > >>> + - $ref: qcom,venus-common.yaml# > >> > >> Pls remove the reference to venus-common.yaml and follow schema of > >> sm8550-iris.yaml > > > > Why? For example, sm8750-iris uses venus-common.yaml. > > Ack — in that case sm8750‑iris should be aligned as well. > Since Krzysztof’s patch [1] removes all venus-common references from > sm8550‑iris, all *-iris platforms should follow the same convention IMO. He has been dropping references to venus-common.yaml mostly (IIUC) because of the video-firmware. With the video-firmware being moved to sc7180, the issue is no longer present. I will check if it makes sense to keep (and use) venus-common or if it makes more sense to stop using it. > > [1]: > https://lore.kernel.org/linux-media/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/ -- With best wishes Dmitry
On 2/2/2026 2:44 PM, Dmitry Baryshkov wrote: > On Mon, Feb 02, 2026 at 01:37:50PM +0530, Dikshita Agarwal wrote: >> >> >> On 1/31/2026 1:03 PM, Dmitry Baryshkov wrote: >>> On Fri, Jan 30, 2026 at 05:59:48PM +0530, Dikshita Agarwal wrote: >>>> >>>> >>>> On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote: >>>>> From: Konrad Dybcio <konradybcio@kernel.org> >>>>> >>>>> Both of these SoCs implement an IRIS2 block, with SC8280XP being able >>>>> to clock it a bit higher and with SM8350 having 4 VPP pipes, while >>>>> SC8280XP having just 2. >>>>> >>>>> Document Iris2 cores found on these SoCs. >>>>> >>>>> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> >>>>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>>>> [ bod: dropped dts video-encoder/video-decoder ] >>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>>>> [db: dropped status, dropped extra LLCC interconnect] >>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >>>>> --- >>>>> .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++ >>>>> 1 file changed, 113 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml >>>>> new file mode 100644 >>>>> index 000000000000..d78bdc08d830 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml >>>>> @@ -0,0 +1,113 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Qualcomm SM8350 Venus video encode and decode accelerators >>>> >>>> s/Venus/iris >>>> >>>>> + >>>>> +maintainers: >>>>> + - Konrad Dybcio <konradybcio@kernel.org> >>>>> + >>>>> +description: | >>>>> + The Venus Iris2 IP is a video encode and decode accelerator present >>>>> + on Qualcomm platforms >>>>> + >>>>> +allOf: >>>>> + - $ref: qcom,venus-common.yaml# >>>> >>>> Pls remove the reference to venus-common.yaml and follow schema of >>>> sm8550-iris.yaml >>> >>> Why? For example, sm8750-iris uses venus-common.yaml. >> >> Ack — in that case sm8750‑iris should be aligned as well. >> Since Krzysztof’s patch [1] removes all venus-common references from >> sm8550‑iris, all *-iris platforms should follow the same convention IMO. > > He has been dropping references to venus-common.yaml mostly (IIUC) > because of the video-firmware. With the video-firmware being moved to > sc7180, the issue is no longer present. I will check if it makes sense > to keep (and use) venus-common or if it makes more sense to stop using > it. > Ack, we should keep it consistent for all *-iris YAMLs. Thanks, Dikshita >> >> [1]: >> https://lore.kernel.org/linux-media/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/ >
On Sun, Jan 25, 2026 at 05:32:58PM +0200, Dmitry Baryshkov wrote: > From: Konrad Dybcio <konradybcio@kernel.org> > > Both of these SoCs implement an IRIS2 block, with SC8280XP being able > to clock it a bit higher and with SM8350 having 4 VPP pipes, while > SC8280XP having just 2. > > Document Iris2 cores found on these SoCs. > > Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > [ bod: dropped dts video-encoder/video-decoder ] > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > [db: dropped status, dropped extra LLCC interconnect] > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- > .../bindings/media/qcom,sm8350-venus.yaml | 113 +++++++++++++++++++++ > 1 file changed, 113 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml > new file mode 100644 > index 000000000000..d78bdc08d830 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SM8350 Venus video encode and decode accelerators > + > +maintainers: > + - Konrad Dybcio <konradybcio@kernel.org> > + > +description: | Don't need '|' > + The Venus Iris2 IP is a video encode and decode accelerator present > + on Qualcomm platforms > + > +allOf: > + - $ref: qcom,venus-common.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,sc8280xp-venus > + - qcom,sm8350-venus > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: iface > + - const: core > + - const: vcodec0_core > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: core > + > + power-domains: > + maxItems: 3 > + > + power-domain-names: > + items: > + - const: venus > + - const: vcodec0 > + - const: mx > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + items: > + - const: cpu-cfg > + - const: video-mem > + > + operating-points-v2: true blank line With that, Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > + opp-table: > + type: object
On 1/25/26 4:32 PM, Dmitry Baryshkov wrote: > From: Konrad Dybcio <konradybcio@kernel.org> > > Both of these SoCs implement an IRIS2 block, with SC8280XP being able > to clock it a bit higher and with SM8350 having 4 VPP pipes, while > SC8280XP having just 2. > > Document Iris2 cores found on these SoCs. > > Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > [ bod: dropped dts video-encoder/video-decoder ] > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > [db: dropped status, dropped extra LLCC interconnect] > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > --- [...] > +description: | > + The Venus Iris2 IP is a video encode and decode accelerator present > + on Qualcomm platforms > + > +allOf: > + - $ref: qcom,venus-common.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,sc8280xp-venus > + - qcom,sm8350-venus FYI the hardware is actually named "Iris" starting with 8150/8180 Konrad
On Mon, Jan 26, 2026 at 11:00:56AM +0100, Konrad Dybcio wrote: > On 1/25/26 4:32 PM, Dmitry Baryshkov wrote: > > From: Konrad Dybcio <konradybcio@kernel.org> > > > > Both of these SoCs implement an IRIS2 block, with SC8280XP being able > > to clock it a bit higher and with SM8350 having 4 VPP pipes, while > > SC8280XP having just 2. > > > > Document Iris2 cores found on these SoCs. > > > > Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > [ bod: dropped dts video-encoder/video-decoder ] > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > [db: dropped status, dropped extra LLCC interconnect] > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > --- > > [...] > > > +description: | > > + The Venus Iris2 IP is a video encode and decode accelerator present > > + on Qualcomm platforms > > + > > +allOf: > > + - $ref: qcom,venus-common.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,sc8280xp-venus > > + - qcom,sm8350-venus > > FYI the hardware is actually named "Iris" starting with 8150/8180 I'd prefer to continue using the name that existed in the earlier patches and which has been used for other chips in the generation. If maintainers insist, I'd switch to -iris for the next series. -- With best wishes Dmitry
On 1/26/2026 3:50 PM, Dmitry Baryshkov wrote: > On Mon, Jan 26, 2026 at 11:00:56AM +0100, Konrad Dybcio wrote: >> On 1/25/26 4:32 PM, Dmitry Baryshkov wrote: >>> From: Konrad Dybcio <konradybcio@kernel.org> >>> >>> Both of these SoCs implement an IRIS2 block, with SC8280XP being able >>> to clock it a bit higher and with SM8350 having 4 VPP pipes, while >>> SC8280XP having just 2. >>> >>> Document Iris2 cores found on these SoCs. >>> >>> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>> [ bod: dropped dts video-encoder/video-decoder ] >>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >>> [db: dropped status, dropped extra LLCC interconnect] >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >>> --- >> >> [...] >> >>> +description: | >>> + The Venus Iris2 IP is a video encode and decode accelerator present >>> + on Qualcomm platforms >>> + >>> +allOf: >>> + - $ref: qcom,venus-common.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,sc8280xp-venus >>> + - qcom,sm8350-venus >> >> FYI the hardware is actually named "Iris" starting with 8150/8180 > > I'd prefer to continue using the name that existed in the earlier > patches and which has been used for other chips in the generation. If > maintainers insist, I'd switch to -iris for the next series. > yeah, pls rename to iris, that makes more sense. Thanks, Dikshita
© 2016 - 2026 Red Hat, Inc.