This series refactors the function in rtw_mlme_ext.c to
improve readability and comply with Linux kernel coding standards.

Following feedback from Dan Carpenter, this version (v5) deconstructs
the previous changes into seven atomic patches. This separation ensures
that logical changes (such as flattening nested loops) are isolated
from purely stylistic cleanups (such as fixing indentation or NULL
checks), making the review process more straightforward and less
error-prone.

Each patch focuses on a single category of improvement:
1. Logic flattening: Use continue statements to reduce indentation.
2. Comment positioning: Adjust comments to align with new logic.
3. New lines cleanup: Removed unnecessary new lines
4. Line length compliance: Resolve 100-column limit warnings.
5. Operator spacing: Add missing spaces around logical operators.
6. Braces removal: Clean up unnecessary braces in single-line branches.
7. NULL check simplification: Use the "!ptr" convention for brevity.

---
Changes in v5:
- Split the series into 7 atomic patches for easier review.
- Renamed "guard clauses" to "continue statements" description per feedback.
- Separated logic changes, comment refactoring, and style cleanups.
- Fixed indentation issues (replaced spaces with tabs).
- Simplified NULL pointer checks to use the !ptr convention.

Changes in v4:
- Corrected the patch format by moving the changelog below the "---" line.
- Initial clean public submission of this series.


Michael Huang (7):
  staging: rtl8723bs: use continue statements to reduce indentation
  staging: rtl8723bs: refactor comments to fix the line length warning
    for exceeding 100 columns
  staging: rtl8723bs: remove unnecessary new lines
  staging: rtl8723bs: Fix the line length exceeding 100 columns warning
    in the code
  staging: rtl8723bs: add missing space around operators
  staging: rtl8723bs: remove unnecessary braces
  staging: rtl8723bs: use !ptr instead of ptr == NULL

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 129 ++++++++++--------
 1 file changed, 70 insertions(+), 59 deletions(-)

--
2.43.0

On Sat, Jan 24, 2026 at 03:15:50PM -0800, Michael Huang wrote:
> This series refactors the function in rtw_mlme_ext.c to
> improve readability and comply with Linux kernel coding standards.
> 
> Following feedback from Dan Carpenter, this version (v5) deconstructs
> the previous changes into seven atomic patches. This separation ensures
> that logical changes (such as flattening nested loops) are isolated
> from purely stylistic cleanups (such as fixing indentation or NULL
> checks), making the review process more straightforward and less
> error-prone.
> 
> Each patch focuses on a single category of improvement:
> 1. Logic flattening: Use continue statements to reduce indentation.
> 2. Comment positioning: Adjust comments to align with new logic.
> 3. New lines cleanup: Removed unnecessary new lines
> 4. Line length compliance: Resolve 100-column limit warnings.
> 5. Operator spacing: Add missing spaces around logical operators.
> 6. Braces removal: Clean up unnecessary braces in single-line branches.
> 7. NULL check simplification: Use the "!ptr" convention for brevity.
> 
> ---
> Changes in v5:
> - Split the series into 7 atomic patches for easier review.
> - Renamed "guard clauses" to "continue statements" description per feedback.
> - Separated logic changes, comment refactoring, and style cleanups.
> - Fixed indentation issues (replaced spaces with tabs).
> - Simplified NULL pointer checks to use the !ptr convention.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter