[PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()

Caio Ishikawa posted 1 patch 2 weeks ago
drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
[PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()
Posted by Caio Ishikawa 2 weeks ago
Replace calls to deprecated mipi_dsi_dcs_nop() with
mipi_dsi_dcs_nop_multi(). No intended functional changes.

Signed-off-by: Caio Ishikawa <caio.ishikawa@proton.me>
---
 drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
index f33d4f855929..01b4458e55ad 100644
--- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
+++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c
@@ -221,6 +221,7 @@ static int boe_th101mb31ig002_prepare(struct drm_panel *panel)
 						      struct boe_th101mb31ig002,
 						      panel);
 	struct device *dev = &ctx->dsi->dev;
+	struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi };
 	int ret;
 
 	ret = regulator_enable(ctx->power);
@@ -233,9 +234,9 @@ static int boe_th101mb31ig002_prepare(struct drm_panel *panel)
 		msleep(ctx->desc->vcioo_to_lp11_delay_ms);
 
 	if (ctx->desc->lp11_before_reset) {
-		ret = mipi_dsi_dcs_nop(ctx->dsi);
-		if (ret)
-			return ret;
+		mipi_dsi_dcs_nop_multi(&dsi_ctx);
+		if (dsi_ctx.accum_err)
+			return dsi_ctx.accum_err;
 	}
 
 	if (ctx->desc->lp11_to_reset_delay_ms)
-- 
2.52.0
Re: [PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()
Posted by Doug Anderson 5 days, 12 hours ago
Hi,

On Sat, Jan 24, 2026 at 4:51 AM Caio Ishikawa <caio.ishikawa@proton.me> wrote:
>
> Replace calls to deprecated mipi_dsi_dcs_nop() with
> mipi_dsi_dcs_nop_multi(). No intended functional changes.
>
> Signed-off-by: Caio Ishikawa <caio.ishikawa@proton.me>
> ---
>  drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Pushed to drm-misc-next:

[1/1] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()
      commit: 3c55330aac69150a1a4ff20684b41e7f66ad5fe9
Re: [PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()
Posted by Doug Anderson 2 weeks ago
Hi,

On Sat, Jan 24, 2026 at 4:51 AM Caio Ishikawa <caio.ishikawa@proton.me> wrote:
>
> Replace calls to deprecated mipi_dsi_dcs_nop() with
> mipi_dsi_dcs_nop_multi(). No intended functional changes.
>
> Signed-off-by: Caio Ishikawa <caio.ishikawa@proton.me>
> ---
>  drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Hmmmm, I guess we missed this one call when we moved the rest of the
driver over to the _multi() functions.

While moving this one last call over to _multi() doesn't actually help
at all with code flow / readability (arguably, it makes it slightly
worse in this case), we did agree that it would be better to move
everyone over to the "multi" variants and deprecate the non-multi
ones. I guess, if nothing else, we'll now get an error printout if the
NOP fails to send, which is an improvement.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I'll try to apply in about a week if there are no other comments and
nobody beats me to it.

-Doug