[PATCH] kho: fix doc for kho_restore_pages()

Tycho Andersen posted 1 patch 2 weeks ago
kernel/liveupdate/kexec_handover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] kho: fix doc for kho_restore_pages()
Posted by Tycho Andersen 2 weeks ago
From: "Tycho Andersen (AMD)" <tycho@kernel.org>

This function returns NULL if kho_restore_page() returns NULL, which
happens in a couple of corner cases. It never returns an error code.

Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
---
 kernel/liveupdate/kexec_handover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
index d4482b6e3cae..4c38ea7987c8 100644
--- a/kernel/liveupdate/kexec_handover.c
+++ b/kernel/liveupdate/kexec_handover.c
@@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
  * Restore a contiguous list of order 0 pages that was preserved with
  * kho_preserve_pages().
  *
- * Return: 0 on success, error code on failure
+ * Return: the first page on success, NULL on failure.
  */
 struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
 {

base-commit: c072629f05d7bca1148ab17690d7922a31423984
-- 
2.52.0
Re: [PATCH] kho: fix doc for kho_restore_pages()
Posted by Pratyush Yadav 1 week, 4 days ago
On Fri, Jan 23 2026, Tycho Andersen wrote:

> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
>
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
>
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>

Thanks.

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

[...]

-- 
Regards,
Pratyush Yadav
Re: [PATCH] kho: fix doc for kho_restore_pages()
Posted by Mike Rapoport 1 week, 5 days ago
On Fri, Jan 23, 2026 at 12:05:06PM -0700, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
> 
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
> 
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  kernel/liveupdate/kexec_handover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index d4482b6e3cae..4c38ea7987c8 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
>   * Restore a contiguous list of order 0 pages that was preserved with
>   * kho_preserve_pages().
>   *
> - * Return: 0 on success, error code on failure
> + * Return: the first page on success, NULL on failure.
>   */
>  struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
>  {
> 
> base-commit: c072629f05d7bca1148ab17690d7922a31423984
> -- 
> 2.52.0
> 

-- 
Sincerely yours,
Mike.