[PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling

Artem Shimko posted 2 patches 2 weeks ago
Only 0 patches received!
drivers/i2c/busses/i2c-designware-platdrv.c | 41 +++++++--------------
1 file changed, 13 insertions(+), 28 deletions(-)
[PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Artem Shimko 2 weeks ago
Hello maintainers and reviewers,

This series refactors the DesignWare platform I2C driver to simplify
reset control management and improve error handling:

Patch 1 replaces the manual reset control acquisition and deassertion
with devm_reset_control_get_optional_exclusive_deasserted(), which
combines both operations in a single call and leverages automatic
resource management.

Patch 2 follows up by refactoring the probe error handling to eliminate
goto statements in favor of direct returns with dev_err_probe(), resulting
in cleaner and more linear control flow.

Both patches maintain functional equivalence while improving code
readability and maintainability.

Regards,
artem

Artem Shimko (2):
  i2c: designware-platdrv: simplify reset control
  i2c: designware-platdrv: refactor error handling and simplify cleanup

 drivers/i2c/busses/i2c-designware-platdrv.c | 41 +++++++--------------
 1 file changed, 13 insertions(+), 28 deletions(-)

-- 
2.43.0
Re: [PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Andy Shevchenko 2 weeks ago
On Fri, Jan 23, 2026 at 01:05:34PM +0300, Artem Shimko wrote:
> Hello maintainers and reviewers,
> 
> This series refactors the DesignWare platform I2C driver to simplify
> reset control management and improve error handling:
> 
> Patch 1 replaces the manual reset control acquisition and deassertion
> with devm_reset_control_get_optional_exclusive_deasserted(), which
> combines both operations in a single call and leverages automatic
> resource management.
> 
> Patch 2 follows up by refactoring the probe error handling to eliminate
> goto statements in favor of direct returns with dev_err_probe(), resulting
> in cleaner and more linear control flow.
> 
> Both patches maintain functional equivalence while improving code
> readability and maintainability.

You send a series as _three_ detached emails. Forgot using

	git format-patch --thread ...

?

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Andy Shevchenko 2 weeks ago
On Fri, Jan 23, 2026 at 01:13:16PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 23, 2026 at 01:05:34PM +0300, Artem Shimko wrote:
> > Hello maintainers and reviewers,
> > 
> > This series refactors the DesignWare platform I2C driver to simplify
> > reset control management and improve error handling:
> > 
> > Patch 1 replaces the manual reset control acquisition and deassertion
> > with devm_reset_control_get_optional_exclusive_deasserted(), which
> > combines both operations in a single call and leverages automatic
> > resource management.
> > 
> > Patch 2 follows up by refactoring the probe error handling to eliminate
> > goto statements in favor of direct returns with dev_err_probe(), resulting
> > in cleaner and more linear control flow.
> > 
> > Both patches maintain functional equivalence while improving code
> > readability and maintainability.
> 
> You send a series as _three_ detached emails. Forgot using
> 
> 	git format-patch --thread ...
> 
> ?

On top of that, this is marked as v5, where the changelog for all previous
iterations?

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Artem Shimko 2 weeks ago
On Fri, Jan 23, 2026 at 2:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On top of that, this is marked as v5, where the changelog for all previous
> iterations?

Hi Andy,

Got it, yeah... Thanks!

Could you please advise, should I send it again with changelog as v6?

Regards,
artem
Re: [PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Andy Shevchenko 2 weeks ago
On Fri, Jan 23, 2026 at 02:35:44PM +0300, Artem Shimko wrote:
> On Fri, Jan 23, 2026 at 2:14 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On top of that, this is marked as v5, where the changelog for all previous
> > iterations?
> 
> Got it, yeah... Thanks!
> 
> Could you please advise, should I send it again with changelog as v6?

Wait a bit (24h + ) for others to have a chance to comment.

-- 
With Best Regards,
Andy Shevchenko


Re: [PATCH v5 0/2] i2c: designware-platdrv: simplify reset control and error handling
Posted by Artem Shimko 2 weeks ago
On Fri, Jan 23, 2026 at 5:10 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Wait a bit (24h + ) for others to have a chance to comment.

Got it, thanks. =)