extend bit width in the flow director of HNS3 driver

[PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver

Posted by Jijie Shao 2 weeks, 2 days ago

The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
increased to support higher specifications.

Note: The hardware already supports the specifications.

Jijie Shao (2):
  net: hns3: extend HCLGE_FD_AD_QID to 11 bits
  net: hns3: extend HCLGE_FD_AD_COUNTER_NUM to 8 bits

 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h    | 11 +++++++----
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c   | 11 ++++++++---
 2 files changed, 15 insertions(+), 7 deletions(-)

-- 
2.33.0

Re: [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver

Posted by Simon Horman 1 week, 5 days ago

On Fri, Jan 23, 2026 at 05:47:54PM +0800, Jijie Shao wrote:
> The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
> increased to support higher specifications.
> 
> Note: The hardware already supports the specifications.

Hi Jijie,

Are there any compatibility issues here?
E.g. new driver with old hardware or firmware?

Re: [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver

Posted by Jijie Shao 1 week, 5 days ago

on 2026/1/26 22:03, Simon Horman wrote:
> On Fri, Jan 23, 2026 at 05:47:54PM +0800, Jijie Shao wrote:
>> The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
>> increased to support higher specifications.
>>
>> Note: The hardware already supports the specifications.
> Hi Jijie,
>
> Are there any compatibility issues here?
> E.g. new driver with old hardware or firmware?

Thank you, There are no compatibility issues.

The chip and firmware are supported in V2.
However, the software does not support the extension due to
consistency with older versions(and the customer has not used the extended bits either).

The queue_cnt and counter_cnt specifications of the software are directly or indirectly
queried from the firmware, and the extended bits are not used in the V1 version.

Thanks,
Jijie Shao

Re: [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver

Posted by Simon Horman 1 week, 5 days ago

On Tue, Jan 27, 2026 at 09:50:21AM +0800, Jijie Shao wrote:
> 
> on 2026/1/26 22:03, Simon Horman wrote:
> > On Fri, Jan 23, 2026 at 05:47:54PM +0800, Jijie Shao wrote:
> > > The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
> > > increased to support higher specifications.
> > > 
> > > Note: The hardware already supports the specifications.
> > Hi Jijie,
> > 
> > Are there any compatibility issues here?
> > E.g. new driver with old hardware or firmware?
> 
> Thank you, There are no compatibility issues.
> 
> The chip and firmware are supported in V2.
> However, the software does not support the extension due to
> consistency with older versions(and the customer has not used the extended bits either).
> 
> The queue_cnt and counter_cnt specifications of the software are directly
> or indirectly queried from the firmware, and the extended bits are not
> used in the V1 version.
> 

Thanks, I think that addresses my concern.

The code changes themselves look good to me.
So, for the series:

Reviewed-by: Simon Horman <horms@kernel.org>