Add iMX95 neoisp driver

[RFC v1 05/11] dt-bindings: media: Add nxp neoisp support

Posted by Antoine Bouyer 2 weeks, 3 days ago

Add dt-bindings for NXP neoisp module.

Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
---
 .../devicetree/bindings/media/nxp,neoisp.yaml | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/nxp,neoisp.yaml

diff --git a/Documentation/devicetree/bindings/media/nxp,neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
new file mode 100644
index 000000000000..4dc9fa5a03b7
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/nxp,neoisp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP NEOISP Image Signal Processing Pipeline
+
+maintainers:
+  - Antoine Bouyer <antoine.bouyer@nxp.com>
+
+description:
+  The NXP NEOISP performs a set of image processing tasks on the RAW camera
+  stream and provides RGB or YUV enhanced image.
+
+properties:
+  compatible:
+    enum:
+      - nxp,neoisp
+      - nxp,imx95-a0-neoisp
+      - nxp,imx95-a1-neoisp
+      - nxp,imx95-b0-neoisp
+
+  reg:
+    items:
+      - description: The configuration registers
+      - description: ISP local memories
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+
+  clock-names:
+    items:
+      - const: camcm0
+
+  power-domains:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - power-domains
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    isp@4ae00000 {
+      compatible = "nxp,neoisp";
+      reg = <0x4ae00000 0x8000>,
+            <0x4afe0000 0x10000>;
+      interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
+      interrupt-parent = <&gic>;
+      clocks = <&scmi_clk 64>; /* IMX95_CLK_CAMCM0 */
+      clock-names = "camcm0";
+      power-domains = <&scmi_devpd 3>; /* IMX95_PD_CAMERA */
+    };
-- 
2.52.0

Re: [RFC v1 05/11] dt-bindings: media: Add nxp neoisp support

Posted by Krzysztof Kozlowski 4 days, 4 hours ago

On 23/01/2026 09:09, Antoine Bouyer wrote:
> Add dt-bindings for NXP neoisp module.

What is a neoisp module?


> 
> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
> ---
>  .../devicetree/bindings/media/nxp,neoisp.yaml | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/nxp,neoisp.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
> new file mode 100644
> index 000000000000..4dc9fa5a03b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nxp,neoisp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP NEOISP Image Signal Processing Pipeline
> +
> +maintainers:
> +  - Antoine Bouyer <antoine.bouyer@nxp.com>
> +
> +description:
> +  The NXP NEOISP performs a set of image processing tasks on the RAW camera
> +  stream and provides RGB or YUV enhanced image.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,neoisp

Please read writing bindings document.

> +      - nxp,imx95-a0-neoisp
> +      - nxp,imx95-a1-neoisp
> +      - nxp,imx95-b0-neoisp

Nothing explains me why one SoC has three neoisp. You have entire commit
msg to explain weird things.

> +
> +  reg:
> +    items:
> +      - description: The configuration registers
> +      - description: ISP local memories
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1

maxItems. There is no such syntax like you wrote. Look at other code in
case of doubts.


> +
> +  clock-names:
> +    items:
> +      - const: camcm0
> +
> +  power-domains:
> +    maxItems: 1
> +
Best regards,
Krzysztof

Re: [RFC v1 05/11] dt-bindings: media: Add nxp neoisp support

Posted by Frank Li 1 week, 6 days ago

On Fri, Jan 23, 2026 at 09:09:32AM +0100, Antoine Bouyer wrote:
> Add dt-bindings for NXP neoisp module.
>
> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
> ---
>  .../devicetree/bindings/media/nxp,neoisp.yaml | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/nxp,neoisp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
> new file mode 100644
> index 000000000000..4dc9fa5a03b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nxp,neoisp.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nxp,neoisp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP NEOISP Image Signal Processing Pipeline
> +
> +maintainers:
> +  - Antoine Bouyer <antoine.bouyer@nxp.com>
> +
> +description:
> +  The NXP NEOISP performs a set of image processing tasks on the RAW camera
> +  stream and provides RGB or YUV enhanced image.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,neoisp

Don't allow use generally name for compatible string.

One option
	nxp,neoisp-<version number>, or use below one as fallback,

oneOf:
  -  items:
       - enum
          - nxp,imx95-b0-neoisp
          - nxp,imx95-a1-neoisp
        - const: nxp,imx95-a0-neoisp
  - const: nxp,imx95-a0-neoisp

Frank
> +      - nxp,imx95-a0-neoisp
> +      - nxp,imx95-a1-neoisp
> +      - nxp,imx95-b0-neoisp
> +
> +  reg:
> +    items:
> +      - description: The configuration registers
> +      - description: ISP local memories
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: camcm0
> +
> +  power-domains:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - power-domains
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    isp@4ae00000 {
> +      compatible = "nxp,neoisp";
> +      reg = <0x4ae00000 0x8000>,
> +            <0x4afe0000 0x10000>;
> +      interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> +      interrupt-parent = <&gic>;
> +      clocks = <&scmi_clk 64>; /* IMX95_CLK_CAMCM0 */
> +      clock-names = "camcm0";
> +      power-domains = <&scmi_devpd 3>; /* IMX95_PD_CAMERA */
> +    };
> --
> 2.52.0
>