[PATCH v4 0/5] i2c: xiic: use generic device property accessors

Abdurrahman Hussain via B4 Relay posted 5 patches 2 weeks ago
There is a newer version of this series
drivers/i2c/busses/i2c-xiic.c | 83 ++++++++++++++++++-------------------------
1 file changed, 35 insertions(+), 48 deletions(-)
[PATCH v4 0/5] i2c: xiic: use generic device property accessors
Posted by Abdurrahman Hussain via B4 Relay 2 weeks ago
Switch to generic device property accessors.

Switch to managed devm_ functions to simplify error handling.

Make the clock optional since the driver is designed to operate without
explicit configuration in firmware thus making it useful on platforms
where clock is not or cannot be provided.

Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
Changes in v4:
- Reorder the cosmetic patch to be the first in the series.
- Amend the mutex_init patch to also switch to the managed pm_runtime_
  variant.
- Link to v3: https://lore.kernel.org/r/20260123-i2c-xiic-v3-0-eb7cd4254dfb@nexthop.ai

Changes in v3:
- Reorder the "optional clock" patch to be the first in the series. 
- Add a patch to switch to devm_mutex_init().
- Remove dup message in error path.
- Cosmetic: use temporary dev variable.
- Link to v2: https://lore.kernel.org/r/20260122-i2c-xiic-v2-0-134f5d743e8b@nexthop.ai

Changes in v2:
- Split the patch into two independent changes.
- Added struct device *dev at the top of probe() and remove() to re-use.
- Switched to device_set_node(...)

---
Abdurrahman Hussain (5):
      i2c: xiic: minor cosmetic cleanup
      i2c: xiic: make the clock optional
      i2c: xiic: switch to devm_ managed apis to simplify the error code paths
      i2c: xiic: remove duplicate error message
      i2c: xiic: switch to generic device property accessors

 drivers/i2c/busses/i2c-xiic.c | 83 ++++++++++++++++++-------------------------
 1 file changed, 35 insertions(+), 48 deletions(-)
---
base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
change-id: 20260122-i2c-xiic-3ba89ff5ea93

Best regards,
-- 
Abdurrahman Hussain <abdurrahman@nexthop.ai>
Re: [PATCH v4 0/5] i2c: xiic: use generic device property accessors
Posted by Andy Shevchenko 2 weeks ago
On Fri, Jan 23, 2026 at 04:34:13PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Switch to generic device property accessors.
> 
> Switch to managed devm_ functions to simplify error handling.
> 
> Make the clock optional since the driver is designed to operate without
> explicit configuration in firmware thus making it useful on platforms
> where clock is not or cannot be provided.

...

> Changes in v4:
> - Reorder the cosmetic patch to be the first in the series.

No. that's not what I meant. I meant that the line that adds a temporary
variable should be moved from the last patch to the first one. The order
of the _patches_ was fine, now it's broken again.

Take your time and try to play with the patches locally to see my point.

Next week v5 would be nice to have that addresses my point.

> - Amend the mutex_init patch to also switch to the managed pm_runtime_
>   variant.

-- 
With Best Regards,
Andy Shevchenko