[PATCH v3 0/5] i2c: xiic: use generic device property accessors

Abdurrahman Hussain via B4 Relay posted 5 patches 2 weeks ago
There is a newer version of this series
drivers/i2c/busses/i2c-xiic.c | 74 ++++++++++++++++++++-----------------------
1 file changed, 35 insertions(+), 39 deletions(-)
[PATCH v3 0/5] i2c: xiic: use generic device property accessors
Posted by Abdurrahman Hussain via B4 Relay 2 weeks ago
Switch to generic device property accessors and make minor code
refactoring.

Make the clock optional since the driver is designed to operate without
explicit configuration in firmware thus making it useful on platforms
where clock is not or cannot be provided.

Changed in v2:

* Split the patch into two independent changes.
* Added struct device *dev at the top of probe() and remove() to re-use.
* Switched to device_set_node(...)

Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
Changes in v3:
- Reorder the "optional clock" patch to be the first in the series. 
- Add a patch to switch to devm_mutex_init().
- Remove dup message in error path.
- Cosmetic: use temporary dev variable.
- Link to v2: https://lore.kernel.org/r/20260122-i2c-xiic-v2-0-134f5d743e8b@nexthop.ai

---
Abdurrahman Hussain (5):
      i2c: xiic: make the clock optional
      i2c: xiic: switch to managed version of mutex_init
      i2c: xiic: remove duplicate error message
      i2c: xiic: switch to generic device property accessors
      i2c: xiic: minor cosmetic cleanup

 drivers/i2c/busses/i2c-xiic.c | 74 ++++++++++++++++++++-----------------------
 1 file changed, 35 insertions(+), 39 deletions(-)
---
base-commit: 944aacb68baf7624ab8d277d0ebf07f025ca137c
change-id: 20260122-i2c-xiic-3ba89ff5ea93

Best regards,
-- 
Abdurrahman Hussain <abdurrahman@nexthop.ai>
Re: [PATCH v3 0/5] i2c: xiic: use generic device property accessors
Posted by Andy Shevchenko 2 weeks ago
On Fri, Jan 23, 2026 at 08:02:43AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Switch to generic device property accessors and make minor code
> refactoring.
> 
> Make the clock optional since the driver is designed to operate without
> explicit configuration in firmware thus making it useful on platforms
> where clock is not or cannot be provided.

Everything looks fine in the result, but one nuance ruins the series.
See my other comments. After fixing it and rebasing I will give you a tag.

-- 
With Best Regards,
Andy Shevchenko