In vexpress_syscfg_probe(), of_parse_phandle() is called inside a loop
but the returned device_node reference is never released.
Fix this by using the __free(device_node) cleanup handler to automatically
release the reference when the variable goes out of scope.
Fixes: a5a38765ac79b ("bus: vexpress-config: simplify config bus probing")
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
Changes in v2:
- Remove redundant header file.
- Add Acked-by from Liviu.
- Link to v1: https://lore.kernel.org/r/20260122-b4-vexpress-config-v1-1-3f0c85bc4730@gmail.com
---
drivers/bus/vexpress-config.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index 64ee920721ee..c1a7aa63f288 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -390,9 +390,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
}
for_each_compatible_node(node, NULL, "arm,vexpress,config-bus") {
- struct device_node *bridge_np;
-
- bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
+ struct device_node *bridge_np __free(device_node) =
+ of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
if (bridge_np != pdev->dev.parent->of_node)
continue;
---
base-commit: 053966c344dbd346e71305f530e91ea77916189f
change-id: 20260122-b4-vexpress-config-1d2051861d93
Best regards,
--
Felix Gu <ustc.gu@gmail.com>