arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
The AT25 EEPROM node on the Northstar 2 SVK board used legacy vendor
properties and a non-standard node name, which triggers dtbs_check
warnings.
Update the node to follow the dt-schema by:
- Renaming the node from at25@0 to eeprom@0.
- Replacing deprecated "at25,byte-len" with "size".
- Replacing deprecated "at25,page-size" with "pagesize".
- Replacing deprecated "at25,addr-mode" with "address-width".
For "address-width", the legacy value <2> corresponds to the EE_ADDR2
flag in the driver (include/linux/spi/eeprom.h), which is explicitly
defined as 16-bit addressing. Therefore, <16> is the technically
accurate value that preserves the existing hardware behavior while
satisfying the at25.yaml schema requirements.
Signed-off-by: Lee Yongjun <jun85566@gmail.com>
---
arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
index 5939d342aec7..c4412c6b4cef 100644
--- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
+++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
@@ -127,13 +127,13 @@ slic@0 {
&ssp1 {
status = "okay";
- at25@0 {
+ eeprom@0 {
compatible = "atmel,at25";
reg = <0>;
spi-max-frequency = <5000000>;
- at25,byte-len = <0x8000>;
- at25,addr-mode = <2>;
- at25,page-size = <64>;
+ size = <0x8000>;
+ address-width = <16>;
+ pagesize = <64>;
spi-cpha;
spi-cpol;
pl022,interface = <0>;
--
2.34.1
On 1/22/26 08:18, Lee Yongjun wrote: > The AT25 EEPROM node on the Northstar 2 SVK board used legacy vendor > properties and a non-standard node name, which triggers dtbs_check > warnings. > > Update the node to follow the dt-schema by: > - Renaming the node from at25@0 to eeprom@0. > - Replacing deprecated "at25,byte-len" with "size". > - Replacing deprecated "at25,page-size" with "pagesize". > - Replacing deprecated "at25,addr-mode" with "address-width". > > For "address-width", the legacy value <2> corresponds to the EE_ADDR2 > flag in the driver (include/linux/spi/eeprom.h), which is explicitly > defined as 16-bit addressing. Therefore, <16> is the technically > accurate value that preserves the existing hardware behavior while > satisfying the at25.yaml schema requirements. > > Signed-off-by: Lee Yongjun <jun85566@gmail.com> Thanks for your patch, however I have something from Rob already queued up: https://lore.kernel.org/r/20260106-dt-dtbs-broadcom-fixes-v1-9-ba45874e4553@kernel.org You could re-submit the portion of your patch that renames the node? -- Florian
© 2016 - 2026 Red Hat, Inc.