1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC
  4. View patch

[PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes

Pritam Manohar Sutar posted 3 patches 2 weeks, 4 days ago
[PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Pritam Manohar Sutar 2 weeks, 4 days ago 
Enable USB PHY and DWC3 USB controllers' nodes.

Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
 .../boot/dts/exynos/exynosautov920-sadk.dts   | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
index f90f7704597c..5896dd69334a 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
@@ -160,15 +160,20 @@ &xtcxo {
 &usbdrd31_ssphy {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd31_hsphy {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd31_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+	role-switch-default-mode = "peripheral";
 	maximum-speed = "super-speed-plus";
 	usb-phy = <&usb_phy0>;
 };
@@ -176,15 +181,20 @@ &usbdrd31_dwc3 {
 &usbdrd31 {
 	vdd10-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_phy0 {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_dwc3_0 {
+	dr_mode = "otg";
+	usb-role-switch;
+	role-switch-default-mode = "peripheral";
 	maximum-speed = "high-speed";
 	usb-phy = <&usb_phy1>;
 };
@@ -192,15 +202,20 @@ &usbdrd20_dwc3_0 {
 &usbdrd20_0 {
 	vdd10-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_phy1 {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_dwc3_1 {
+	dr_mode = "otg";
+	usb-role-switch;
+	role-switch-default-mode = "peripheral";
 	maximum-speed = "high-speed";
 	usb-phy = <&usb_phy2>;
 };
@@ -208,15 +223,20 @@ &usbdrd20_dwc3_1 {
 &usbdrd20_1 {
 	vdd10-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_phy2 {
 	dvdd-supply = <&dummy_regulator>;
 	vdd18-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
 
 &usbdrd20_dwc3_2 {
+	dr_mode = "otg";
+	usb-role-switch;
+	role-switch-default-mode = "peripheral";
 	maximum-speed = "high-speed";
 	usb-phy = <&usb_phy3>;
 };
@@ -224,4 +244,5 @@ &usbdrd20_dwc3_2 {
 &usbdrd20_2 {
 	vdd10-supply = <&dummy_regulator>;
 	vdd33-supply = <&dummy_regulator>;
+	status = "okay";
 };
-- 
2.34.1
Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Krzysztof Kozlowski 2 weeks, 4 days ago 
On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> Enable USB PHY and DWC3 USB controllers' nodes.
> 
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index f90f7704597c..5896dd69334a 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -160,15 +160,20 @@ &xtcxo {
>  &usbdrd31_ssphy {
>  	dvdd-supply = <&dummy_regulator>;
>  	vdd18-supply = <&dummy_regulator>;
> +	status = "okay";

You just added the node in the previous patch, so why it cant be enavled
there?

>  };
>  
>  &usbdrd31_hsphy {
>  	dvdd-supply = <&dummy_regulator>;
>  	vdd18-supply = <&dummy_regulator>;
>  	vdd33-supply = <&dummy_regulator>;
> +	status = "okay";
>  };
>  
>  &usbdrd31_dwc3 {
> +	dr_mode = "otg";
> +	usb-role-switch;
> +	role-switch-default-mode = "peripheral";

Why did you add incomplete node in previous commit?


Best regards,
Krzysztof
RE: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Pritam Manohar Sutar 2 weeks, 3 days ago 
Hi Krzysztof,

Thank you for your feedback. 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 22 January 2026 07:05 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
> nodes
> 
> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> > Enable USB PHY and DWC3 USB controllers' nodes.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> > ---
> >  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
> +++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > index f90f7704597c..5896dd69334a 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > @@ -160,15 +160,20 @@ &xtcxo {
> >  &usbdrd31_ssphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> > +	status = "okay";
> 
> You just added the node in the previous patch, so why it cant be enavled
> there?
> 
> >  };
> >
> >  &usbdrd31_hsphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> >  	vdd33-supply = <&dummy_regulator>;
> > +	status = "okay";
> >  };
> >
> >  &usbdrd31_dwc3 {
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +	role-switch-default-mode = "peripheral";
> 
> Why did you add incomplete node in previous commit?

The commit was added to align with the existing convention of separating 
node addition and enabling logic in USB configurations. This approach is 
referenced from commits such as:

https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f73d1b0@mentallysanemainliners.org/
https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@linaro.org/

Please let me know if this commit to be merged in previous commit.

> 
> 
> Best regards,
> Krzysztof

Regards,
Pritam
Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Krzysztof Kozlowski 1 week, 5 days ago 
On 23/01/2026 08:59, Pritam Manohar Sutar wrote:
> Hi Krzysztof,
> 
> Thank you for your feedback. 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 22 January 2026 07:05 PM
>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; robh@kernel.org;
>> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> rosa.pila@samsung.com; dev.tailor@samsung.com;
>> faraz.ata@samsung.com; muhammed.ali@samsung.com;
>> selvarasu.g@samsung.com
>> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
>> nodes
>>
>> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
>>> Enable USB PHY and DWC3 USB controllers' nodes.
>>>
>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
>>> ---
>>>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
>> +++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> index f90f7704597c..5896dd69334a 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> @@ -160,15 +160,20 @@ &xtcxo {
>>>  &usbdrd31_ssphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>
>> You just added the node in the previous patch, so why it cant be enavled
>> there?
>>
>>>  };
>>>
>>>  &usbdrd31_hsphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>>  	vdd33-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>>  };
>>>
>>>  &usbdrd31_dwc3 {
>>> +	dr_mode = "otg";
>>> +	usb-role-switch;
>>> +	role-switch-default-mode = "peripheral";
>>
>> Why did you add incomplete node in previous commit?
> 
> The commit was added to align with the existing convention of separating 
> node addition and enabling logic in USB configurations. This approach is 
> referenced from commits such as:
> 
> https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f73d1b0@mentallysanemainliners.org/
> https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@linaro.org/
> 
> Please let me know if this commit to be merged in previous commit.


BTW, don't ever use AI to write code or code justifications. I will make
note of it.

Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Krzysztof Kozlowski 2 weeks, 3 days ago 
On 23/01/2026 08:59, Pritam Manohar Sutar wrote:
> Hi Krzysztof,
> 
> Thank you for your feedback. 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 22 January 2026 07:05 PM
>> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; robh@kernel.org;
>> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> rosa.pila@samsung.com; dev.tailor@samsung.com;
>> faraz.ata@samsung.com; muhammed.ali@samsung.com;
>> selvarasu.g@samsung.com
>> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
>> nodes
>>
>> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
>>> Enable USB PHY and DWC3 USB controllers' nodes.
>>>
>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
>>> ---
>>>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
>> +++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> index f90f7704597c..5896dd69334a 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> @@ -160,15 +160,20 @@ &xtcxo {
>>>  &usbdrd31_ssphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>
>> You just added the node in the previous patch, so why it cant be enavled
>> there?
>>
>>>  };
>>>
>>>  &usbdrd31_hsphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>>  	vdd33-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>>  };
>>>
>>>  &usbdrd31_dwc3 {
>>> +	dr_mode = "otg";
>>> +	usb-role-switch;
>>> +	role-switch-default-mode = "peripheral";
>>
>> Why did you add incomplete node in previous commit?
> 
> The commit was added to align with the existing convention of separating 
> node addition and enabling logic in USB configurations. This approach is 

There was never such convention for Qualcomm or Samsung. Do not make up
fake conventions.

> referenced from commits such as:

No, it is not.

> 
> https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f73d1b0@mentallysanemainliners.org/
> https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@linaro.org/

Just look at these commits - they add complete node override to DTS. Not
half node now and half node later to the DTS file!

> 
> Please let me know if this commit to be merged in previous commit.

Just look at the commits there.

> 


Best regards,
Krzysztof
RE: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Posted by Pritam Manohar Sutar 2 weeks, 3 days ago 
Hi 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 22 January 2026 07:05 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org;
> rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
> nodes
> 
> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> > Enable USB PHY and DWC3 USB controllers' nodes.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> > ---
> >  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
> +++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > index f90f7704597c..5896dd69334a 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > @@ -160,15 +160,20 @@ &xtcxo {
> >  &usbdrd31_ssphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> > +	status = "okay";
> 
> You just added the node in the previous patch, so why it cant be enavled
> there?
> 
> >  };
> >
> >  &usbdrd31_hsphy {
> >  	dvdd-supply = <&dummy_regulator>;
> >  	vdd18-supply = <&dummy_regulator>;
> >  	vdd33-supply = <&dummy_regulator>;
> > +	status = "okay";
> >  };
> >
> >  &usbdrd31_dwc3 {
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +	role-switch-default-mode = "peripheral";
> 
> Why did you add incomplete node in previous commit?
> 
> 
> Best regards,
> Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.