dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

[PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

Posted by Lukasz Majewski 2 weeks, 2 days ago

This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
macros definitions for L2 switch.

Those definitions describe clocks for MoreThanIP switch IP block;
the switch itself and the MAC address lookup table clocks.

Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
---
 include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/vf610-clock.h b/include/dt-bindings/clock/vf610-clock.h
index 373644e46747..b6f7b1745cc2 100644
--- a/include/dt-bindings/clock/vf610-clock.h
+++ b/include/dt-bindings/clock/vf610-clock.h
@@ -197,6 +197,11 @@
 #define VF610_CLK_TCON1			188
 #define VF610_CLK_CAAM			189
 #define VF610_CLK_CRC			190
-#define VF610_CLK_END			191
+#define VF610_CLK_ESW			191
+#define VF610_CLK_ESW_MAC_TAB0		192
+#define VF610_CLK_ESW_MAC_TAB1		193
+#define VF610_CLK_ESW_MAC_TAB2		194
+#define VF610_CLK_ESW_MAC_TAB3		195
+#define VF610_CLK_END			196
 
 #endif /* __DT_BINDINGS_CLOCK_VF610_H */
-- 
2.39.5

Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

Posted by Conor Dooley 2 weeks, 1 day ago

On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote:
> This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
> macros definitions for L2 switch.
> 
> Those definitions describe clocks for MoreThanIP switch IP block;
> the switch itself and the MAC address lookup table clocks.
> 
> Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> ---
>  include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/vf610-clock.h b/include/dt-bindings/clock/vf610-clock.h
> index 373644e46747..b6f7b1745cc2 100644
> --- a/include/dt-bindings/clock/vf610-clock.h
> +++ b/include/dt-bindings/clock/vf610-clock.h
> @@ -197,6 +197,11 @@
>  #define VF610_CLK_TCON1			188
>  #define VF610_CLK_CAAM			189
>  #define VF610_CLK_CRC			190
> -#define VF610_CLK_END			191

If end is modifiable, it is removable. If you need the define for the
driver, please move it there.

pw-bot: changes-requested

> +#define VF610_CLK_ESW			191
> +#define VF610_CLK_ESW_MAC_TAB0		192
> +#define VF610_CLK_ESW_MAC_TAB1		193
> +#define VF610_CLK_ESW_MAC_TAB2		194
> +#define VF610_CLK_ESW_MAC_TAB3		195
> +#define VF610_CLK_END			196
>  
>  #endif /* __DT_BINDINGS_CLOCK_VF610_H */
> -- 
> 2.39.5
>

Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

Posted by Łukasz Majewski 2 weeks, 1 day ago

Hi Conor,

> On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote:
> > This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
> > macros definitions for L2 switch.
> > 
> > Those definitions describe clocks for MoreThanIP switch IP block;
> > the switch itself and the MAC address lookup table clocks.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > ---
> >  include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/dt-bindings/clock/vf610-clock.h
> > b/include/dt-bindings/clock/vf610-clock.h index
> > 373644e46747..b6f7b1745cc2 100644 ---
> > a/include/dt-bindings/clock/vf610-clock.h +++
> > b/include/dt-bindings/clock/vf610-clock.h @@ -197,6 +197,11 @@
> >  #define VF610_CLK_TCON1			188
> >  #define VF610_CLK_CAAM			189
> >  #define VF610_CLK_CRC			190
> > -#define VF610_CLK_END			191  
> 
> If end is modifiable, it is removable. If you need the define for the
> driver, please move it there.

Could you be more specific regarding your comment?

The VF610_CLK_END has now value 191.

However, there are other clocks in this SoC - like CLK_ESW and
CLK_MAC_TAB{x} - which were not taken into account earlier.

What shall be done?

Shall I remove the VF610_CLK_END entirely?

Or move to the new "end" (as done with this patch)?

> 
> pw-bot: changes-requested
> 
> > +#define VF610_CLK_ESW			191
> > +#define VF610_CLK_ESW_MAC_TAB0		192
> > +#define VF610_CLK_ESW_MAC_TAB1		193
> > +#define VF610_CLK_ESW_MAC_TAB2		194
> > +#define VF610_CLK_ESW_MAC_TAB3		195
> > +#define VF610_CLK_END			196
> >  
> >  #endif /* __DT_BINDINGS_CLOCK_VF610_H */
> > -- 
> > 2.39.5
> >   


-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic

Re: [PATCH] dt-bindings: clock: vf610: Add definitions for MTIP L2 switch

Posted by Conor Dooley 2 weeks, 1 day ago

On Thu, Jan 22, 2026 at 08:26:03PM +0100, Łukasz Majewski wrote:
> Hi Conor,
> 
> > On Thu, Jan 22, 2026 at 01:58:38PM +0100, Lukasz Majewski wrote:
> > > This patch adds VF610_CLK_ESW and VF610_CLK_ESW_MAC_TAB{0123}
> > > macros definitions for L2 switch.
> > > 
> > > Those definitions describe clocks for MoreThanIP switch IP block;
> > > the switch itself and the MAC address lookup table clocks.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > > ---
> > >  include/dt-bindings/clock/vf610-clock.h | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/include/dt-bindings/clock/vf610-clock.h
> > > b/include/dt-bindings/clock/vf610-clock.h index
> > > 373644e46747..b6f7b1745cc2 100644 ---
> > > a/include/dt-bindings/clock/vf610-clock.h +++
> > > b/include/dt-bindings/clock/vf610-clock.h @@ -197,6 +197,11 @@
> > >  #define VF610_CLK_TCON1			188
> > >  #define VF610_CLK_CAAM			189
> > >  #define VF610_CLK_CRC			190
> > > -#define VF610_CLK_END			191  
> > 
> > If end is modifiable, it is removable. If you need the define for the
> > driver, please move it there.
> 
> Could you be more specific regarding your comment?

Values in bindings are immutable, so changing a definition is an ABI
break. If you can break the ABI for this definition, then you should
just remove it instead, because it doesn't represent a clock and it is
liable to change when you information comes to light (e.g. this patch).

> The VF610_CLK_END has now value 191.
> 
> However, there are other clocks in this SoC - like CLK_ESW and
> CLK_MAC_TAB{x} - which were not taken into account earlier.
> 
> What shall be done?
> 
> Shall I remove the VF610_CLK_END entirely?
> 
> Or move to the new "end" (as done with this patch)?

If you need VF610_CLK_END for your driver, rather than just using
(VF610_CLK_ESW_MAC_TAB + 1), please move the definition there.