[PATCH] loongarch/kgdb: use IS_ERR_PCPU() macro

Carlos López posted 1 patch 2 weeks, 2 days ago
arch/loongarch/kernel/kgdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] loongarch/kgdb: use IS_ERR_PCPU() macro
Posted by Carlos López 2 weeks, 2 days ago
In a759e37fb467 ("err.h: add ERR_PTR_PCPU(), PTR_ERR_PCPU() and
IS_ERR_PCPU() macros"), specialized macros were added to check an error
within a __percpu pointer, so use them instead of manually casting
with __force, like all other users of register_wide_hw_breakpoint().

Signed-off-by: Carlos López <clopez@suse.de>
---
 arch/loongarch/kernel/kgdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c
index 7be5b4c0c900..17664a6043b1 100644
--- a/arch/loongarch/kernel/kgdb.c
+++ b/arch/loongarch/kernel/kgdb.c
@@ -697,7 +697,7 @@ void kgdb_arch_late(void)
 			continue;
 
 		breakinfo[i].pev = register_wide_hw_breakpoint(&attr, NULL, NULL);
-		if (IS_ERR((void * __force)breakinfo[i].pev)) {
+		if (IS_ERR_PCPU(breakinfo[i].pev)) {
 			pr_err("kgdb: Could not allocate hw breakpoints.\n");
 			breakinfo[i].pev = NULL;
 			return;

base-commit: a66191c590b3b58eaff05d2277971f854772bd5b
-- 
2.51.0

Re: [PATCH] loongarch/kgdb: use IS_ERR_PCPU() macro
Posted by Huacai Chen 1 week, 6 days ago
Applied, thanks.

Huacai

On Thu, Jan 22, 2026 at 6:57 PM Carlos López <clopez@suse.de> wrote:
>
> In a759e37fb467 ("err.h: add ERR_PTR_PCPU(), PTR_ERR_PCPU() and
> IS_ERR_PCPU() macros"), specialized macros were added to check an error
> within a __percpu pointer, so use them instead of manually casting
> with __force, like all other users of register_wide_hw_breakpoint().
>
> Signed-off-by: Carlos López <clopez@suse.de>
> ---
>  arch/loongarch/kernel/kgdb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c
> index 7be5b4c0c900..17664a6043b1 100644
> --- a/arch/loongarch/kernel/kgdb.c
> +++ b/arch/loongarch/kernel/kgdb.c
> @@ -697,7 +697,7 @@ void kgdb_arch_late(void)
>                         continue;
>
>                 breakinfo[i].pev = register_wide_hw_breakpoint(&attr, NULL, NULL);
> -               if (IS_ERR((void * __force)breakinfo[i].pev)) {
> +               if (IS_ERR_PCPU(breakinfo[i].pev)) {
>                         pr_err("kgdb: Could not allocate hw breakpoints.\n");
>                         breakinfo[i].pev = NULL;
>                         return;
>
> base-commit: a66191c590b3b58eaff05d2277971f854772bd5b
> --
> 2.51.0
>