[PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define

Gabor Juhos posted 2 patches 2 weeks, 3 days ago
[PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
Posted by Gabor Juhos 2 weeks, 3 days ago
The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
with the exact same value.

  $ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
  drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE    0x007a484b
  include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE                               0x007a484b

Drop the local define to avoid the duplication.

No functional changes intended. Compile tested only.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
 drivers/interconnect/qcom/smd-rpm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/interconnect/qcom/smd-rpm.c b/drivers/interconnect/qcom/smd-rpm.c
index 8316c87a2c60f5f99edece3443cc60e9e75fa11f..dbc7ae50b02b7948217c856e3b1bee53c56f46e3 100644
--- a/drivers/interconnect/qcom/smd-rpm.c
+++ b/drivers/interconnect/qcom/smd-rpm.c
@@ -14,7 +14,6 @@
 #include "icc-rpm.h"
 
 #define RPM_KEY_BW		0x00007762
-#define QCOM_RPM_SMD_KEY_RATE	0x007a484b
 
 static struct qcom_smd_rpm *icc_smd_rpm;
 

-- 
2.52.0
Re: [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
Posted by Dmitry Baryshkov 2 weeks, 3 days ago
On Thu, Jan 22, 2026 at 08:34:22PM +0100, Gabor Juhos wrote:
> The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
> with the exact same value.
> 
>   $ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
>   drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE    0x007a484b
>   include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE                               0x007a484b
> 
> Drop the local define to avoid the duplication.
> 
> No functional changes intended. Compile tested only.
> 
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
>  drivers/interconnect/qcom/smd-rpm.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry
Re: [PATCH 1/2] interconnect: qcom: smd-rpm: drop duplicated QCOM_RPM_SMD_KEY_RATE define
Posted by Konrad Dybcio 2 weeks, 3 days ago
On 1/22/26 8:34 PM, Gabor Juhos wrote:
> The 'linux/soc/qcom/smd-rpm.h' header defines QCOM_RPM_SMD_KEY_RATE
> with the exact same value.
> 
>   $ git grep -nHE 'define[[:blank:]]+QCOM_RPM_SMD_KEY_RATE[[:blank:]]'
>   drivers/interconnect/qcom/smd-rpm.c:17:#define QCOM_RPM_SMD_KEY_RATE    0x007a484b
>   include/linux/soc/qcom/smd-rpm.h:52:#define QCOM_RPM_SMD_KEY_RATE                               0x007a484b
> 
> Drop the local define to avoid the duplication.
> 
> No functional changes intended. Compile tested only.
> 
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad