Convert all imports in the devres to use "kernel vertical" style.
Cc: Gary Guo <gary@garyguo.net>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Signed-off-by: Zhi Wang <zhiw@nvidia.com>
---
rust/kernel/devres.rs | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
index db02f8b1788d..43089511bf76 100644
--- a/rust/kernel/devres.rs
+++ b/rust/kernel/devres.rs
@@ -254,8 +254,12 @@ pub fn device(&self) -> &Device {
/// # Examples
///
/// ```no_run
- /// # #![cfg(CONFIG_PCI)]
- /// # use kernel::{device::Core, devres::Devres, pci};
+ /// #![cfg(CONFIG_PCI)]
+ /// use kernel::{
+ /// device::Core,
+ /// devres::Devres,
+ /// pci, //
+ /// };
///
/// fn from_core(dev: &pci::Device<Core>, devres: Devres<pci::Bar<0x4>>) -> Result {
/// let bar = devres.access(dev.as_ref())?;
@@ -358,7 +362,13 @@ fn register_foreign<P>(dev: &Device<Bound>, data: P) -> Result
/// # Examples
///
/// ```no_run
-/// use kernel::{device::{Bound, Device}, devres};
+/// use kernel::{
+/// device::{
+/// Bound,
+/// Device, //
+/// },
+/// devres, //
+/// };
///
/// /// Registration of e.g. a class device, IRQ, etc.
/// struct Registration;
--
2.51.0
On Wed Jan 21, 2026 at 2:23 PM GMT, Zhi Wang wrote:
> Convert all imports in the devres to use "kernel vertical" style.
>
> Cc: Gary Guo <gary@garyguo.net>
> Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
It does not look like this patch has been changed but yet you didn't pick up my
R-b tag.
Also this is still using the wrong email address for Miguel without using
the .mailmap.
Best,
Gary
> ---
> rust/kernel/devres.rs | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
> index db02f8b1788d..43089511bf76 100644
> --- a/rust/kernel/devres.rs
> +++ b/rust/kernel/devres.rs
> @@ -254,8 +254,12 @@ pub fn device(&self) -> &Device {
> /// # Examples
> ///
> /// ```no_run
> - /// # #![cfg(CONFIG_PCI)]
> - /// # use kernel::{device::Core, devres::Devres, pci};
> + /// #![cfg(CONFIG_PCI)]
> + /// use kernel::{
> + /// device::Core,
> + /// devres::Devres,
> + /// pci, //
> + /// };
> ///
> /// fn from_core(dev: &pci::Device<Core>, devres: Devres<pci::Bar<0x4>>) -> Result {
> /// let bar = devres.access(dev.as_ref())?;
> @@ -358,7 +362,13 @@ fn register_foreign<P>(dev: &Device<Bound>, data: P) -> Result
> /// # Examples
> ///
> /// ```no_run
> -/// use kernel::{device::{Bound, Device}, devres};
> +/// use kernel::{
> +/// device::{
> +/// Bound,
> +/// Device, //
> +/// },
> +/// devres, //
> +/// };
> ///
> /// /// Registration of e.g. a class device, IRQ, etc.
> /// struct Registration;
On Wed, 21 Jan 2026 14:54:16 +0000
"Gary Guo" <gary@garyguo.net> wrote:
> On Wed Jan 21, 2026 at 2:23 PM GMT, Zhi Wang wrote:
> > Convert all imports in the devres to use "kernel vertical" style.
> >
> > Cc: Gary Guo <gary@garyguo.net>
> > Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> > Signed-off-by: Zhi Wang <zhiw@nvidia.com>
>
> It does not look like this patch has been changed but yet you didn't
> pick up my R-b tag.
>
> Also this is still using the wrong email address for Miguel without using
> the .mailmap.
>
Oh, this piece must be missed during the rebasing. Will fix it in the next
re-spin.
> Best,
> Gary
>
> > ---
> > rust/kernel/devres.rs | 16 +++++++++++++---
> > 1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
> > index db02f8b1788d..43089511bf76 100644
> > --- a/rust/kernel/devres.rs
> > +++ b/rust/kernel/devres.rs
> > @@ -254,8 +254,12 @@ pub fn device(&self) -> &Device {
> > /// # Examples
> > ///
> > /// ```no_run
> > - /// # #![cfg(CONFIG_PCI)]
> > - /// # use kernel::{device::Core, devres::Devres, pci};
> > + /// #![cfg(CONFIG_PCI)]
> > + /// use kernel::{
> > + /// device::Core,
> > + /// devres::Devres,
> > + /// pci, //
> > + /// };
> > ///
> > /// fn from_core(dev: &pci::Device<Core>, devres:
> > Devres<pci::Bar<0x4>>) -> Result { /// let bar =
> > devres.access(dev.as_ref())?; @@ -358,7 +362,13 @@ fn
> > register_foreign<P>(dev: &Device<Bound>, data: P) -> Result /// #
> > Examples ///
> > /// ```no_run
> > -/// use kernel::{device::{Bound, Device}, devres};
> > +/// use kernel::{
> > +/// device::{
> > +/// Bound,
> > +/// Device, //
> > +/// },
> > +/// devres, //
> > +/// };
> > ///
> > /// /// Registration of e.g. a class device, IRQ, etc.
> > /// struct Registration;
>
© 2016 - 2026 Red Hat, Inc.