arm64: dts: qcom: add Acer Swift SFA14-11 support

[PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

Posted by weifu wu 2 weeks, 5 days ago

Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.

This introduces a new compatible string for the Acer Swift SFA14-11 board.

dt_binding_check and dtbs_check passed without errors

Signed-off-by: weifu wu <wwfu06@163.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index d48c625d3fc4..3de631667701 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1076,6 +1076,7 @@ properties:
 
       - items:
           - enum:
+              - acer,swift-sfa14-11
               - lenovo,thinkpad-t14s-lcd
               - lenovo,thinkpad-t14s-oled
           - const: lenovo,thinkpad-t14s
-- 
2.51.0

Re: [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

Posted by Konrad Dybcio 1 week, 5 days ago

On 1/21/26 12:27 PM, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.
> 
> This introduces a new compatible string for the Acer Swift SFA14-11 board.
> 
> dt_binding_check and dtbs_check passed without errors
> 
> Signed-off-by: weifu wu <wwfu06@163.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d48c625d3fc4..3de631667701 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1076,6 +1076,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - acer,swift-sfa14-11
>                - lenovo,thinkpad-t14s-lcd
>                - lenovo,thinkpad-t14s-oled
>            - const: lenovo,thinkpad-t14s

This needs its own hunk, your patch as-is says:

"Acer built the Swift SFA14-11 on top of the Lenovo ThinkPad T14s's
motherboard."

Which I'm sure isn't true

Konrad

Re: [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

Posted by Konrad Dybcio 1 week, 5 days ago

On 1/28/26 12:55 PM, Konrad Dybcio wrote:
> On 1/21/26 12:27 PM, weifu wu wrote:
>> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.
>>
>> This introduces a new compatible string for the Acer Swift SFA14-11 board.
>>
>> dt_binding_check and dtbs_check passed without errors
>>
>> Signed-off-by: weifu wu <wwfu06@163.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index d48c625d3fc4..3de631667701 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1076,6 +1076,7 @@ properties:
>>  
>>        - items:
>>            - enum:
>> +              - acer,swift-sfa14-11
>>                - lenovo,thinkpad-t14s-lcd
>>                - lenovo,thinkpad-t14s-oled
>>            - const: lenovo,thinkpad-t14s
> 
> This needs its own hunk, your patch as-is says:
> 
> "Acer built the Swift SFA14-11 on top of the Lenovo ThinkPad T14s's
> motherboard."
> 
> Which I'm sure isn't true
> 
> Konrad

You replied to me in private. If you want the discussion to
continue, please resend the message to the list, keeping all
the recipients of the thread.

Konrad

Re: [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11

Posted by Krzysztof Kozlowski 2 weeks, 5 days ago

On 21/01/2026 12:27, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> This introduces a new compatible string for the Acer Swift SFA14-11 board.

Nothing here explains why you think this is compatible with Lenovo T14s.
I really doubt that Acer laptop is compatible, but if you have proper
claims please always write them in commit msg.
> 
> dt_binding_check and dtbs_check passed without errors

Drop, not relevant. This is obvious. Why git history should store
information that you build your code?

> 
> Signed-off-by: weifu wu <wwfu06@163.com>
> ---
Best regards,
Krzysztof